diff options
author | Wang Chen <wangchen@cn.fujitsu.com> | 2008-09-26 04:20:32 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2008-10-08 19:02:40 -0400 |
commit | e824b3eb4acad16c64c9ddf8e63b63e2469259b0 (patch) | |
tree | e350547cda629039cdaa3d3995541985070eda64 | |
parent | 9ac1353f3832716eb25268c0cd06c93080a83c7b (diff) |
skge: Fix skge_set_ring_param() losing error return
The error return is useful to caller, driver shouldn't miss it.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/skge.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/skge.c b/drivers/net/skge.c index 3bca52c142f..43f4c730be4 100644 --- a/drivers/net/skge.c +++ b/drivers/net/skge.c | |||
@@ -501,7 +501,7 @@ static int skge_set_ring_param(struct net_device *dev, | |||
501 | struct ethtool_ringparam *p) | 501 | struct ethtool_ringparam *p) |
502 | { | 502 | { |
503 | struct skge_port *skge = netdev_priv(dev); | 503 | struct skge_port *skge = netdev_priv(dev); |
504 | int err; | 504 | int err = 0; |
505 | 505 | ||
506 | if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE || | 506 | if (p->rx_pending == 0 || p->rx_pending > MAX_RX_RING_SIZE || |
507 | p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE) | 507 | p->tx_pending < TX_LOW_WATER || p->tx_pending > MAX_TX_RING_SIZE) |
@@ -517,7 +517,7 @@ static int skge_set_ring_param(struct net_device *dev, | |||
517 | dev_close(dev); | 517 | dev_close(dev); |
518 | } | 518 | } |
519 | 519 | ||
520 | return 0; | 520 | return err; |
521 | } | 521 | } |
522 | 522 | ||
523 | static u32 skge_get_msglevel(struct net_device *netdev) | 523 | static u32 skge_get_msglevel(struct net_device *netdev) |