diff options
author | Johannes Berg <johannes.berg@intel.com> | 2010-09-22 12:02:00 -0400 |
---|---|---|
committer | Wey-Yi Guy <wey-yi.w.guy@intel.com> | 2010-10-07 18:50:18 -0400 |
commit | d3f5ba958d6c425a87535c6fa2a69ca90eb6e930 (patch) | |
tree | 0b19fb0c471fcea051cf3f08cbfd5d4e14169ce8 | |
parent | 575ccfd0f47e5d791246cb03c07d636190322fa1 (diff) |
iwlwifi: remove verify_signature eeprom operation
All drivers share the same implementation, so
there's no need to call this via a function
pointer nor to export it.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-1000.c | 1 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-3945.c | 1 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-4965.c | 1 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-5000.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-6000.c | 2 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-eeprom.c | 5 | ||||
-rw-r--r-- | drivers/net/wireless/iwlwifi/iwl-eeprom.h | 1 |
7 files changed, 2 insertions, 11 deletions
diff --git a/drivers/net/wireless/iwlwifi/iwl-1000.c b/drivers/net/wireless/iwlwifi/iwl-1000.c index 134f5454133..8c2db55df42 100644 --- a/drivers/net/wireless/iwlwifi/iwl-1000.c +++ b/drivers/net/wireless/iwlwifi/iwl-1000.c | |||
@@ -209,7 +209,6 @@ static struct iwl_lib_ops iwl1000_lib = { | |||
209 | EEPROM_REG_BAND_24_HT40_CHANNELS, | 209 | EEPROM_REG_BAND_24_HT40_CHANNELS, |
210 | EEPROM_REG_BAND_52_HT40_CHANNELS | 210 | EEPROM_REG_BAND_52_HT40_CHANNELS |
211 | }, | 211 | }, |
212 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
213 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 212 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
214 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 213 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
215 | .calib_version = iwlagn_eeprom_calib_version, | 214 | .calib_version = iwlagn_eeprom_calib_version, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945.c b/drivers/net/wireless/iwlwifi/iwl-3945.c index ef670879e35..a7dbb2806b1 100644 --- a/drivers/net/wireless/iwlwifi/iwl-3945.c +++ b/drivers/net/wireless/iwlwifi/iwl-3945.c | |||
@@ -2686,7 +2686,6 @@ static struct iwl_lib_ops iwl3945_lib = { | |||
2686 | EEPROM_REGULATORY_BAND_NO_HT40, | 2686 | EEPROM_REGULATORY_BAND_NO_HT40, |
2687 | EEPROM_REGULATORY_BAND_NO_HT40, | 2687 | EEPROM_REGULATORY_BAND_NO_HT40, |
2688 | }, | 2688 | }, |
2689 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
2690 | .acquire_semaphore = iwl3945_eeprom_acquire_semaphore, | 2689 | .acquire_semaphore = iwl3945_eeprom_acquire_semaphore, |
2691 | .release_semaphore = iwl3945_eeprom_release_semaphore, | 2690 | .release_semaphore = iwl3945_eeprom_release_semaphore, |
2692 | .query_addr = iwlcore_eeprom_query_addr, | 2691 | .query_addr = iwlcore_eeprom_query_addr, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-4965.c b/drivers/net/wireless/iwlwifi/iwl-4965.c index 20626c997b4..08d2dbc4efb 100644 --- a/drivers/net/wireless/iwlwifi/iwl-4965.c +++ b/drivers/net/wireless/iwlwifi/iwl-4965.c | |||
@@ -2280,7 +2280,6 @@ static struct iwl_lib_ops iwl4965_lib = { | |||
2280 | EEPROM_4965_REGULATORY_BAND_24_HT40_CHANNELS, | 2280 | EEPROM_4965_REGULATORY_BAND_24_HT40_CHANNELS, |
2281 | EEPROM_4965_REGULATORY_BAND_52_HT40_CHANNELS | 2281 | EEPROM_4965_REGULATORY_BAND_52_HT40_CHANNELS |
2282 | }, | 2282 | }, |
2283 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
2284 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 2283 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
2285 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 2284 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
2286 | .calib_version = iwl4965_eeprom_calib_version, | 2285 | .calib_version = iwl4965_eeprom_calib_version, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-5000.c b/drivers/net/wireless/iwlwifi/iwl-5000.c index 1b25ad63b5c..ddbbb9320ac 100644 --- a/drivers/net/wireless/iwlwifi/iwl-5000.c +++ b/drivers/net/wireless/iwlwifi/iwl-5000.c | |||
@@ -384,7 +384,6 @@ static struct iwl_lib_ops iwl5000_lib = { | |||
384 | EEPROM_REG_BAND_24_HT40_CHANNELS, | 384 | EEPROM_REG_BAND_24_HT40_CHANNELS, |
385 | EEPROM_REG_BAND_52_HT40_CHANNELS | 385 | EEPROM_REG_BAND_52_HT40_CHANNELS |
386 | }, | 386 | }, |
387 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
388 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 387 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
389 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 388 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
390 | .calib_version = iwlagn_eeprom_calib_version, | 389 | .calib_version = iwlagn_eeprom_calib_version, |
@@ -456,7 +455,6 @@ static struct iwl_lib_ops iwl5150_lib = { | |||
456 | EEPROM_REG_BAND_24_HT40_CHANNELS, | 455 | EEPROM_REG_BAND_24_HT40_CHANNELS, |
457 | EEPROM_REG_BAND_52_HT40_CHANNELS | 456 | EEPROM_REG_BAND_52_HT40_CHANNELS |
458 | }, | 457 | }, |
459 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
460 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 458 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
461 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 459 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
462 | .calib_version = iwlagn_eeprom_calib_version, | 460 | .calib_version = iwlagn_eeprom_calib_version, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-6000.c b/drivers/net/wireless/iwlwifi/iwl-6000.c index 6261aec5ebd..198cd8f40de 100644 --- a/drivers/net/wireless/iwlwifi/iwl-6000.c +++ b/drivers/net/wireless/iwlwifi/iwl-6000.c | |||
@@ -323,7 +323,6 @@ static struct iwl_lib_ops iwl6000_lib = { | |||
323 | EEPROM_6000_REG_BAND_24_HT40_CHANNELS, | 323 | EEPROM_6000_REG_BAND_24_HT40_CHANNELS, |
324 | EEPROM_REG_BAND_52_HT40_CHANNELS | 324 | EEPROM_REG_BAND_52_HT40_CHANNELS |
325 | }, | 325 | }, |
326 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
327 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 326 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
328 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 327 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
329 | .calib_version = iwlagn_eeprom_calib_version, | 328 | .calib_version = iwlagn_eeprom_calib_version, |
@@ -398,7 +397,6 @@ static struct iwl_lib_ops iwl6000g2b_lib = { | |||
398 | EEPROM_6000_REG_BAND_24_HT40_CHANNELS, | 397 | EEPROM_6000_REG_BAND_24_HT40_CHANNELS, |
399 | EEPROM_REG_BAND_52_HT40_CHANNELS | 398 | EEPROM_REG_BAND_52_HT40_CHANNELS |
400 | }, | 399 | }, |
401 | .verify_signature = iwlcore_eeprom_verify_signature, | ||
402 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, | 400 | .acquire_semaphore = iwlcore_eeprom_acquire_semaphore, |
403 | .release_semaphore = iwlcore_eeprom_release_semaphore, | 401 | .release_semaphore = iwlcore_eeprom_release_semaphore, |
404 | .calib_version = iwlagn_eeprom_calib_version, | 402 | .calib_version = iwlagn_eeprom_calib_version, |
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.c b/drivers/net/wireless/iwlwifi/iwl-eeprom.c index 88f4a80d473..bd51b06288e 100644 --- a/drivers/net/wireless/iwlwifi/iwl-eeprom.c +++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.c | |||
@@ -214,7 +214,7 @@ static const struct iwl_txpwr_section enhinfo[] = { | |||
214 | * | 214 | * |
215 | ******************************************************************************/ | 215 | ******************************************************************************/ |
216 | 216 | ||
217 | int iwlcore_eeprom_verify_signature(struct iwl_priv *priv) | 217 | static int iwl_eeprom_verify_signature(struct iwl_priv *priv) |
218 | { | 218 | { |
219 | u32 gp = iwl_read32(priv, CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK; | 219 | u32 gp = iwl_read32(priv, CSR_EEPROM_GP) & CSR_EEPROM_GP_VALID_MSK; |
220 | int ret = 0; | 220 | int ret = 0; |
@@ -246,7 +246,6 @@ int iwlcore_eeprom_verify_signature(struct iwl_priv *priv) | |||
246 | } | 246 | } |
247 | return ret; | 247 | return ret; |
248 | } | 248 | } |
249 | EXPORT_SYMBOL(iwlcore_eeprom_verify_signature); | ||
250 | 249 | ||
251 | static void iwl_set_otp_access(struct iwl_priv *priv, enum iwl_access_mode mode) | 250 | static void iwl_set_otp_access(struct iwl_priv *priv, enum iwl_access_mode mode) |
252 | { | 251 | { |
@@ -523,7 +522,7 @@ int iwl_eeprom_init(struct iwl_priv *priv) | |||
523 | 522 | ||
524 | priv->cfg->ops->lib->apm_ops.init(priv); | 523 | priv->cfg->ops->lib->apm_ops.init(priv); |
525 | 524 | ||
526 | ret = priv->cfg->ops->lib->eeprom_ops.verify_signature(priv); | 525 | ret = iwl_eeprom_verify_signature(priv); |
527 | if (ret < 0) { | 526 | if (ret < 0) { |
528 | IWL_ERR(priv, "EEPROM not found, EEPROM_GP=0x%08x\n", gp); | 527 | IWL_ERR(priv, "EEPROM not found, EEPROM_GP=0x%08x\n", gp); |
529 | ret = -ENOENT; | 528 | ret = -ENOENT; |
diff --git a/drivers/net/wireless/iwlwifi/iwl-eeprom.h b/drivers/net/wireless/iwlwifi/iwl-eeprom.h index a4772aff51f..2ae0a11e523 100644 --- a/drivers/net/wireless/iwlwifi/iwl-eeprom.h +++ b/drivers/net/wireless/iwlwifi/iwl-eeprom.h | |||
@@ -493,7 +493,6 @@ struct iwl_eeprom_calib_info { | |||
493 | 493 | ||
494 | struct iwl_eeprom_ops { | 494 | struct iwl_eeprom_ops { |
495 | const u32 regulatory_bands[7]; | 495 | const u32 regulatory_bands[7]; |
496 | int (*verify_signature) (struct iwl_priv *priv); | ||
497 | int (*acquire_semaphore) (struct iwl_priv *priv); | 496 | int (*acquire_semaphore) (struct iwl_priv *priv); |
498 | void (*release_semaphore) (struct iwl_priv *priv); | 497 | void (*release_semaphore) (struct iwl_priv *priv); |
499 | u16 (*calib_version) (struct iwl_priv *priv); | 498 | u16 (*calib_version) (struct iwl_priv *priv); |