diff options
author | Li Zefan <lizf@cn.fujitsu.com> | 2010-05-24 04:22:30 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2010-06-28 17:12:44 -0400 |
commit | c9642c49aae1272d7c24008a40ae614470b957a6 (patch) | |
tree | dd42bf76ad9652bc952c0332b14e0b3b7ea38d3c | |
parent | f384c954c9fe3d3c6fce5ae66b67f2ddd947d098 (diff) |
tracing: Use a global field list for all syscall exit events
All syscall exit events have the same fields.
The kernel size drops 2.5K:
text data bss dec hex filename
7018612 2034376 7251132 16304120 f8c7f8 vmlinux.o.orig
7018612 2031888 7251132 16301632 f8be40 vmlinux.o
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
LKML-Reference: <4BFA3746.8070100@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r-- | include/linux/syscalls.h | 2 | ||||
-rw-r--r-- | include/trace/syscall.h | 1 | ||||
-rw-r--r-- | kernel/trace/trace_syscalls.c | 7 |
3 files changed, 4 insertions, 6 deletions
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h index 7f614ce274a..7994bd44eb5 100644 --- a/include/linux/syscalls.h +++ b/include/linux/syscalls.h | |||
@@ -165,7 +165,6 @@ extern struct trace_event_functions exit_syscall_print_funcs; | |||
165 | .enter_event = &event_enter_##sname, \ | 165 | .enter_event = &event_enter_##sname, \ |
166 | .exit_event = &event_exit_##sname, \ | 166 | .exit_event = &event_exit_##sname, \ |
167 | .enter_fields = LIST_HEAD_INIT(__syscall_meta_##sname.enter_fields), \ | 167 | .enter_fields = LIST_HEAD_INIT(__syscall_meta_##sname.enter_fields), \ |
168 | .exit_fields = LIST_HEAD_INIT(__syscall_meta_##sname.exit_fields), \ | ||
169 | }; | 168 | }; |
170 | 169 | ||
171 | #define SYSCALL_DEFINE0(sname) \ | 170 | #define SYSCALL_DEFINE0(sname) \ |
@@ -180,7 +179,6 @@ extern struct trace_event_functions exit_syscall_print_funcs; | |||
180 | .enter_event = &event_enter__##sname, \ | 179 | .enter_event = &event_enter__##sname, \ |
181 | .exit_event = &event_exit__##sname, \ | 180 | .exit_event = &event_exit__##sname, \ |
182 | .enter_fields = LIST_HEAD_INIT(__syscall_meta__##sname.enter_fields), \ | 181 | .enter_fields = LIST_HEAD_INIT(__syscall_meta__##sname.enter_fields), \ |
183 | .exit_fields = LIST_HEAD_INIT(__syscall_meta__##sname.exit_fields), \ | ||
184 | }; \ | 182 | }; \ |
185 | asmlinkage long sys_##sname(void) | 183 | asmlinkage long sys_##sname(void) |
186 | #else | 184 | #else |
diff --git a/include/trace/syscall.h b/include/trace/syscall.h index 257e08960d7..31966a4fb8c 100644 --- a/include/trace/syscall.h +++ b/include/trace/syscall.h | |||
@@ -26,7 +26,6 @@ struct syscall_metadata { | |||
26 | const char **types; | 26 | const char **types; |
27 | const char **args; | 27 | const char **args; |
28 | struct list_head enter_fields; | 28 | struct list_head enter_fields; |
29 | struct list_head exit_fields; | ||
30 | 29 | ||
31 | struct ftrace_event_call *enter_event; | 30 | struct ftrace_event_call *enter_event; |
32 | struct ftrace_event_call *exit_event; | 31 | struct ftrace_event_call *exit_event; |
diff --git a/kernel/trace/trace_syscalls.c b/kernel/trace/trace_syscalls.c index 34e35804304..bac752f0cfb 100644 --- a/kernel/trace/trace_syscalls.c +++ b/kernel/trace/trace_syscalls.c | |||
@@ -23,6 +23,9 @@ static int syscall_exit_register(struct ftrace_event_call *event, | |||
23 | static int syscall_enter_define_fields(struct ftrace_event_call *call); | 23 | static int syscall_enter_define_fields(struct ftrace_event_call *call); |
24 | static int syscall_exit_define_fields(struct ftrace_event_call *call); | 24 | static int syscall_exit_define_fields(struct ftrace_event_call *call); |
25 | 25 | ||
26 | /* All syscall exit events have the same fields */ | ||
27 | static LIST_HEAD(syscall_exit_fields); | ||
28 | |||
26 | static struct list_head * | 29 | static struct list_head * |
27 | syscall_get_enter_fields(struct ftrace_event_call *call) | 30 | syscall_get_enter_fields(struct ftrace_event_call *call) |
28 | { | 31 | { |
@@ -34,9 +37,7 @@ syscall_get_enter_fields(struct ftrace_event_call *call) | |||
34 | static struct list_head * | 37 | static struct list_head * |
35 | syscall_get_exit_fields(struct ftrace_event_call *call) | 38 | syscall_get_exit_fields(struct ftrace_event_call *call) |
36 | { | 39 | { |
37 | struct syscall_metadata *entry = call->data; | 40 | return &syscall_exit_fields; |
38 | |||
39 | return &entry->exit_fields; | ||
40 | } | 41 | } |
41 | 42 | ||
42 | struct trace_event_functions enter_syscall_print_funcs = { | 43 | struct trace_event_functions enter_syscall_print_funcs = { |