aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJiri Olsa <jolsa@redhat.com>2011-02-02 07:28:18 -0500
committerSteven Rostedt <rostedt@goodmis.org>2011-02-08 11:57:22 -0500
commit5e38ca8f3ea423442eaafe1b7e206084aa38120a (patch)
treebcebbf4ae2620d5cd169f1c748a0ddc30fd97d3d
parentae07f551c42d6e4162436ca452a199deac9dab4d (diff)
tracing: Add unstable sched clock note to the warning
The warning "Delta way too big" warning might appear on a system with unstable shed clock right after the system is resumed and tracing was enabled during the suspend. Since it's not realy bug, and the unstable sched clock is working fast and reliable otherwise, Steven suggested to keep using the sched clock in any case and just to make note in the warning itself. Signed-off-by: Jiri Olsa <jolsa@redhat.com> LKML-Reference: <1296649698-6003-1-git-send-email-jolsa@redhat.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
-rw-r--r--kernel/trace/ring_buffer.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
index bd1c35a4fbc..7739893a1d0 100644
--- a/kernel/trace/ring_buffer.c
+++ b/kernel/trace/ring_buffer.c
@@ -2163,10 +2163,14 @@ rb_reserve_next_event(struct ring_buffer *buffer,
2163 delta = diff; 2163 delta = diff;
2164 if (unlikely(test_time_stamp(delta))) { 2164 if (unlikely(test_time_stamp(delta))) {
2165 WARN_ONCE(delta > (1ULL << 59), 2165 WARN_ONCE(delta > (1ULL << 59),
2166 KERN_WARNING "Delta way too big! %llu ts=%llu write stamp = %llu\n", 2166 KERN_WARNING "Delta way too big! %llu ts=%llu write stamp = %llu\n%s",
2167 (unsigned long long)delta, 2167 (unsigned long long)delta,
2168 (unsigned long long)ts, 2168 (unsigned long long)ts,
2169 (unsigned long long)cpu_buffer->write_stamp); 2169 (unsigned long long)cpu_buffer->write_stamp,
2170 sched_clock_stable ? "" :
2171 "If you just came from a suspend/resume,\n"
2172 "please switch to the trace global clock:\n"
2173 " echo global > /sys/kernel/debug/tracing/trace_clock\n");
2170 add_timestamp = 1; 2174 add_timestamp = 1;
2171 } 2175 }
2172 } 2176 }