aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLudovic Desroches <ludovic.desroches@atmel.com>2012-03-28 06:28:33 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-04-13 11:14:07 -0400
commit52a77de9f23e3b3d88354ee59a8923d566935abd (patch)
tree04504c82c5b61e2119c5ced1d2efb28129d52890
parente5acefebad4863015271b91f865c62def9bfed82 (diff)
mmc: atmel-mci: correct data timeout computation
commit 66292ad92c6d3f2f1c137a1c826b331ca8595dfd upstream. The HSMCI operates at a rate of up to Master Clock divided by two. Moreover previous calculation can cause overflows and so wrong timeouts. Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Signed-off-by: Chris Ball <cjb@laptop.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/mmc/host/atmel-mci.c9
1 files changed, 8 insertions, 1 deletions
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index aa8039f473c..b6cd3867f72 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -468,7 +468,14 @@ err:
468static inline unsigned int ns_to_clocks(struct atmel_mci *host, 468static inline unsigned int ns_to_clocks(struct atmel_mci *host,
469 unsigned int ns) 469 unsigned int ns)
470{ 470{
471 return (ns * (host->bus_hz / 1000000) + 999) / 1000; 471 /*
472 * It is easier here to use us instead of ns for the timeout,
473 * it prevents from overflows during calculation.
474 */
475 unsigned int us = DIV_ROUND_UP(ns, 1000);
476
477 /* Maximum clock frequency is host->bus_hz/2 */
478 return us * (DIV_ROUND_UP(host->bus_hz, 2000000));
472} 479}
473 480
474static void atmci_set_timeout(struct atmel_mci *host, 481static void atmci_set_timeout(struct atmel_mci *host,