diff options
author | Daniel Ritz <daniel.ritz@gmx.ch> | 2005-09-29 15:39:32 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-09-30 12:23:30 -0400 |
commit | 03cdc0c304e1c068d49adc32264f07af76253e4c (patch) | |
tree | 04e9dcf7801245d9a31fcab36dde7dd3a846c86b | |
parent | 1294b118cb53fb14515666e2b218ad5ab40318c1 (diff) |
[PATCH] usb/core/hcd-pci.c: don't free_irq() on suspend
the free_irq() in USB suspend breaks resume on some setups where USB
(ohci/ehci) shares the interrupt with an other device.
Signed-off-by: Daniel Ritz <daniel.ritz@gmx.ch>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rw-r--r-- | drivers/usb/core/hcd-pci.c | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/core/hcd-pci.c index cbb451d227d..6385d1a99b6 100644 --- a/drivers/usb/core/hcd-pci.c +++ b/drivers/usb/core/hcd-pci.c | |||
@@ -242,7 +242,6 @@ int usb_hcd_pci_suspend (struct pci_dev *dev, pm_message_t message) | |||
242 | case HC_STATE_SUSPENDED: | 242 | case HC_STATE_SUSPENDED: |
243 | /* no DMA or IRQs except when HC is active */ | 243 | /* no DMA or IRQs except when HC is active */ |
244 | if (dev->current_state == PCI_D0) { | 244 | if (dev->current_state == PCI_D0) { |
245 | free_irq (hcd->irq, hcd); | ||
246 | pci_save_state (dev); | 245 | pci_save_state (dev); |
247 | pci_disable_device (dev); | 246 | pci_disable_device (dev); |
248 | } | 247 | } |
@@ -374,14 +373,6 @@ int usb_hcd_pci_resume (struct pci_dev *dev) | |||
374 | 373 | ||
375 | hcd->state = HC_STATE_RESUMING; | 374 | hcd->state = HC_STATE_RESUMING; |
376 | hcd->saw_irq = 0; | 375 | hcd->saw_irq = 0; |
377 | retval = request_irq (dev->irq, usb_hcd_irq, SA_SHIRQ, | ||
378 | hcd->irq_descr, hcd); | ||
379 | if (retval < 0) { | ||
380 | dev_err (hcd->self.controller, | ||
381 | "can't restore IRQ after resume!\n"); | ||
382 | usb_hc_died (hcd); | ||
383 | return retval; | ||
384 | } | ||
385 | 376 | ||
386 | retval = hcd->driver->resume (hcd); | 377 | retval = hcd->driver->resume (hcd); |
387 | if (!HC_IS_RUNNING (hcd->state)) { | 378 | if (!HC_IS_RUNNING (hcd->state)) { |