21 files changed, 227 insertions, 372 deletions

diff --git a/drivers/usb/serial/aircable.c b/drivers/usb/serial/aircable.c
index 2cbfab3716e5..b10ac8409411 100644
--- a/drivers/usb/serial/aircable.c
+++ b/drivers/usb/serial/aircable.c
@@ -554,13 +554,12 @@ static void aircable_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct aircable_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->rx_lock, flags);
+        spin_lock_irq(&priv->rx_lock);
         priv->rx_flags |= THROTTLED;
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
+        spin_unlock_irq(&priv->rx_lock);
 }
 
 /* Based on ftdi_sio.c unthrottle */
@@ -569,14 +568,13 @@ static void aircable_unthrottle(struct tty_struct *tty)
         struct usb_serial_port *port = tty->driver_data;
         struct aircable_private *priv = usb_get_serial_port_data(port);
         int actually_throttled;
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->rx_lock, flags);
+        spin_lock_irq(&priv->rx_lock);
         actually_throttled = priv->rx_flags & ACTUALLY_THROTTLED;
         priv->rx_flags &= ~(THROTTLED | ACTUALLY_THROTTLED);
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
+        spin_unlock_irq(&priv->rx_lock);
 
         if (actually_throttled)
                 schedule_work(&priv->rx_work);
diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index 4a208fe85bc9..698252a4dc5d 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -113,6 +113,7 @@ static struct usb_device_id id_table [] = {
         { USB_DEVICE(0x166A, 0x0303) }, /* Clipsal 5500PCU C-Bus USB interface */
         { USB_DEVICE(0x16D6, 0x0001) }, /* Jablotron serial interface */
         { USB_DEVICE(0x18EF, 0xE00F) }, /* ELV USB-I2C-Interface */
+        { USB_DEVICE(0x413C, 0x9500) }, /* DW700 GPS USB interface */
         { } /* Terminating Entry */
 };
 
diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c
index e0a8b715f2f2..a591ebec0f89 100644
--- a/drivers/usb/serial/cypress_m8.c
+++ b/drivers/usb/serial/cypress_m8.c
@@ -1155,13 +1155,12 @@ static void cypress_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct cypress_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->rx_flags = THROTTLED;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 }
 
 
@@ -1170,14 +1169,13 @@ static void cypress_unthrottle(struct tty_struct *tty)
         struct usb_serial_port *port = tty->driver_data;
         struct cypress_private *priv = usb_get_serial_port_data(port);
         int actually_throttled, result;
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         actually_throttled = priv->rx_flags & ACTUALLY_THROTTLED;
         priv->rx_flags = 0;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 
         if (!priv->comm_is_ok)
                 return;
@@ -1185,7 +1183,7 @@ static void cypress_unthrottle(struct tty_struct *tty)
         if (actually_throttled) {
                 port->interrupt_in_urb->dev = port->serial->dev;
 
-                result = usb_submit_urb(port->interrupt_in_urb, GFP_ATOMIC);
+                result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
                 if (result) {
                         dev_err(&port->dev, "%s - failed submitting read urb, "
                                         "error %d\n", __func__, result);
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index ab3dd991586b..68e80be6b9e1 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -898,16 +898,16 @@ static void digi_rx_unthrottle(struct tty_struct *tty)
 
         spin_lock_irqsave(&priv->dp_port_lock, flags);
 
-        /* turn throttle off */
-        priv->dp_throttled = 0;
-        priv->dp_throttle_restart = 0;
-
         /* restart read chain */
         if (priv->dp_throttle_restart) {
                 port->read_urb->dev = port->serial->dev;
                 ret = usb_submit_urb(port->read_urb, GFP_ATOMIC);
         }
 
+        /* turn throttle off */
+        priv->dp_throttled = 0;
+        priv->dp_throttle_restart = 0;
+
         spin_unlock_irqrestore(&priv->dp_port_lock, flags);
 
         if (ret)
diff --git a/drivers/usb/serial/empeg.c b/drivers/usb/serial/empeg.c
index 33c9e9cf9eb2..7dd0e3eadbe6 100644
--- a/drivers/usb/serial/empeg.c
+++ b/drivers/usb/serial/empeg.c
@@ -391,7 +391,7 @@ static void empeg_unthrottle(struct tty_struct *tty)
         dbg("%s - port %d", __func__, port->number);
 
         port->read_urb->dev = port->serial->dev;
-        result = usb_submit_urb(port->read_urb, GFP_ATOMIC);
+        result = usb_submit_urb(port->read_urb, GFP_KERNEL);
         if (result)
                 dev_err(&port->dev,
                         "%s - failed submitting read urb, error %d\n",
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 4f883b1773d0..9c60d6d4908a 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -76,13 +76,7 @@ struct ftdi_private {
         unsigned long last_dtr_rts;     /* saved modem control outputs */
         wait_queue_head_t delta_msr_wait; /* Used for TIOCMIWAIT */
         char prev_status, diff_status;        /* Used for TIOCMIWAIT */
-        __u8 rx_flags;          /* receive state flags (throttling) */
-        spinlock_t rx_lock;     /* spinlock for receive state */
-        struct delayed_work rx_work;
         struct usb_serial_port *port;
-        int rx_processed;
-        unsigned long rx_bytes;
-
         __u16 interface;        /* FT2232C, FT2232H or FT4232H port interface
                                    (0 for FT232/245) */
 
@@ -737,10 +731,6 @@ static const char *ftdi_chip_name[] = {
 /* Constants for read urb and write urb */
 #define BUFSZ 512
 
-/* rx_flags */
-#define THROTTLED               0x01
-#define ACTUALLY_THROTTLED      0x02
-
 /* Used for TIOCMIWAIT */
 #define FTDI_STATUS_B0_MASK     (FTDI_RS0_CTS | FTDI_RS0_DSR | FTDI_RS0_RI | FTDI_RS0_RLSD)
 #define FTDI_STATUS_B1_MASK     (FTDI_RS_BI)
@@ -763,7 +753,7 @@ static int  ftdi_write_room(struct tty_struct *tty);
 static int  ftdi_chars_in_buffer(struct tty_struct *tty);
 static void ftdi_write_bulk_callback(struct urb *urb);
 static void ftdi_read_bulk_callback(struct urb *urb);
-static void ftdi_process_read(struct work_struct *work);
+static void ftdi_process_read(struct usb_serial_port *port);
 static void ftdi_set_termios(struct tty_struct *tty,
                         struct usb_serial_port *port, struct ktermios *old);
 static int  ftdi_tiocmget(struct tty_struct *tty, struct file *file);
@@ -1234,7 +1224,6 @@ static int set_serial_info(struct tty_struct *tty,
                                         (new_serial.flags & ASYNC_FLAGS));
         priv->custom_divisor = new_serial.custom_divisor;
 
-        tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
         write_latency_timer(port);
 
 check_and_exit:
@@ -1527,7 +1516,6 @@ static int ftdi_sio_port_probe(struct usb_serial_port *port)
         }
 
         kref_init(&priv->kref);
-        spin_lock_init(&priv->rx_lock);
         spin_lock_init(&priv->tx_lock);
         init_waitqueue_head(&priv->delta_msr_wait);
         /* This will push the characters through immediately rather
@@ -1549,7 +1537,6 @@ static int ftdi_sio_port_probe(struct usb_serial_port *port)
                 port->read_urb->transfer_buffer_length = BUFSZ;
         }
 
-        INIT_DELAYED_WORK(&priv->rx_work, ftdi_process_read);
         priv->port = port;
 
         /* Free port's existing write urb and transfer buffer. */
@@ -1686,6 +1673,26 @@ static int ftdi_sio_port_remove(struct usb_serial_port *port)
         return 0;
 }
 
+static int ftdi_submit_read_urb(struct usb_serial_port *port, gfp_t mem_flags)
+{
+        struct urb *urb = port->read_urb;
+        struct usb_serial *serial = port->serial;
+        int result;
+
+        usb_fill_bulk_urb(urb, serial->dev,
+                           usb_rcvbulkpipe(serial->dev,
+                                        port->bulk_in_endpointAddress),
+                           urb->transfer_buffer,
+                           urb->transfer_buffer_length,
+                           ftdi_read_bulk_callback, port);
+        result = usb_submit_urb(urb, mem_flags);
+        if (result)
+                dev_err(&port->dev,
+                        "%s - failed submitting read urb, error %d\n",
+                                                        __func__, result);
+        return result;
+}
+
 static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
 { /* ftdi_open */
         struct usb_device *dev = port->serial->dev;
@@ -1700,12 +1707,6 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
         spin_lock_irqsave(&priv->tx_lock, flags);
         priv->tx_bytes = 0;
         spin_unlock_irqrestore(&priv->tx_lock, flags);
-        spin_lock_irqsave(&priv->rx_lock, flags);
-        priv->rx_bytes = 0;
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
-
-        if (tty)
-                tty->low_latency = (priv->flags & ASYNC_LOW_LATENCY) ? 1 : 0;
 
         write_latency_timer(port);
 
@@ -1725,23 +1726,14 @@ static int ftdi_open(struct tty_struct *tty, struct usb_serial_port *port)
                 ftdi_set_termios(tty, port, tty->termios);
 
         /* Not throttled */
-        spin_lock_irqsave(&priv->rx_lock, flags);
-        priv->rx_flags &= ~(THROTTLED | ACTUALLY_THROTTLED);
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
+        spin_lock_irqsave(&port->lock, flags);
+        port->throttled = 0;
+        port->throttle_req = 0;
+        spin_unlock_irqrestore(&port->lock, flags);
 
         /* Start reading from the device */
-        priv->rx_processed = 0;
-        usb_fill_bulk_urb(port->read_urb, dev,
-                        usb_rcvbulkpipe(dev, port->bulk_in_endpointAddress),
-                        port->read_urb->transfer_buffer,
-                                port->read_urb->transfer_buffer_length,
-                        ftdi_read_bulk_callback, port);
-        result = usb_submit_urb(port->read_urb, GFP_KERNEL);
-        if (result)
-                dev_err(&port->dev,
-                        "%s - failed submitting read urb, error %d\n",
-                        __func__, result);
-        else
+        result = ftdi_submit_read_urb(port, GFP_KERNEL);
+        if (!result)
                 kref_get(&priv->kref);
 
         return result;
@@ -1787,10 +1779,6 @@ static void ftdi_close(struct usb_serial_port *port)
 
         dbg("%s", __func__);
 
-
-        /* cancel any scheduled reading */
-        cancel_delayed_work_sync(&priv->rx_work);
-
         /* shutdown our bulk read */
         usb_kill_urb(port->read_urb);
         kref_put(&priv->kref, ftdi_sio_priv_release);
@@ -2013,271 +2001,121 @@ static int ftdi_chars_in_buffer(struct tty_struct *tty)
         return buffered;
 }
 
-static void ftdi_read_bulk_callback(struct urb *urb)
+static int ftdi_process_packet(struct tty_struct *tty,
+                struct usb_serial_port *port, struct ftdi_private *priv,
+                char *packet, int len)
 {
-        struct usb_serial_port *port = urb->context;
-        struct tty_struct *tty;
-        struct ftdi_private *priv;
-        unsigned long countread;
-        unsigned long flags;
-        int status = urb->status;
-
-        if (urb->number_of_packets > 0) {
-                dev_err(&port->dev, "%s transfer_buffer_length %d "
-                        "actual_length %d number of packets %d\n", __func__,
-                        urb->transfer_buffer_length,
-                        urb->actual_length, urb->number_of_packets);
-                dev_err(&port->dev, "%s transfer_flags %x\n", __func__,
-                        urb->transfer_flags);
-        }
+        int i;
+        char status;
+        char flag;
+        char *ch;
 
         dbg("%s - port %d", __func__, port->number);
 
-        if (port->port.count <= 0)
-                return;
-
-        tty = tty_port_tty_get(&port->port);
-        if (!tty) {
-                dbg("%s - bad tty pointer - exiting", __func__);
-                return;
+        if (len < 2) {
+                dbg("malformed packet");
+                return 0;
         }
 
-        priv = usb_get_serial_port_data(port);
-        if (!priv) {
-                dbg("%s - bad port private data pointer - exiting", __func__);
-                goto out;
+        /* Compare new line status to the old one, signal if different/
+           N.B. packet may be processed more than once, but differences
+           are only processed once.  */
+        status = packet[0] & FTDI_STATUS_B0_MASK;
+        if (status != priv->prev_status) {
+                priv->diff_status |= status ^ priv->prev_status;
+                wake_up_interruptible(&priv->delta_msr_wait);
+                priv->prev_status = status;
         }
 
-        if (urb != port->read_urb)
-                dev_err(&port->dev, "%s - Not my urb!\n", __func__);
-
-        if (status) {
-                /* This will happen at close every time so it is a dbg not an
-                   err */
-                dbg("(this is ok on close) nonzero read bulk status received: %d", status);
-                goto out;
+        /*
+         * Although the device uses a bitmask and hence can have multiple
+         * errors on a packet - the order here sets the priority the error is
+         * returned to the tty layer.
+         */
+        flag = TTY_NORMAL;
+        if (packet[1] & FTDI_RS_OE) {
+                flag = TTY_OVERRUN;
+                dbg("OVERRRUN error");
+        }
+        if (packet[1] & FTDI_RS_BI) {
+                flag = TTY_BREAK;
+                dbg("BREAK received");
+                usb_serial_handle_break(port);
+        }
+        if (packet[1] & FTDI_RS_PE) {
+                flag = TTY_PARITY;
+                dbg("PARITY error");
+        }
+        if (packet[1] & FTDI_RS_FE) {
+                flag = TTY_FRAME;
+                dbg("FRAMING error");
         }
 
-        /* count data bytes, but not status bytes */
-        countread = urb->actual_length;
-        countread -= 2 * DIV_ROUND_UP(countread, priv->max_packet_size);
-        spin_lock_irqsave(&priv->rx_lock, flags);
-        priv->rx_bytes += countread;
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
-
-        ftdi_process_read(&priv->rx_work.work);
-out:
-        tty_kref_put(tty);
-} /* ftdi_read_bulk_callback */
-
+        len -= 2;
+        if (!len)
+                return 0;       /* status only */
+        ch = packet + 2;
+
+        if (!(port->console && port->sysrq) && flag == TTY_NORMAL)
+                tty_insert_flip_string(tty, ch, len);
+        else {
+                for (i = 0; i < len; i++, ch++) {
+                        if (!usb_serial_handle_sysrq_char(tty, port, *ch))
+                                tty_insert_flip_char(tty, *ch, flag);
+                }
+        }
+        return len;
+}
 
-static void ftdi_process_read(struct work_struct *work)
-{ /* ftdi_process_read */
-        struct ftdi_private *priv =
-                container_of(work, struct ftdi_private, rx_work.work);
-        struct usb_serial_port *port = priv->port;
-        struct urb *urb;
+static void ftdi_process_read(struct usb_serial_port *port)
+{
+        struct urb *urb = port->read_urb;
         struct tty_struct *tty;
-        char error_flag;
-        unsigned char *data;
-
+        struct ftdi_private *priv = usb_get_serial_port_data(port);
+        char *data = (char *)urb->transfer_buffer;
         int i;
-        int result;
-        int need_flip;
-        int packet_offset;
-        unsigned long flags;
-
-        dbg("%s - port %d", __func__, port->number);
-
-        if (port->port.count <= 0)
-                return;
+        int len;
+        int count = 0;
 
         tty = tty_port_tty_get(&port->port);
-        if (!tty) {
-                dbg("%s - bad tty pointer - exiting", __func__);
+        if (!tty)
                 return;
-        }
-
-        priv = usb_get_serial_port_data(port);
-        if (!priv) {
-                dbg("%s - bad port private data pointer - exiting", __func__);
-                goto out;
-        }
-
-        urb = port->read_urb;
-        if (!urb) {
-                dbg("%s - bad read_urb pointer - exiting", __func__);
-                goto out;
-        }
-
-        data = urb->transfer_buffer;
 
-        if (priv->rx_processed) {
-                dbg("%s - already processed: %d bytes, %d remain", __func__,
-                                priv->rx_processed,
-                                urb->actual_length - priv->rx_processed);
-        } else {
-                /* The first two bytes of every read packet are status */
-                if (urb->actual_length > 2)
-                        usb_serial_debug_data(debug, &port->dev, __func__,
-                                                urb->actual_length, data);
-                else
-                        dbg("Status only: %03oo %03oo", data[0], data[1]);
+        for (i = 0; i < urb->actual_length; i += priv->max_packet_size) {
+                len = min_t(int, urb->actual_length - i, priv->max_packet_size);
+                count += ftdi_process_packet(tty, port, priv, &data[i], len);
         }
 
-
-        /* TO DO -- check for hung up line and handle appropriately: */
-        /*   send hangup  */
-        /* See acm.c - you do a tty_hangup  - eg tty_hangup(tty) */
-        /* if CD is dropped and the line is not CLOCAL then we should hangup */
-
-        need_flip = 0;
-        for (packet_offset = priv->rx_processed;
-                packet_offset < urb->actual_length; packet_offset += priv->max_packet_size) {
-                int length;
-
-                /* Compare new line status to the old one, signal if different/
-                   N.B. packet may be processed more than once, but differences
-                   are only processed once.  */
-                char new_status = data[packet_offset + 0] &
-                                                FTDI_STATUS_B0_MASK;
-                if (new_status != priv->prev_status) {
-                        priv->diff_status |=
-                                new_status ^ priv->prev_status;
-                        wake_up_interruptible(&priv->delta_msr_wait);
-                        priv->prev_status = new_status;
-                }
-
-                length = min_t(u32, priv->max_packet_size, urb->actual_length-packet_offset)-2;
-                if (length < 0) {
-                        dev_err(&port->dev, "%s - bad packet length: %d\n",
-                                __func__, length+2);
-                        length = 0;
-                }
-
-                if (priv->rx_flags & THROTTLED) {
-                        dbg("%s - throttled", __func__);
-                        break;
-                }
-                if (tty_buffer_request_room(tty, length) < length) {
-                        /* break out & wait for throttling/unthrottling to
-                           happen */
-                        dbg("%s - receive room low", __func__);
-                        break;
-                }
-
-                /* Handle errors and break */
-                error_flag = TTY_NORMAL;
-                /* Although the device uses a bitmask and hence can have
-                   multiple errors on a packet - the order here sets the
-                   priority the error is returned to the tty layer  */
-
-                if (data[packet_offset+1] & FTDI_RS_OE) {
-                        error_flag = TTY_OVERRUN;
-                        dbg("OVERRRUN error");
-                }
-                if (data[packet_offset+1] & FTDI_RS_BI) {
-                        error_flag = TTY_BREAK;
-                        dbg("BREAK received");
-                        usb_serial_handle_break(port);
-                }
-                if (data[packet_offset+1] & FTDI_RS_PE) {
-                        error_flag = TTY_PARITY;
-                        dbg("PARITY error");
-                }
-                if (data[packet_offset+1] & FTDI_RS_FE) {
-                        error_flag = TTY_FRAME;
-                        dbg("FRAMING error");
-                }
-                if (length > 0) {
-                        for (i = 2; i < length+2; i++) {
-                                /* Note that the error flag is duplicated for
-                                   every character received since we don't know
-                                   which character it applied to */
-                                if (!usb_serial_handle_sysrq_char(tty, port,
-                                                data[packet_offset + i]))
-                                        tty_insert_flip_char(tty,
-                                                data[packet_offset + i],
-                                                error_flag);
-                        }
-                        need_flip = 1;
-                }
-
-#ifdef NOT_CORRECT_BUT_KEEPING_IT_FOR_NOW
-                /* if a parity error is detected you get status packets forever
-                   until a character is sent without a parity error.
-                   This doesn't work well since the application receives a
-                   never ending stream of bad data - even though new data
-                   hasn't been sent. Therefore I (bill) have taken this out.
-                   However - this might make sense for framing errors and so on
-                   so I am leaving the code in for now.
-                */
-                else {
-                        if (error_flag != TTY_NORMAL) {
-                                dbg("error_flag is not normal");
-                                /* In this case it is just status - if that is
-                                   an error send a bad character */
-                                if (tty->flip.count >= TTY_FLIPBUF_SIZE)
-                                        tty_flip_buffer_push(tty);
-                                tty_insert_flip_char(tty, 0xff, error_flag);
-                                need_flip = 1;
-                        }
-                }
-#endif
-        } /* "for(packet_offset=0..." */
-
-        /* Low latency */
-        if (need_flip)
+        if (count)
                 tty_flip_buffer_push(tty);
+        tty_kref_put(tty);
+}
 
-        if (packet_offset < urb->actual_length) {
-                /* not completely processed - record progress */
-                priv->rx_processed = packet_offset;
-                dbg("%s - incomplete, %d bytes processed, %d remain",
-                                __func__, packet_offset,
-                                urb->actual_length - packet_offset);
-                /* check if we were throttled while processing */
-                spin_lock_irqsave(&priv->rx_lock, flags);
-                if (priv->rx_flags & THROTTLED) {
-                        priv->rx_flags |= ACTUALLY_THROTTLED;
-                        spin_unlock_irqrestore(&priv->rx_lock, flags);
-                        dbg("%s - deferring remainder until unthrottled",
-                                        __func__);
-                        goto out;
-                }
-                spin_unlock_irqrestore(&priv->rx_lock, flags);
-                /* if the port is closed stop trying to read */
-                if (port->port.count > 0)
-                        /* delay processing of remainder */
-                        schedule_delayed_work(&priv->rx_work, 1);
-                else
-                        dbg("%s - port is closed", __func__);
-                goto out;
-        }
-
-        /* urb is completely processed */
-        priv->rx_processed = 0;
+static void ftdi_read_bulk_callback(struct urb *urb)
+{
+        struct usb_serial_port *port = urb->context;
+        unsigned long flags;
 
-        /* if the port is closed stop trying to read */
-        if (port->port.count > 0) {
-                /* Continue trying to always read  */
-                usb_fill_bulk_urb(port->read_urb, port->serial->dev,
-                        usb_rcvbulkpipe(port->serial->dev,
-                                        port->bulk_in_endpointAddress),
-                        port->read_urb->transfer_buffer,
-                        port->read_urb->transfer_buffer_length,
-                        ftdi_read_bulk_callback, port);
+        dbg("%s - port %d", __func__, port->number);
 
-                result = usb_submit_urb(port->read_urb, GFP_ATOMIC);
-                if (result)
-                        dev_err(&port->dev,
-                                "%s - failed resubmitting read urb, error %d\n",
-                                __func__, result);
+        if (urb->status) {
+                dbg("%s - nonzero read bulk status received: %d",
+                                                __func__, urb->status);
+                return;
         }
-out:
-        tty_kref_put(tty);
-} /* ftdi_process_read */
 
+        usb_serial_debug_data(debug, &port->dev, __func__,
+                                urb->actual_length, urb->transfer_buffer);
+        ftdi_process_read(port);
+
+        spin_lock_irqsave(&port->lock, flags);
+        port->throttled = port->throttle_req;
+        if (!port->throttled) {
+                spin_unlock_irqrestore(&port->lock, flags);
+                ftdi_submit_read_urb(port, GFP_ATOMIC);
+        } else
+                spin_unlock_irqrestore(&port->lock, flags);
+}
 
 static void ftdi_break_ctl(struct tty_struct *tty, int break_state)
 {
@@ -2609,33 +2447,31 @@ static int ftdi_ioctl(struct tty_struct *tty, struct file *file,
 static void ftdi_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
-        struct ftdi_private *priv = usb_get_serial_port_data(port);
         unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->rx_lock, flags);
-        priv->rx_flags |= THROTTLED;
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
+        spin_lock_irqsave(&port->lock, flags);
+        port->throttle_req = 1;
+        spin_unlock_irqrestore(&port->lock, flags);
 }
 
-
-static void ftdi_unthrottle(struct tty_struct *tty)
+void ftdi_unthrottle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
-        struct ftdi_private *priv = usb_get_serial_port_data(port);
-        int actually_throttled;
+        int was_throttled;
         unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->rx_lock, flags);
-        actually_throttled = priv->rx_flags & ACTUALLY_THROTTLED;
-        priv->rx_flags &= ~(THROTTLED | ACTUALLY_THROTTLED);
-        spin_unlock_irqrestore(&priv->rx_lock, flags);
+        spin_lock_irqsave(&port->lock, flags);
+        was_throttled = port->throttled;
+        port->throttled = port->throttle_req = 0;
+        spin_unlock_irqrestore(&port->lock, flags);
 
-        if (actually_throttled)
-                schedule_delayed_work(&priv->rx_work, 0);
+        /* Resubmit urb if throttled and open. */
+        if (was_throttled && test_bit(ASYNCB_INITIALIZED, &port->port.flags))
+                ftdi_submit_read_urb(port, GFP_KERNEL);
 }
 
 static int __init ftdi_init(void)
diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c
index 20432d345529..5ac900e5a50e 100644
--- a/drivers/usb/serial/garmin_gps.c
+++ b/drivers/usb/serial/garmin_gps.c
@@ -1390,14 +1390,13 @@ static void garmin_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
         /* set flag, data received will be put into a queue
            for later processing */
-        spin_lock_irqsave(&garmin_data_p->lock, flags);
+        spin_lock_irq(&garmin_data_p->lock);
         garmin_data_p->flags |= FLAGS_QUEUING|FLAGS_THROTTLED;
-        spin_unlock_irqrestore(&garmin_data_p->lock, flags);
+        spin_unlock_irq(&garmin_data_p->lock);
 }
 
 
@@ -1405,13 +1404,12 @@ static void garmin_unthrottle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct garmin_data *garmin_data_p = usb_get_serial_port_data(port);
-        unsigned long flags;
         int status;
 
         dbg("%s - port %d", __func__, port->number);
-        spin_lock_irqsave(&garmin_data_p->lock, flags);
+        spin_lock_irq(&garmin_data_p->lock);
         garmin_data_p->flags &= ~FLAGS_THROTTLED;
-        spin_unlock_irqrestore(&garmin_data_p->lock, flags);
+        spin_unlock_irq(&garmin_data_p->lock);
 
         /* in native mode send queued data to tty, in
            serial mode nothing needs to be done here */
@@ -1419,7 +1417,7 @@ static void garmin_unthrottle(struct tty_struct *tty)
                 garmin_flush_queue(garmin_data_p);
 
         if (0 != (garmin_data_p->flags & FLAGS_BULK_IN_ACTIVE)) {
-                status = usb_submit_urb(port->read_urb, GFP_ATOMIC);
+                status = usb_submit_urb(port->read_urb, GFP_KERNEL);
                 if (status)
                         dev_err(&port->dev,
                                 "%s - failed resubmitting read urb, error %d\n",
diff --git a/drivers/usb/serial/generic.c b/drivers/usb/serial/generic.c
index deba08c7a015..bbe005cefcfb 100644
--- a/drivers/usb/serial/generic.c
+++ b/drivers/usb/serial/generic.c
@@ -546,7 +546,7 @@ void usb_serial_generic_unthrottle(struct tty_struct *tty)
 
         if (was_throttled) {
                 /* Resume reading from device */
-                usb_serial_generic_resubmit_read_urb(port, GFP_KERNEL);
+                flush_and_resubmit_read_urb(port);
         }
 }
 
diff --git a/drivers/usb/serial/ipaq.c b/drivers/usb/serial/ipaq.c
index 24fcc64b837d..d6231c38813e 100644
--- a/drivers/usb/serial/ipaq.c
+++ b/drivers/usb/serial/ipaq.c
@@ -966,6 +966,15 @@ static int ipaq_calc_num_ports(struct usb_serial *serial)
 static int ipaq_startup(struct usb_serial *serial)
 {
         dbg("%s", __func__);
+
+        /* Some of the devices in ipaq_id_table[] are composite, and we
+         * shouldn't bind to all the interfaces.  This test will rule out
+         * some obviously invalid possibilities.
+         */
+        if (serial->num_bulk_in < serial->num_ports ||
+                        serial->num_bulk_out < serial->num_ports)
+                return -ENODEV;
+
         if (serial->dev->actconfig->desc.bConfigurationValue != 1) {
                 /*
                  * FIXME: HP iPaq rx3715, possibly others, have 1 config that
diff --git a/drivers/usb/serial/keyspan_pda.c b/drivers/usb/serial/keyspan_pda.c
index 257c16cc6b2a..1296a097f5c3 100644
--- a/drivers/usb/serial/keyspan_pda.c
+++ b/drivers/usb/serial/keyspan_pda.c
@@ -290,7 +290,7 @@ static void keyspan_pda_rx_unthrottle(struct tty_struct *tty)
         /* just restart the receive interrupt URB */
         dbg("keyspan_pda_rx_unthrottle port %d", port->number);
         port->interrupt_in_urb->dev = port->serial->dev;
-        if (usb_submit_urb(port->interrupt_in_urb, GFP_ATOMIC))
+        if (usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL))
                 dbg(" usb_submit_urb(read urb) failed");
         return;
 }
diff --git a/drivers/usb/serial/kl5kusb105.c b/drivers/usb/serial/kl5kusb105.c
index f7373371b137..3a7873806f46 100644
--- a/drivers/usb/serial/kl5kusb105.c
+++ b/drivers/usb/serial/kl5kusb105.c
@@ -951,7 +951,7 @@ static void klsi_105_unthrottle(struct tty_struct *tty)
         dbg("%s - port %d", __func__, port->number);
 
         port->read_urb->dev = port->serial->dev;
-        result = usb_submit_urb(port->read_urb, GFP_ATOMIC);
+        result = usb_submit_urb(port->read_urb, GFP_KERNEL);
         if (result)
                 dev_err(&port->dev,
                         "%s - failed submitting read urb, error %d\n",
diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index ad4998bbf16f..cd009cb280a5 100644
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -777,20 +777,19 @@ static void mct_u232_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct mct_u232_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
         unsigned int control_state;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->rx_flags |= THROTTLED;
         if (C_CRTSCTS(tty)) {
                 priv->control_state &= ~TIOCM_RTS;
                 control_state = priv->control_state;
-                spin_unlock_irqrestore(&priv->lock, flags);
+                spin_unlock_irq(&priv->lock);
                 (void) mct_u232_set_modem_ctrl(port->serial, control_state);
         } else {
-                spin_unlock_irqrestore(&priv->lock, flags);
+                spin_unlock_irq(&priv->lock);
         }
 }
 
@@ -799,20 +798,19 @@ static void mct_u232_unthrottle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct mct_u232_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
         unsigned int control_state;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         if ((priv->rx_flags & THROTTLED) && C_CRTSCTS(tty)) {
                 priv->rx_flags &= ~THROTTLED;
                 priv->control_state |= TIOCM_RTS;
                 control_state = priv->control_state;
-                spin_unlock_irqrestore(&priv->lock, flags);
+                spin_unlock_irq(&priv->lock);
                 (void) mct_u232_set_modem_ctrl(port->serial, control_state);
         } else {
-                spin_unlock_irqrestore(&priv->lock, flags);
+                spin_unlock_irq(&priv->lock);
         }
 }
 
diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
index 1085a577c5c1..80f59b6350cb 100644
--- a/drivers/usb/serial/opticon.c
+++ b/drivers/usb/serial/opticon.c
@@ -314,21 +314,24 @@ static void opticon_unthrottle(struct tty_struct *tty)
         struct usb_serial_port *port = tty->driver_data;
         struct opticon_private *priv = usb_get_serial_data(port->serial);
         unsigned long flags;
-        int result;
+        int result, was_throttled;
 
         dbg("%s - port %d", __func__, port->number);
 
         spin_lock_irqsave(&priv->lock, flags);
         priv->throttled = false;
+        was_throttled = priv->actually_throttled;
         priv->actually_throttled = false;
         spin_unlock_irqrestore(&priv->lock, flags);
 
         priv->bulk_read_urb->dev = port->serial->dev;
-        result = usb_submit_urb(priv->bulk_read_urb, GFP_ATOMIC);
-        if (result)
-                dev_err(&port->dev,
-                        "%s - failed submitting read urb, error %d\n",
+        if (was_throttled) {
+                result = usb_submit_urb(priv->bulk_read_urb, GFP_ATOMIC);
+                if (result)
+                        dev_err(&port->dev,
+                                "%s - failed submitting read urb, error %d\n",
                                                         __func__, result);
+        }
 }
 
 static int opticon_tiocmget(struct tty_struct *tty, struct file *file)
diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
index f66e39883218..43c227027560 100644
--- a/drivers/usb/serial/option.c
+++ b/drivers/usb/serial/option.c
@@ -165,6 +165,7 @@ static int  option_resume(struct usb_serial *serial);
 #define HUAWEI_PRODUCT_E143D                    0x143D
 #define HUAWEI_PRODUCT_E143E                    0x143E
 #define HUAWEI_PRODUCT_E143F                    0x143F
+#define HUAWEI_PRODUCT_E14AC                    0x14AC
 
 #define QUANTA_VENDOR_ID                        0x0408
 #define QUANTA_PRODUCT_Q101                     0xEA02
@@ -318,6 +319,7 @@ static int  option_resume(struct usb_serial *serial);
 /* TOSHIBA PRODUCTS */
 #define TOSHIBA_VENDOR_ID                       0x0930
 #define TOSHIBA_PRODUCT_HSDPA_MINICARD          0x1302
+#define TOSHIBA_PRODUCT_G450                    0x0d45
 
 #define ALINK_VENDOR_ID                         0x1e0e
 #define ALINK_PRODUCT_3GU                       0x9200
@@ -424,6 +426,7 @@ static struct usb_device_id option_ids[] = {
         { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E143D, 0xff, 0xff, 0xff) },
         { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E143E, 0xff, 0xff, 0xff) },
         { USB_DEVICE_AND_INTERFACE_INFO(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E143F, 0xff, 0xff, 0xff) },
+        { USB_DEVICE(HUAWEI_VENDOR_ID, HUAWEI_PRODUCT_E14AC) },
         { USB_DEVICE(AMOI_VENDOR_ID, AMOI_PRODUCT_9508) },
         { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V640) }, /* Novatel Merlin V640/XV620 */
         { USB_DEVICE(NOVATELWIRELESS_VENDOR_ID, NOVATELWIRELESS_PRODUCT_V620) }, /* Novatel Merlin V620/S620 */
@@ -581,6 +584,7 @@ static struct usb_device_id option_ids[] = {
         { USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H21_4523) },
         { USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H20_4515) },
         { USB_DEVICE(QISDA_VENDOR_ID, QISDA_PRODUCT_H20_4519) },
+        { USB_DEVICE(TOSHIBA_VENDOR_ID, TOSHIBA_PRODUCT_G450) },
         { USB_DEVICE(TOSHIBA_VENDOR_ID, TOSHIBA_PRODUCT_HSDPA_MINICARD ) }, /* Toshiba 3G HSDPA == Novatel Expedite EU870D MiniCard */
         { USB_DEVICE(ALINK_VENDOR_ID, 0x9000) },
         { USB_DEVICE_AND_INTERFACE_INFO(ALINK_VENDOR_ID, ALINK_PRODUCT_3GU, 0xff, 0xff, 0xff) },
diff --git a/drivers/usb/serial/oti6858.c b/drivers/usb/serial/oti6858.c
index 0f4a70ce3823..c644e26394b4 100644
--- a/drivers/usb/serial/oti6858.c
+++ b/drivers/usb/serial/oti6858.c
@@ -288,7 +288,7 @@ static void setup_line(struct work_struct *work)
 
         dbg("%s(): submitting interrupt urb", __func__);
         port->interrupt_in_urb->dev = port->serial->dev;
-        result = usb_submit_urb(port->interrupt_in_urb, GFP_ATOMIC);
+        result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
         if (result != 0) {
                 dev_err(&port->dev, "%s(): usb_submit_urb() failed"
                                 " with error %d\n", __func__, result);
@@ -335,7 +335,7 @@ void send_data(struct work_struct *work)
 
                 dbg("%s(): submitting interrupt urb", __func__);
                 port->interrupt_in_urb->dev = port->serial->dev;
-                result = usb_submit_urb(port->interrupt_in_urb, GFP_ATOMIC);
+                result = usb_submit_urb(port->interrupt_in_urb, GFP_NOIO);
                 if (result != 0) {
                         dev_err(&port->dev, "%s(): usb_submit_urb() failed"
                                 " with error %d\n", __func__, result);
@@ -349,7 +349,7 @@ void send_data(struct work_struct *work)
 
         port->write_urb->transfer_buffer_length = count;
         port->write_urb->dev = port->serial->dev;
-        result = usb_submit_urb(port->write_urb, GFP_ATOMIC);
+        result = usb_submit_urb(port->write_urb, GFP_NOIO);
         if (result != 0) {
                 dev_err(&port->dev, "%s(): usb_submit_urb() failed"
                                " with error %d\n", __func__, result);
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index 1128e01525b1..9ec1a49e2362 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -1046,13 +1046,15 @@ static void pl2303_push_data(struct tty_struct *tty,
         /* overrun is special, not associated with a char */
         if (line_status & UART_OVERRUN_ERROR)
                 tty_insert_flip_char(tty, 0, TTY_OVERRUN);
-        if (port->console && port->sysrq) {
+
+        if (tty_flag == TTY_NORMAL && !(port->console && port->sysrq))
+                tty_insert_flip_string(tty, data, urb->actual_length);
+        else {
                 int i;
                 for (i = 0; i < urb->actual_length; ++i)
                         if (!usb_serial_handle_sysrq_char(tty, port, data[i]))
                                 tty_insert_flip_char(tty, data[i], tty_flag);
-        } else
-                tty_insert_flip_string(tty, data, urb->actual_length);
+        }
         tty_flip_buffer_push(tty);
 }
 
diff --git a/drivers/usb/serial/sierra.c b/drivers/usb/serial/sierra.c
index 8c075b2416bb..45883988a005 100644
--- a/drivers/usb/serial/sierra.c
+++ b/drivers/usb/serial/sierra.c
@@ -17,7 +17,7 @@
   Whom based his on the Keyspan driver by Hugh Blemings <hugh@blemings.org>
 */
 
-#define DRIVER_VERSION "v.1.3.7"
+#define DRIVER_VERSION "v.1.3.8"
 #define DRIVER_AUTHOR "Kevin Lloyd, Elina Pasheva, Matthew Safar, Rory Filer"
 #define DRIVER_DESC "USB Driver for Sierra Wireless USB modems"
 
diff --git a/drivers/usb/serial/symbolserial.c b/drivers/usb/serial/symbolserial.c
index cb7e95f9fcbf..b282c0f2d8e5 100644
--- a/drivers/usb/serial/symbolserial.c
+++ b/drivers/usb/serial/symbolserial.c
@@ -165,34 +165,36 @@ static void symbol_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct symbol_private *priv = usb_get_serial_data(port->serial);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->throttled = true;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 }
 
 static void symbol_unthrottle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct symbol_private *priv = usb_get_serial_data(port->serial);
-        unsigned long flags;
         int result;
+        bool was_throttled;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->throttled = false;
+        was_throttled = priv->actually_throttled;
         priv->actually_throttled = false;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 
         priv->int_urb->dev = port->serial->dev;
-        result = usb_submit_urb(priv->int_urb, GFP_ATOMIC);
-        if (result)
-                dev_err(&port->dev,
-                        "%s - failed submitting read urb, error %d\n",
+        if (was_throttled) {
+                result = usb_submit_urb(priv->int_urb, GFP_KERNEL);
+                if (result)
+                        dev_err(&port->dev,
+                                "%s - failed submitting read urb, error %d\n",
                                                         __func__, result);
+        }
 }
 
 static int symbol_startup(struct usb_serial *serial)
diff --git a/drivers/usb/serial/usb-serial.c b/drivers/usb/serial/usb-serial.c
index aa6b2ae951ae..bd3fa7ff15b1 100644
--- a/drivers/usb/serial/usb-serial.c
+++ b/drivers/usb/serial/usb-serial.c
@@ -156,7 +156,8 @@ static void destroy_serial(struct kref *kref)
         if (serial->minor != SERIAL_TTY_NO_MINOR)
                 return_serial(serial);
 
-        serial->type->release(serial);
+        if (serial->attached)
+                serial->type->release(serial);
 
         /* Now that nothing is using the ports, they can be freed */
         for (i = 0; i < serial->num_port_pointers; ++i) {
@@ -1059,12 +1060,15 @@ int usb_serial_probe(struct usb_interface *interface,
                 module_put(type->driver.owner);
                 if (retval < 0)
                         goto probe_error;
+                serial->attached = 1;
                 if (retval > 0) {
                         /* quietly accept this device, but don't bind to a
                            serial port as it's about to disappear */
                         serial->num_ports = 0;
                         goto exit;
                 }
+        } else {
+                serial->attached = 1;
         }
 
         if (get_free_serial(serial, num_ports, &minor) == NULL) {
@@ -1164,8 +1168,10 @@ int usb_serial_suspend(struct usb_interface *intf, pm_message_t message)
 
         if (serial->type->suspend) {
                 r = serial->type->suspend(serial, message);
-                if (r < 0)
+                if (r < 0) {
+                        serial->suspending = 0;
                         goto err_out;
+                }
         }
 
         for (i = 0; i < serial->num_ports; ++i) {
diff --git a/drivers/usb/serial/visor.c b/drivers/usb/serial/visor.c
index 1aa5d20a5d99..ad1f9232292d 100644
--- a/drivers/usb/serial/visor.c
+++ b/drivers/usb/serial/visor.c
@@ -513,7 +513,8 @@ static void visor_read_bulk_callback(struct urb *urb)
                         tty_kref_put(tty);
                 }
                 spin_lock(&priv->lock);
-                priv->bytes_in += available_room;
+                if (tty)
+                        priv->bytes_in += available_room;
 
         } else {
                 spin_lock(&priv->lock);
@@ -582,12 +583,11 @@ static void visor_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct visor_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->throttled = 1;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 }
 
 
@@ -595,21 +595,23 @@ static void visor_unthrottle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct visor_private *priv = usb_get_serial_port_data(port);
-        unsigned long flags;
-        int result;
+        int result, was_throttled;
 
         dbg("%s - port %d", __func__, port->number);
-        spin_lock_irqsave(&priv->lock, flags);
+        spin_lock_irq(&priv->lock);
         priv->throttled = 0;
+        was_throttled = priv->actually_throttled;
         priv->actually_throttled = 0;
-        spin_unlock_irqrestore(&priv->lock, flags);
+        spin_unlock_irq(&priv->lock);
 
-        port->read_urb->dev = port->serial->dev;
-        result = usb_submit_urb(port->read_urb, GFP_ATOMIC);
-        if (result)
-                dev_err(&port->dev,
-                        "%s - failed submitting read urb, error %d\n",
+        if (was_throttled) {
+                port->read_urb->dev = port->serial->dev;
+                result = usb_submit_urb(port->read_urb, GFP_KERNEL);
+                if (result)
+                        dev_err(&port->dev,
+                                "%s - failed submitting read urb, error %d\n",
                                                         __func__, result);
+        }
 }
 
 static int palm_os_3_probe(struct usb_serial *serial,
diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c
index 62424eec33ec..1093d2eb046a 100644
--- a/drivers/usb/serial/whiteheat.c
+++ b/drivers/usb/serial/whiteheat.c
@@ -949,13 +949,12 @@ static void whiteheat_throttle(struct tty_struct *tty)
 {
         struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&info->lock, flags);
+        spin_lock_irq(&info->lock);
         info->flags |= THROTTLED;
-        spin_unlock_irqrestore(&info->lock, flags);
+        spin_unlock_irq(&info->lock);
 
         return;
 }
@@ -966,14 +965,13 @@ static void whiteheat_unthrottle(struct tty_struct *tty)
         struct usb_serial_port *port = tty->driver_data;
         struct whiteheat_private *info = usb_get_serial_port_data(port);
         int actually_throttled;
-        unsigned long flags;
 
         dbg("%s - port %d", __func__, port->number);
 
-        spin_lock_irqsave(&info->lock, flags);
+        spin_lock_irq(&info->lock);
         actually_throttled = info->flags & ACTUALLY_THROTTLED;
         info->flags &= ~(THROTTLED | ACTUALLY_THROTTLED);
-        spin_unlock_irqrestore(&info->lock, flags);
+        spin_unlock_irq(&info->lock);
 
         if (actually_throttled)
                 rx_data_softint(&info->rx_work);