6 files changed, 31 insertions, 47 deletions

diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index 137166d73945..31721eadc597 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -1653,7 +1653,7 @@ static int vidioc_streamoff(struct file *file, void *priv,
                                 enum v4l2_buf_type buf_type)
 {
         struct gspca_dev *gspca_dev = video_drvdata(file);
-        int ret;
+        int i, ret;
 
         if (buf_type != V4L2_BUF_TYPE_VIDEO_CAPTURE)
                 return -EINVAL;
@@ -1678,6 +1678,8 @@ static int vidioc_streamoff(struct file *file, void *priv,
         wake_up_interruptible(&gspca_dev->wq);
 
         /* empty the transfer queues */
+        for (i = 0; i < gspca_dev->nframes; i++)
+                gspca_dev->frame[i].v4l2_buf.flags &= ~BUF_ALL_FLAGS;
         atomic_set(&gspca_dev->fr_q, 0);
         atomic_set(&gspca_dev->fr_i, 0);
         gspca_dev->fr_o = 0;
diff --git a/drivers/media/video/gspca/ov534.c b/drivers/media/video/gspca/ov534.c
index b5acb1e4b4e7..80c81dd6d68b 100644
--- a/drivers/media/video/gspca/ov534.c
+++ b/drivers/media/video/gspca/ov534.c
@@ -96,7 +96,7 @@ static void setbrightness(struct gspca_dev *gspca_dev);
 static void setcontrast(struct gspca_dev *gspca_dev);
 static void setgain(struct gspca_dev *gspca_dev);
 static void setexposure(struct gspca_dev *gspca_dev);
-static int sd_setagc(struct gspca_dev *gspca_dev, __s32 val);
+static void setagc(struct gspca_dev *gspca_dev);
 static void setawb(struct gspca_dev *gspca_dev);
 static void setaec(struct gspca_dev *gspca_dev);
 static void setsharpness(struct gspca_dev *gspca_dev);
@@ -189,7 +189,7 @@ static const struct ctrl sd_ctrls[] = {
                         .step    = 1,
                         .default_value = 1,
                 },
-                .set = sd_setagc
+                .set_control = setagc
         },
 [AWB] = {
                 {
@@ -851,6 +851,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
         int i;
 
         for (i = 0; i < 5; i++) {
+                msleep(10);
                 data = ov534_reg_read(gspca_dev, OV534_REG_STATUS);
 
                 switch (data) {
@@ -1242,10 +1243,6 @@ static int sd_config(struct gspca_dev *gspca_dev,
 
         cam->ctrls = sd->ctrls;
 
-        /* the auto white balance control works only when auto gain is set */
-        if (sd_ctrls[AGC].qctrl.default_value == 0)
-                gspca_dev->ctrl_inac |= (1 << AWB);
-
         cam->cam_mode = ov772x_mode;
         cam->nmodes = ARRAY_SIZE(ov772x_mode);
 
@@ -1486,29 +1483,6 @@ scan_next:
         } while (remaining_len > 0);
 }
 
-static int sd_setagc(struct gspca_dev *gspca_dev, __s32 val)
-{
-        struct sd *sd = (struct sd *) gspca_dev;
-
-        sd->ctrls[AGC].val = val;
-
-        /* the auto white balance control works only
-         * when auto gain is set */
-        if (val) {
-                gspca_dev->ctrl_inac &= ~(1 << AWB);
-        } else {
-                gspca_dev->ctrl_inac |= (1 << AWB);
-                if (sd->ctrls[AWB].val) {
-                        sd->ctrls[AWB].val = 0;
-                        if (gspca_dev->streaming)
-                                setawb(gspca_dev);
-                }
-        }
-        if (gspca_dev->streaming)
-                setagc(gspca_dev);
-        return gspca_dev->usb_err;
-}
-
 static int sd_querymenu(struct gspca_dev *gspca_dev,
                 struct v4l2_querymenu *menu)
 {
diff --git a/drivers/media/video/gspca/ov534_9.c b/drivers/media/video/gspca/ov534_9.c
index b5797308a39b..1fd41f0d2e95 100644
--- a/drivers/media/video/gspca/ov534_9.c
+++ b/drivers/media/video/gspca/ov534_9.c
@@ -1008,6 +1008,7 @@ static int sccb_check_status(struct gspca_dev *gspca_dev)
         int i;
 
         for (i = 0; i < 5; i++) {
+                msleep(10);
                 data = reg_r(gspca_dev, OV534_REG_STATUS);
 
                 switch (data) {
diff --git a/drivers/media/video/gspca/pac7311.c b/drivers/media/video/gspca/pac7311.c
index 2cb7d95f7be7..115da169f32a 100644
--- a/drivers/media/video/gspca/pac7311.c
+++ b/drivers/media/video/gspca/pac7311.c
@@ -418,7 +418,7 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
         struct v4l2_ctrl_handler *hdl = &gspca_dev->ctrl_handler;
 
         gspca_dev->vdev.ctrl_handler = hdl;
-        v4l2_ctrl_handler_init(hdl, 4);
+        v4l2_ctrl_handler_init(hdl, 5);
 
         sd->contrast = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                                         V4L2_CID_CONTRAST, 0, 15, 1, 7);
diff --git a/drivers/media/video/gspca/sn9c20x.c b/drivers/media/video/gspca/sn9c20x.c
index ad098202d7f0..b9c6f17eabb2 100644
--- a/drivers/media/video/gspca/sn9c20x.c
+++ b/drivers/media/video/gspca/sn9c20x.c
@@ -1761,7 +1761,6 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
                         V4L2_CID_SATURATION, 0, 255, 1, 127);
         sd->hue = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                         V4L2_CID_HUE, -180, 180, 1, 0);
-        v4l2_ctrl_cluster(4, &sd->brightness);
 
         sd->gamma = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                         V4L2_CID_GAMMA, 0, 255, 1, 0x10);
@@ -1770,7 +1769,6 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
                         V4L2_CID_BLUE_BALANCE, 0, 127, 1, 0x28);
         sd->red = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                         V4L2_CID_RED_BALANCE, 0, 127, 1, 0x28);
-        v4l2_ctrl_cluster(2, &sd->blue);
 
         if (sd->sensor != SENSOR_OV9655 && sd->sensor != SENSOR_SOI968 &&
             sd->sensor != SENSOR_OV7670 && sd->sensor != SENSOR_MT9M001 &&
@@ -1779,7 +1777,6 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
                         V4L2_CID_HFLIP, 0, 1, 1, 0);
                 sd->vflip = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                         V4L2_CID_VFLIP, 0, 1, 1, 0);
-                v4l2_ctrl_cluster(2, &sd->hflip);
         }
 
         if (sd->sensor != SENSOR_SOI968 && sd->sensor != SENSOR_MT9VPRB &&
@@ -1794,6 +1791,20 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
                         V4L2_CID_GAIN, 0, 28, 1, 0);
                 sd->autogain = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
                         V4L2_CID_AUTOGAIN, 0, 1, 1, 1);
+        }
+
+        sd->jpegqual = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
+                        V4L2_CID_JPEG_COMPRESSION_QUALITY, 50, 90, 1, 80);
+        if (hdl->error) {
+                pr_err("Could not initialize controls\n");
+                return hdl->error;
+        }
+
+        v4l2_ctrl_cluster(4, &sd->brightness);
+        v4l2_ctrl_cluster(2, &sd->blue);
+        if (sd->hflip)
+                v4l2_ctrl_cluster(2, &sd->hflip);
+        if (sd->autogain) {
                 if (sd->sensor == SENSOR_SOI968)
                         /* this sensor doesn't have the exposure control and
                            autogain is clustered with gain instead. This works
@@ -1803,13 +1814,6 @@ static int sd_init_controls(struct gspca_dev *gspca_dev)
                         /* Otherwise autogain is clustered with exposure. */
                         v4l2_ctrl_auto_cluster(2, &sd->autogain, 0, false);
         }
-
-        sd->jpegqual = v4l2_ctrl_new_std(hdl, &sd_ctrl_ops,
-                        V4L2_CID_JPEG_COMPRESSION_QUALITY, 50, 90, 1, 80);
-        if (hdl->error) {
-                pr_err("Could not initialize controls\n");
-                return hdl->error;
-        }
         return 0;
 }
 
@@ -2066,10 +2070,13 @@ static int sd_start(struct gspca_dev *gspca_dev)
         set_gamma(gspca_dev, v4l2_ctrl_g_ctrl(sd->gamma));
         set_redblue(gspca_dev, v4l2_ctrl_g_ctrl(sd->blue),
                         v4l2_ctrl_g_ctrl(sd->red));
-        set_gain(gspca_dev, v4l2_ctrl_g_ctrl(sd->gain));
-        set_exposure(gspca_dev, v4l2_ctrl_g_ctrl(sd->exposure));
-        set_hvflip(gspca_dev, v4l2_ctrl_g_ctrl(sd->hflip),
-                        v4l2_ctrl_g_ctrl(sd->vflip));
+        if (sd->gain)
+                set_gain(gspca_dev, v4l2_ctrl_g_ctrl(sd->gain));
+        if (sd->exposure)
+                set_exposure(gspca_dev, v4l2_ctrl_g_ctrl(sd->exposure));
+        if (sd->hflip)
+                set_hvflip(gspca_dev, v4l2_ctrl_g_ctrl(sd->hflip),
+                                v4l2_ctrl_g_ctrl(sd->vflip));
 
         reg_w1(gspca_dev, 0x1007, 0x20);
         reg_w1(gspca_dev, 0x1061, 0x03);
@@ -2172,7 +2179,7 @@ static void sd_dqcallback(struct gspca_dev *gspca_dev)
         struct sd *sd = (struct sd *) gspca_dev;
         int avg_lum;
 
-        if (!v4l2_ctrl_g_ctrl(sd->autogain))
+        if (sd->autogain == NULL || !v4l2_ctrl_g_ctrl(sd->autogain))
                 return;
 
         avg_lum = atomic_read(&sd->avg_lum);
diff --git a/drivers/media/video/gspca/sonixj.c b/drivers/media/video/gspca/sonixj.c
index 4d1696d1a7f4..f38faa9b37c3 100644
--- a/drivers/media/video/gspca/sonixj.c
+++ b/drivers/media/video/gspca/sonixj.c
@@ -3120,7 +3120,7 @@ static const struct sd_desc sd_desc = {
                         | (SENSOR_ ## sensor << 8) \
                         | (flags)
 static const struct usb_device_id device_table[] = {
-        {USB_DEVICE(0x0458, 0x7025), BS(SN9C120, MI0360)},
+        {USB_DEVICE(0x0458, 0x7025), BSF(SN9C120, MI0360B, F_PDN_INV)},
         {USB_DEVICE(0x0458, 0x702e), BS(SN9C120, OV7660)},
         {USB_DEVICE(0x045e, 0x00f5), BSF(SN9C105, OV7660, F_PDN_INV)},
         {USB_DEVICE(0x045e, 0x00f7), BSF(SN9C105, OV7660, F_PDN_INV)},