9 files changed, 40 insertions, 19 deletions

diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig
index 992137cf3a64..ac0500667000 100644
--- a/drivers/input/keyboard/Kconfig
+++ b/drivers/input/keyboard/Kconfig
@@ -409,7 +409,7 @@ config KEYBOARD_NEWTON
 
 config KEYBOARD_NOMADIK
         tristate "ST-Ericsson Nomadik SKE keyboard"
-        depends on PLAT_NOMADIK
+        depends on (ARCH_NOMADIK || ARCH_U8500)
         select INPUT_MATRIXKMAP
         help
           Say Y here if you want to use a keypad provided on the SKE controller
@@ -554,6 +554,7 @@ config KEYBOARD_OMAP
 
 config KEYBOARD_OMAP4
         tristate "TI OMAP4+ keypad support"
+        depends on ARCH_OMAP2PLUS
         select INPUT_MATRIXKMAP
         help
           Say Y here if you want to use the OMAP4+ keypad.
diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index d327f5a2bb0e..b29ca651a395 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -602,6 +602,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
 
         i = 0;
         for_each_child_of_node(node, pp) {
+                int gpio;
                 enum of_gpio_flags flags;
 
                 if (!of_find_property(pp, "gpios", NULL)) {
@@ -610,9 +611,19 @@ gpio_keys_get_devtree_pdata(struct device *dev)
                         continue;
                 }
 
+                gpio = of_get_gpio_flags(pp, 0, &flags);
+                if (gpio < 0) {
+                        error = gpio;
+                        if (error != -EPROBE_DEFER)
+                                dev_err(dev,
+                                        "Failed to get gpio flags, error: %d\n",
+                                        error);
+                        goto err_free_pdata;
+                }
+
                 button = &pdata->buttons[i++];
 
-                button->gpio = of_get_gpio_flags(pp, 0, &flags);
+                button->gpio = gpio;
                 button->active_low = flags & OF_GPIO_ACTIVE_LOW;
 
                 if (of_property_read_u32(pp, "linux,code", &button->code)) {
diff --git a/drivers/input/keyboard/gpio_keys_polled.c b/drivers/input/keyboard/gpio_keys_polled.c
index f686fd970553..21147164874d 100644
--- a/drivers/input/keyboard/gpio_keys_polled.c
+++ b/drivers/input/keyboard/gpio_keys_polled.c
@@ -135,6 +135,7 @@ static struct gpio_keys_platform_data *gpio_keys_polled_get_devtree_pdata(struct
 
         i = 0;
         for_each_child_of_node(node, pp) {
+                int gpio;
                 enum of_gpio_flags flags;
 
                 if (!of_find_property(pp, "gpios", NULL)) {
@@ -143,9 +144,19 @@ static struct gpio_keys_platform_data *gpio_keys_polled_get_devtree_pdata(struct
                         continue;
                 }
 
+                gpio = of_get_gpio_flags(pp, 0, &flags);
+                if (gpio < 0) {
+                        error = gpio;
+                        if (error != -EPROBE_DEFER)
+                                dev_err(dev,
+                                        "Failed to get gpio flags, error: %d\n",
+                                        error);
+                        goto err_free_pdata;
+                }
+
                 button = &pdata->buttons[i++];
 
-                button->gpio = of_get_gpio_flags(pp, 0, &flags);
+                button->gpio = gpio;
                 button->active_low = flags & OF_GPIO_ACTIVE_LOW;
 
                 if (of_property_read_u32(pp, "linux,code", &button->code)) {
diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c
index 93c812662134..0de23f41b2d3 100644
--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c
@@ -398,7 +398,7 @@ static irqreturn_t lm8323_irq(int irq, void *_lm)
                         lm8323_configure(lm);
                 }
                 for (i = 0; i < LM8323_NUM_PWMS; i++) {
-                        if (ints & (1 << (INT_PWM1 + i))) {
+                        if (ints & (INT_PWM1 << i)) {
                                 dev_vdbg(&lm->client->dev,
                                          "pwm%d engine completed\n", i);
                                 pwm_done(&lm->pwm[i]);
diff --git a/drivers/input/keyboard/matrix_keypad.c b/drivers/input/keyboard/matrix_keypad.c
index f4ff0dda7597..71d77192ac1e 100644
--- a/drivers/input/keyboard/matrix_keypad.c
+++ b/drivers/input/keyboard/matrix_keypad.c
@@ -403,7 +403,7 @@ matrix_keypad_parse_dt(struct device *dev)
         struct matrix_keypad_platform_data *pdata;
         struct device_node *np = dev->of_node;
         unsigned int *gpios;
-        int i;
+        int i, nrow, ncol;
 
         if (!np) {
                 dev_err(dev, "device lacks DT data\n");
@@ -416,9 +416,9 @@ matrix_keypad_parse_dt(struct device *dev)
                 return ERR_PTR(-ENOMEM);
         }
 
-        pdata->num_row_gpios = of_gpio_named_count(np, "row-gpios");
-        pdata->num_col_gpios = of_gpio_named_count(np, "col-gpios");
-        if (!pdata->num_row_gpios || !pdata->num_col_gpios) {
+        pdata->num_row_gpios = nrow = of_gpio_named_count(np, "row-gpios");
+        pdata->num_col_gpios = ncol = of_gpio_named_count(np, "col-gpios");
+        if (nrow <= 0 || ncol <= 0) {
                 dev_err(dev, "number of keypad rows/columns not specified\n");
                 return ERR_PTR(-EINVAL);
         }
diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
index 695d237417d6..cb1e8f614631 100644
--- a/drivers/input/keyboard/spear-keyboard.c
+++ b/drivers/input/keyboard/spear-keyboard.c
@@ -228,11 +228,9 @@ static int spear_kbd_probe(struct platform_device *pdev)
                 kbd->suspended_rate = pdata->suspended_rate;
         }
 
-        kbd->io_base = devm_request_and_ioremap(&pdev->dev, res);
-        if (!kbd->io_base) {
-                dev_err(&pdev->dev, "request-ioremap failed for kbd_region\n");
-                return -ENOMEM;
-        }
+        kbd->io_base = devm_ioremap_resource(&pdev->dev, res);
+        if (IS_ERR(kbd->io_base))
+                return PTR_ERR(kbd->io_base);
 
         kbd->clk = devm_clk_get(&pdev->dev, NULL);
         if (IS_ERR(kbd->clk))
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c
index 2fb0d76a04c4..208de7cbb7fa 100644
--- a/drivers/input/keyboard/tc3589x-keypad.c
+++ b/drivers/input/keyboard/tc3589x-keypad.c
@@ -70,8 +70,6 @@
 #define TC3589x_EVT_INT_CLR     0x2
 #define TC3589x_KBD_INT_CLR     0x1
 
-#define TC3589x_KBD_KEYMAP_SIZE     64
-
 /**
  * struct tc_keypad - data structure used by keypad driver
  * @tc3589x:    pointer to tc35893
@@ -88,7 +86,7 @@ struct tc_keypad {
         const struct tc3589x_keypad_platform_data *board;
         unsigned int krow;
         unsigned int kcol;
-        unsigned short keymap[TC3589x_KBD_KEYMAP_SIZE];
+        unsigned short *keymap;
         bool keypad_stopped;
 };
 
@@ -338,12 +336,14 @@ static int tc3589x_keypad_probe(struct platform_device *pdev)
 
         error = matrix_keypad_build_keymap(plat->keymap_data, NULL,
                                            TC3589x_MAX_KPROW, TC3589x_MAX_KPCOL,
-                                           keypad->keymap, input);
+                                           NULL, input);
         if (error) {
                 dev_err(&pdev->dev, "Failed to build keymap\n");
                 goto err_free_mem;
         }
 
+        keypad->keymap = input->keycode;
+
         input_set_capability(input, EV_MSC, MSC_SCAN);
         if (!plat->no_autorepeat)
                 __set_bit(EV_REP, input->evbit);
diff --git a/drivers/input/keyboard/tca8418_keypad.c b/drivers/input/keyboard/tca8418_keypad.c
index 50e9c5e195e1..a34cc6714e5b 100644
--- a/drivers/input/keyboard/tca8418_keypad.c
+++ b/drivers/input/keyboard/tca8418_keypad.c
@@ -384,7 +384,7 @@ static const struct i2c_device_id tca8418_id[] = {
 MODULE_DEVICE_TABLE(i2c, tca8418_id);
 
 #ifdef CONFIG_OF
-static const struct of_device_id tca8418_dt_ids[] __devinitconst = {
+static const struct of_device_id tca8418_dt_ids[] = {
         { .compatible = "ti,tca8418", },
         { }
 };
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index d89e7d392d1e..0e138ebcc768 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -30,7 +30,7 @@
 #include <linux/clk.h>
 #include <linux/slab.h>
 #include <linux/input/matrix_keypad.h>
-#include <mach/clk.h>
+#include <linux/clk/tegra.h>
 
 #define KBC_MAX_GPIO    24
 #define KBC_MAX_KPENT   8