aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--tools/perf/builtin-sched.c44
-rw-r--r--tools/perf/util/thread.c32
-rw-r--r--tools/perf/util/thread.h3
3 files changed, 67 insertions, 12 deletions
diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
index e1df7055ab82..25b91e784332 100644
--- a/tools/perf/builtin-sched.c
+++ b/tools/perf/builtin-sched.c
@@ -1034,6 +1034,36 @@ add_sched_in_event(struct work_atoms *atoms, u64 timestamp)
1034 atoms->nb_atoms++; 1034 atoms->nb_atoms++;
1035} 1035}
1036 1036
1037static struct thread *
1038threads__findnew_from_ctx(u32 pid, struct trace_switch_event *switch_event)
1039{
1040 struct thread *th;
1041
1042 th = threads__findnew_nocomm(pid, &threads, &last_match);
1043 if (th->comm)
1044 return th;
1045
1046 if (pid == switch_event->prev_pid)
1047 thread__set_comm(th, switch_event->prev_comm);
1048 else
1049 thread__set_comm(th, switch_event->next_comm);
1050 return th;
1051}
1052
1053static struct thread *
1054threads__findnew_from_wakeup(struct trace_wakeup_event *wakeup_event)
1055{
1056 struct thread *th;
1057
1058 th = threads__findnew_nocomm(wakeup_event->pid, &threads, &last_match);
1059 if (th->comm)
1060 return th;
1061
1062 thread__set_comm(th, wakeup_event->comm);
1063
1064 return th;
1065}
1066
1037static void 1067static void
1038latency_switch_event(struct trace_switch_event *switch_event, 1068latency_switch_event(struct trace_switch_event *switch_event,
1039 struct event *event __used, 1069 struct event *event __used,
@@ -1059,8 +1089,10 @@ latency_switch_event(struct trace_switch_event *switch_event,
1059 die("hm, delta: %Ld < 0 ?\n", delta); 1089 die("hm, delta: %Ld < 0 ?\n", delta);
1060 1090
1061 1091
1062 sched_out = threads__findnew(switch_event->prev_pid, &threads, &last_match); 1092 sched_out = threads__findnew_from_ctx(switch_event->prev_pid,
1063 sched_in = threads__findnew(switch_event->next_pid, &threads, &last_match); 1093 switch_event);
1094 sched_in = threads__findnew_from_ctx(switch_event->next_pid,
1095 switch_event);
1064 1096
1065 out_events = thread_atoms_search(&atom_root, sched_out, &cmp_pid); 1097 out_events = thread_atoms_search(&atom_root, sched_out, &cmp_pid);
1066 if (!out_events) { 1098 if (!out_events) {
@@ -1126,7 +1158,7 @@ latency_wakeup_event(struct trace_wakeup_event *wakeup_event,
1126 if (!wakeup_event->success) 1158 if (!wakeup_event->success)
1127 return; 1159 return;
1128 1160
1129 wakee = threads__findnew(wakeup_event->pid, &threads, &last_match); 1161 wakee = threads__findnew_from_wakeup(wakeup_event);
1130 atoms = thread_atoms_search(&atom_root, wakee, &cmp_pid); 1162 atoms = thread_atoms_search(&atom_root, wakee, &cmp_pid);
1131 if (!atoms) { 1163 if (!atoms) {
1132 thread_atoms_insert(wakee); 1164 thread_atoms_insert(wakee);
@@ -1386,8 +1418,10 @@ map_switch_event(struct trace_switch_event *switch_event,
1386 die("hm, delta: %Ld < 0 ?\n", delta); 1418 die("hm, delta: %Ld < 0 ?\n", delta);
1387 1419
1388 1420
1389 sched_out = threads__findnew(switch_event->prev_pid, &threads, &last_match); 1421 sched_out = threads__findnew_from_ctx(switch_event->prev_pid,
1390 sched_in = threads__findnew(switch_event->next_pid, &threads, &last_match); 1422 switch_event);
1423 sched_in = threads__findnew_from_ctx(switch_event->next_pid,
1424 switch_event);
1391 1425
1392 curr_thread[this_cpu] = sched_in; 1426 curr_thread[this_cpu] = sched_in;
1393 1427
diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
index 3b56aebb1f4b..8bd5ca2d2f28 100644
--- a/tools/perf/util/thread.c
+++ b/tools/perf/util/thread.c
@@ -6,15 +6,17 @@
6#include "util.h" 6#include "util.h"
7#include "debug.h" 7#include "debug.h"
8 8
9static struct thread *thread__new(pid_t pid) 9static struct thread *thread__new(pid_t pid, int set_comm)
10{ 10{
11 struct thread *self = calloc(1, sizeof(*self)); 11 struct thread *self = calloc(1, sizeof(*self));
12 12
13 if (self != NULL) { 13 if (self != NULL) {
14 self->pid = pid; 14 self->pid = pid;
15 self->comm = malloc(32); 15 if (set_comm) {
16 if (self->comm) 16 self->comm = malloc(32);
17 snprintf(self->comm, 32, ":%d", self->pid); 17 if (self->comm)
18 snprintf(self->comm, 32, ":%d", self->pid);
19 }
18 self->maps = RB_ROOT; 20 self->maps = RB_ROOT;
19 INIT_LIST_HEAD(&self->removed_maps); 21 INIT_LIST_HEAD(&self->removed_maps);
20 } 22 }
@@ -50,8 +52,10 @@ static size_t thread__fprintf(struct thread *self, FILE *fp)
50 return ret; 52 return ret;
51} 53}
52 54
53struct thread * 55static struct thread *
54threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match) 56__threads__findnew(pid_t pid, struct rb_root *threads,
57 struct thread **last_match,
58 int set_comm)
55{ 59{
56 struct rb_node **p = &threads->rb_node; 60 struct rb_node **p = &threads->rb_node;
57 struct rb_node *parent = NULL; 61 struct rb_node *parent = NULL;
@@ -80,7 +84,8 @@ threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match)
80 p = &(*p)->rb_right; 84 p = &(*p)->rb_right;
81 } 85 }
82 86
83 th = thread__new(pid); 87 th = thread__new(pid, set_comm);
88
84 if (th != NULL) { 89 if (th != NULL) {
85 rb_link_node(&th->rb_node, parent, p); 90 rb_link_node(&th->rb_node, parent, p);
86 rb_insert_color(&th->rb_node, threads); 91 rb_insert_color(&th->rb_node, threads);
@@ -91,6 +96,19 @@ threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match)
91} 96}
92 97
93struct thread * 98struct thread *
99threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match)
100{
101 return __threads__findnew(pid, threads, last_match, 1);
102}
103
104struct thread *
105threads__findnew_nocomm(pid_t pid, struct rb_root *threads,
106 struct thread **last_match)
107{
108 return __threads__findnew(pid, threads, last_match, 0);
109}
110
111struct thread *
94register_idle_thread(struct rb_root *threads, struct thread **last_match) 112register_idle_thread(struct rb_root *threads, struct thread **last_match)
95{ 113{
96 struct thread *thread = threads__findnew(0, threads, last_match); 114 struct thread *thread = threads__findnew(0, threads, last_match);
diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
index 845d9b62f96f..75bc843950c4 100644
--- a/tools/perf/util/thread.h
+++ b/tools/perf/util/thread.h
@@ -18,6 +18,9 @@ int thread__set_comm(struct thread *self, const char *comm);
18struct thread * 18struct thread *
19threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match); 19threads__findnew(pid_t pid, struct rb_root *threads, struct thread **last_match);
20struct thread * 20struct thread *
21threads__findnew_nocomm(pid_t pid, struct rb_root *threads,
22 struct thread **last_match);
23struct thread *
21register_idle_thread(struct rb_root *threads, struct thread **last_match); 24register_idle_thread(struct rb_root *threads, struct thread **last_match);
22void thread__insert_map(struct thread *self, struct map *map); 25void thread__insert_map(struct thread *self, struct map *map);
23int thread__fork(struct thread *self, struct thread *parent); 26int thread__fork(struct thread *self, struct thread *parent);