diff options
| -rw-r--r-- | arch/tile/include/asm/irq.h | 10 | ||||
| -rw-r--r-- | arch/tile/kernel/irq.c | 16 | ||||
| -rw-r--r-- | drivers/net/ethernet/tile/tilepro.c | 4 |
3 files changed, 10 insertions, 20 deletions
diff --git a/arch/tile/include/asm/irq.h b/arch/tile/include/asm/irq.h index 94e9a511de84..f80f8ceabc67 100644 --- a/arch/tile/include/asm/irq.h +++ b/arch/tile/include/asm/irq.h | |||
| @@ -74,16 +74,6 @@ enum { | |||
| 74 | */ | 74 | */ |
| 75 | void tile_irq_activate(unsigned int irq, int tile_irq_type); | 75 | void tile_irq_activate(unsigned int irq, int tile_irq_type); |
| 76 | 76 | ||
| 77 | /* | ||
| 78 | * For onboard, non-PCI (e.g. TILE_IRQ_PERCPU) devices, drivers know | ||
| 79 | * how to use enable/disable_percpu_irq() to manage interrupts on each | ||
| 80 | * core. We can't use the generic enable/disable_irq() because they | ||
| 81 | * use a single reference count per irq, rather than per cpu per irq. | ||
| 82 | */ | ||
| 83 | void enable_percpu_irq(unsigned int irq); | ||
| 84 | void disable_percpu_irq(unsigned int irq); | ||
| 85 | |||
| 86 | |||
| 87 | void setup_irq_regs(void); | 77 | void setup_irq_regs(void); |
| 88 | 78 | ||
| 89 | #endif /* _ASM_TILE_IRQ_H */ | 79 | #endif /* _ASM_TILE_IRQ_H */ |
diff --git a/arch/tile/kernel/irq.c b/arch/tile/kernel/irq.c index aa0134db2dd6..02e628065012 100644 --- a/arch/tile/kernel/irq.c +++ b/arch/tile/kernel/irq.c | |||
| @@ -152,14 +152,13 @@ void tile_dev_intr(struct pt_regs *regs, int intnum) | |||
| 152 | * Remove an irq from the disabled mask. If we're in an interrupt | 152 | * Remove an irq from the disabled mask. If we're in an interrupt |
| 153 | * context, defer enabling the HW interrupt until we leave. | 153 | * context, defer enabling the HW interrupt until we leave. |
| 154 | */ | 154 | */ |
| 155 | void enable_percpu_irq(unsigned int irq) | 155 | static void tile_irq_chip_enable(struct irq_data *d) |
| 156 | { | 156 | { |
| 157 | get_cpu_var(irq_disable_mask) &= ~(1UL << irq); | 157 | get_cpu_var(irq_disable_mask) &= ~(1UL << d->irq); |
| 158 | if (__get_cpu_var(irq_depth) == 0) | 158 | if (__get_cpu_var(irq_depth) == 0) |
| 159 | unmask_irqs(1UL << irq); | 159 | unmask_irqs(1UL << d->irq); |
| 160 | put_cpu_var(irq_disable_mask); | 160 | put_cpu_var(irq_disable_mask); |
| 161 | } | 161 | } |
| 162 | EXPORT_SYMBOL(enable_percpu_irq); | ||
| 163 | 162 | ||
| 164 | /* | 163 | /* |
| 165 | * Add an irq to the disabled mask. We disable the HW interrupt | 164 | * Add an irq to the disabled mask. We disable the HW interrupt |
| @@ -167,13 +166,12 @@ EXPORT_SYMBOL(enable_percpu_irq); | |||
| 167 | * in an interrupt context, the return path is careful to avoid | 166 | * in an interrupt context, the return path is careful to avoid |
| 168 | * unmasking a newly disabled interrupt. | 167 | * unmasking a newly disabled interrupt. |
| 169 | */ | 168 | */ |
| 170 | void disable_percpu_irq(unsigned int irq) | 169 | static void tile_irq_chip_disable(struct irq_data *d) |
| 171 | { | 170 | { |
| 172 | get_cpu_var(irq_disable_mask) |= (1UL << irq); | 171 | get_cpu_var(irq_disable_mask) |= (1UL << d->irq); |
| 173 | mask_irqs(1UL << irq); | 172 | mask_irqs(1UL << d->irq); |
| 174 | put_cpu_var(irq_disable_mask); | 173 | put_cpu_var(irq_disable_mask); |
| 175 | } | 174 | } |
| 176 | EXPORT_SYMBOL(disable_percpu_irq); | ||
| 177 | 175 | ||
| 178 | /* Mask an interrupt. */ | 176 | /* Mask an interrupt. */ |
| 179 | static void tile_irq_chip_mask(struct irq_data *d) | 177 | static void tile_irq_chip_mask(struct irq_data *d) |
| @@ -209,6 +207,8 @@ static void tile_irq_chip_eoi(struct irq_data *d) | |||
| 209 | 207 | ||
| 210 | static struct irq_chip tile_irq_chip = { | 208 | static struct irq_chip tile_irq_chip = { |
| 211 | .name = "tile_irq_chip", | 209 | .name = "tile_irq_chip", |
| 210 | .irq_enable = tile_irq_chip_enable, | ||
| 211 | .irq_disable = tile_irq_chip_disable, | ||
| 212 | .irq_ack = tile_irq_chip_ack, | 212 | .irq_ack = tile_irq_chip_ack, |
| 213 | .irq_eoi = tile_irq_chip_eoi, | 213 | .irq_eoi = tile_irq_chip_eoi, |
| 214 | .irq_mask = tile_irq_chip_mask, | 214 | .irq_mask = tile_irq_chip_mask, |
diff --git a/drivers/net/ethernet/tile/tilepro.c b/drivers/net/ethernet/tile/tilepro.c index 1c0f9facb9b1..1187a1169eb2 100644 --- a/drivers/net/ethernet/tile/tilepro.c +++ b/drivers/net/ethernet/tile/tilepro.c | |||
| @@ -926,7 +926,7 @@ static int tile_net_poll(struct napi_struct *napi, int budget) | |||
| 926 | goto done; | 926 | goto done; |
| 927 | 927 | ||
| 928 | /* Re-enable the ingress interrupt. */ | 928 | /* Re-enable the ingress interrupt. */ |
| 929 | enable_percpu_irq(priv->intr_id); | 929 | enable_percpu_irq(priv->intr_id, 0); |
| 930 | 930 | ||
| 931 | /* HACK: Avoid the "rotting packet" problem (see above). */ | 931 | /* HACK: Avoid the "rotting packet" problem (see above). */ |
| 932 | if (qup->__packet_receive_read != | 932 | if (qup->__packet_receive_read != |
| @@ -1296,7 +1296,7 @@ static void tile_net_open_enable(void *dev_ptr) | |||
| 1296 | info->napi_enabled = true; | 1296 | info->napi_enabled = true; |
| 1297 | 1297 | ||
| 1298 | /* Enable the ingress interrupt. */ | 1298 | /* Enable the ingress interrupt. */ |
| 1299 | enable_percpu_irq(priv->intr_id); | 1299 | enable_percpu_irq(priv->intr_id, 0); |
| 1300 | } | 1300 | } |
| 1301 | 1301 | ||
| 1302 | 1302 | ||
