diff options
author | Jan Kiszka <jan.kiszka@siemens.com> | 2012-03-29 15:14:12 -0400 |
---|---|---|
committer | Avi Kivity <avi@redhat.com> | 2012-04-24 08:59:47 -0400 |
commit | 07975ad3b30579ca27d880491ad992326b930c63 (patch) | |
tree | fea166a02c387949a09a948a51781074bdc9ed68 /virt/kvm | |
parent | 1f15d10984c854e077da5aa1a23f901496b49773 (diff) |
KVM: Introduce direct MSI message injection for in-kernel irqchips
Currently, MSI messages can only be injected to in-kernel irqchips by
defining a corresponding IRQ route for each message. This is not only
unhandy if the MSI messages are generated "on the fly" by user space,
IRQ routes are a limited resource that user space has to manage
carefully.
By providing a direct injection path, we can both avoid using up limited
resources and simplify the necessary steps for user land.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
Diffstat (limited to 'virt/kvm')
-rw-r--r-- | virt/kvm/Kconfig | 3 | ||||
-rw-r--r-- | virt/kvm/irq_comm.c | 14 | ||||
-rw-r--r-- | virt/kvm/kvm_main.c | 14 |
3 files changed, 31 insertions, 0 deletions
diff --git a/virt/kvm/Kconfig b/virt/kvm/Kconfig index f63ccb0a5982..28694f4a9139 100644 --- a/virt/kvm/Kconfig +++ b/virt/kvm/Kconfig | |||
@@ -18,3 +18,6 @@ config KVM_MMIO | |||
18 | 18 | ||
19 | config KVM_ASYNC_PF | 19 | config KVM_ASYNC_PF |
20 | bool | 20 | bool |
21 | |||
22 | config HAVE_KVM_MSI | ||
23 | bool | ||
diff --git a/virt/kvm/irq_comm.c b/virt/kvm/irq_comm.c index 9f614b4e365f..a6a0365475ed 100644 --- a/virt/kvm/irq_comm.c +++ b/virt/kvm/irq_comm.c | |||
@@ -138,6 +138,20 @@ int kvm_set_msi(struct kvm_kernel_irq_routing_entry *e, | |||
138 | return kvm_irq_delivery_to_apic(kvm, NULL, &irq); | 138 | return kvm_irq_delivery_to_apic(kvm, NULL, &irq); |
139 | } | 139 | } |
140 | 140 | ||
141 | int kvm_send_userspace_msi(struct kvm *kvm, struct kvm_msi *msi) | ||
142 | { | ||
143 | struct kvm_kernel_irq_routing_entry route; | ||
144 | |||
145 | if (!irqchip_in_kernel(kvm) || msi->flags != 0) | ||
146 | return -EINVAL; | ||
147 | |||
148 | route.msi.address_lo = msi->address_lo; | ||
149 | route.msi.address_hi = msi->address_hi; | ||
150 | route.msi.data = msi->data; | ||
151 | |||
152 | return kvm_set_msi(&route, kvm, KVM_USERSPACE_IRQ_SOURCE_ID, 1); | ||
153 | } | ||
154 | |||
141 | /* | 155 | /* |
142 | * Return value: | 156 | * Return value: |
143 | * < 0 Interrupt was ignored (masked or not delivered for other reasons) | 157 | * < 0 Interrupt was ignored (masked or not delivered for other reasons) |
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 9eb7936e491d..1847c762d8d9 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c | |||
@@ -2060,6 +2060,17 @@ static long kvm_vm_ioctl(struct file *filp, | |||
2060 | mutex_unlock(&kvm->lock); | 2060 | mutex_unlock(&kvm->lock); |
2061 | break; | 2061 | break; |
2062 | #endif | 2062 | #endif |
2063 | #ifdef CONFIG_HAVE_KVM_MSI | ||
2064 | case KVM_SIGNAL_MSI: { | ||
2065 | struct kvm_msi msi; | ||
2066 | |||
2067 | r = -EFAULT; | ||
2068 | if (copy_from_user(&msi, argp, sizeof msi)) | ||
2069 | goto out; | ||
2070 | r = kvm_send_userspace_msi(kvm, &msi); | ||
2071 | break; | ||
2072 | } | ||
2073 | #endif | ||
2063 | default: | 2074 | default: |
2064 | r = kvm_arch_vm_ioctl(filp, ioctl, arg); | 2075 | r = kvm_arch_vm_ioctl(filp, ioctl, arg); |
2065 | if (r == -ENOTTY) | 2076 | if (r == -ENOTTY) |
@@ -2188,6 +2199,9 @@ static long kvm_dev_ioctl_check_extension_generic(long arg) | |||
2188 | case KVM_CAP_SET_BOOT_CPU_ID: | 2199 | case KVM_CAP_SET_BOOT_CPU_ID: |
2189 | #endif | 2200 | #endif |
2190 | case KVM_CAP_INTERNAL_ERROR_DATA: | 2201 | case KVM_CAP_INTERNAL_ERROR_DATA: |
2202 | #ifdef CONFIG_HAVE_KVM_MSI | ||
2203 | case KVM_CAP_SIGNAL_MSI: | ||
2204 | #endif | ||
2191 | return 1; | 2205 | return 1; |
2192 | #ifdef CONFIG_HAVE_KVM_IRQCHIP | 2206 | #ifdef CONFIG_HAVE_KVM_IRQCHIP |
2193 | case KVM_CAP_IRQ_ROUTING: | 2207 | case KVM_CAP_IRQ_ROUTING: |