aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/util
diff options
context:
space:
mode:
authorNamhyung Kim <namhyung.kim@lge.com>2012-11-29 01:38:30 -0500
committerArnaldo Carvalho de Melo <acme@redhat.com>2012-12-09 06:46:06 -0500
commit823254edc66eb44bf612b1dfa4829afa9840f691 (patch)
tree50f6c26d96228717f35dbf989ca0534bbda9ca11 /tools/perf/util
parent2cfda562da7b0b1e0575507ef3efe782d4e218e4 (diff)
perf evsel: Convert to _is_group_leader method
Convert perf_evsel__is_group_member to perf_evsel__is_group_leader. This is because the most usecases are using negative form to check whether the given evsel is a leader or not and it's IMHO somewhat ambiguous - leader also *is* a member of the group. Signed-off-by: Namhyung Kim <namhyung@kernel.org> Acked-by: Jiri Olsa <jolsa@redhat.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/r/1354171126-14387-4-git-send-email-namhyung@kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util')
-rw-r--r--tools/perf/util/evlist.c4
-rw-r--r--tools/perf/util/evsel.c6
-rw-r--r--tools/perf/util/evsel.h4
3 files changed, 7 insertions, 7 deletions
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 90db2a14e4bb..d0e1e821fe85 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -221,7 +221,7 @@ void perf_evlist__disable(struct perf_evlist *evlist)
221 221
222 for (cpu = 0; cpu < evlist->cpus->nr; cpu++) { 222 for (cpu = 0; cpu < evlist->cpus->nr; cpu++) {
223 list_for_each_entry(pos, &evlist->entries, node) { 223 list_for_each_entry(pos, &evlist->entries, node) {
224 if (perf_evsel__is_group_member(pos)) 224 if (!perf_evsel__is_group_leader(pos))
225 continue; 225 continue;
226 for (thread = 0; thread < evlist->threads->nr; thread++) 226 for (thread = 0; thread < evlist->threads->nr; thread++)
227 ioctl(FD(pos, cpu, thread), 227 ioctl(FD(pos, cpu, thread),
@@ -237,7 +237,7 @@ void perf_evlist__enable(struct perf_evlist *evlist)
237 237
238 for (cpu = 0; cpu < cpu_map__nr(evlist->cpus); cpu++) { 238 for (cpu = 0; cpu < cpu_map__nr(evlist->cpus); cpu++) {
239 list_for_each_entry(pos, &evlist->entries, node) { 239 list_for_each_entry(pos, &evlist->entries, node) {
240 if (perf_evsel__is_group_member(pos)) 240 if (!perf_evsel__is_group_leader(pos))
241 continue; 241 continue;
242 for (thread = 0; thread < evlist->threads->nr; thread++) 242 for (thread = 0; thread < evlist->threads->nr; thread++)
243 ioctl(FD(pos, cpu, thread), 243 ioctl(FD(pos, cpu, thread),
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 7e93418a45d1..bb58b05f905f 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -520,14 +520,14 @@ void perf_evsel__config(struct perf_evsel *evsel,
520 * Disabling only independent events or group leaders, 520 * Disabling only independent events or group leaders,
521 * keeping group members enabled. 521 * keeping group members enabled.
522 */ 522 */
523 if (!perf_evsel__is_group_member(evsel)) 523 if (perf_evsel__is_group_leader(evsel))
524 attr->disabled = 1; 524 attr->disabled = 1;
525 525
526 /* 526 /*
527 * Setting enable_on_exec for independent events and 527 * Setting enable_on_exec for independent events and
528 * group leaders for traced executed by perf. 528 * group leaders for traced executed by perf.
529 */ 529 */
530 if (perf_target__none(&opts->target) && !perf_evsel__is_group_member(evsel)) 530 if (perf_target__none(&opts->target) && perf_evsel__is_group_leader(evsel))
531 attr->enable_on_exec = 1; 531 attr->enable_on_exec = 1;
532} 532}
533 533
@@ -708,7 +708,7 @@ static int get_group_fd(struct perf_evsel *evsel, int cpu, int thread)
708 struct perf_evsel *leader = evsel->leader; 708 struct perf_evsel *leader = evsel->leader;
709 int fd; 709 int fd;
710 710
711 if (!perf_evsel__is_group_member(evsel)) 711 if (perf_evsel__is_group_leader(evsel))
712 return -1; 712 return -1;
713 713
714 /* 714 /*
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h
index cbf6d97f0646..3f7ff471de2b 100644
--- a/tools/perf/util/evsel.h
+++ b/tools/perf/util/evsel.h
@@ -226,8 +226,8 @@ static inline struct perf_evsel *perf_evsel__next(struct perf_evsel *evsel)
226 return list_entry(evsel->node.next, struct perf_evsel, node); 226 return list_entry(evsel->node.next, struct perf_evsel, node);
227} 227}
228 228
229static inline bool perf_evsel__is_group_member(const struct perf_evsel *evsel) 229static inline bool perf_evsel__is_group_leader(const struct perf_evsel *evsel)
230{ 230{
231 return evsel->leader != evsel; 231 return evsel->leader == evsel;
232} 232}
233#endif /* __PERF_EVSEL_H */ 233#endif /* __PERF_EVSEL_H */