diff options
author | Namhyung Kim <namhyung.kim@lge.com> | 2013-01-22 04:09:44 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2013-01-31 11:07:48 -0500 |
commit | 717e263fc354d53d0961e952b779d14a42c8ea66 (patch) | |
tree | 8bac96ac04d96d7544d9443fb29599480bb88a2f /tools/perf/util | |
parent | fc24d7c25c9d880ae012548d522fe13caee556ed (diff) |
perf report: Show group description when event group is enabled
When using event group viewer, it's better to show the group description
rather than the leader information alone.
If a leader did not contain any member, it's a non-group event.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/1358845787-1350-17-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Diffstat (limited to 'tools/perf/util')
-rw-r--r-- | tools/perf/util/evsel.c | 25 | ||||
-rw-r--r-- | tools/perf/util/evsel.h | 8 |
2 files changed, 33 insertions, 0 deletions
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c index baa26ddbcc7b..94e74043ded8 100644 --- a/tools/perf/util/evsel.c +++ b/tools/perf/util/evsel.c | |||
@@ -434,6 +434,31 @@ const char *perf_evsel__name(struct perf_evsel *evsel) | |||
434 | return evsel->name ?: "unknown"; | 434 | return evsel->name ?: "unknown"; |
435 | } | 435 | } |
436 | 436 | ||
437 | const char *perf_evsel__group_name(struct perf_evsel *evsel) | ||
438 | { | ||
439 | return evsel->group_name ?: "anon group"; | ||
440 | } | ||
441 | |||
442 | int perf_evsel__group_desc(struct perf_evsel *evsel, char *buf, size_t size) | ||
443 | { | ||
444 | int ret; | ||
445 | struct perf_evsel *pos; | ||
446 | const char *group_name = perf_evsel__group_name(evsel); | ||
447 | |||
448 | ret = scnprintf(buf, size, "%s", group_name); | ||
449 | |||
450 | ret += scnprintf(buf + ret, size - ret, " { %s", | ||
451 | perf_evsel__name(evsel)); | ||
452 | |||
453 | for_each_group_member(pos, evsel) | ||
454 | ret += scnprintf(buf + ret, size - ret, ", %s", | ||
455 | perf_evsel__name(pos)); | ||
456 | |||
457 | ret += scnprintf(buf + ret, size - ret, " }"); | ||
458 | |||
459 | return ret; | ||
460 | } | ||
461 | |||
437 | /* | 462 | /* |
438 | * The enable_on_exec/disabled value strategy: | 463 | * The enable_on_exec/disabled value strategy: |
439 | * | 464 | * |
diff --git a/tools/perf/util/evsel.h b/tools/perf/util/evsel.h index 371713977888..8512f6a8a6ea 100644 --- a/tools/perf/util/evsel.h +++ b/tools/perf/util/evsel.h | |||
@@ -114,6 +114,8 @@ extern const char *perf_evsel__sw_names[PERF_COUNT_SW_MAX]; | |||
114 | int __perf_evsel__hw_cache_type_op_res_name(u8 type, u8 op, u8 result, | 114 | int __perf_evsel__hw_cache_type_op_res_name(u8 type, u8 op, u8 result, |
115 | char *bf, size_t size); | 115 | char *bf, size_t size); |
116 | const char *perf_evsel__name(struct perf_evsel *evsel); | 116 | const char *perf_evsel__name(struct perf_evsel *evsel); |
117 | const char *perf_evsel__group_name(struct perf_evsel *evsel); | ||
118 | int perf_evsel__group_desc(struct perf_evsel *evsel, char *buf, size_t size); | ||
117 | 119 | ||
118 | int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads); | 120 | int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads); |
119 | int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads); | 121 | int perf_evsel__alloc_id(struct perf_evsel *evsel, int ncpus, int nthreads); |
@@ -267,4 +269,10 @@ static inline int perf_evsel__group_idx(struct perf_evsel *evsel) | |||
267 | { | 269 | { |
268 | return evsel->idx - evsel->leader->idx; | 270 | return evsel->idx - evsel->leader->idx; |
269 | } | 271 | } |
272 | |||
273 | #define for_each_group_member(_evsel, _leader) \ | ||
274 | for ((_evsel) = list_entry((_leader)->node.next, struct perf_evsel, node); \ | ||
275 | (_evsel) && (_evsel)->leader == (_leader); \ | ||
276 | (_evsel) = list_entry((_evsel)->node.next, struct perf_evsel, node)) | ||
277 | |||
270 | #endif /* __PERF_EVSEL_H */ | 278 | #endif /* __PERF_EVSEL_H */ |