aboutsummaryrefslogtreecommitdiffstats
path: root/tools/perf/ui
diff options
context:
space:
mode:
authorMichael Hudson-Doyle <michael.hudson@linaro.org>2013-10-31 19:47:45 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2013-12-04 13:55:49 -0500
commit9dfd005a3f4e1c648cb4aa1dc70604bb370c5e7b (patch)
tree21b13f4c6dced500f1d17dabea798537eb5cd737 /tools/perf/ui
parentf9bdb31ae29c0cf60b35ed83c98e7a4043873336 (diff)
perf tools: Remove cast of non-variadic function to variadic
commit 53805eca3d89b095062c11a6798689bb0af09216 upstream. The 4fb71074a570 (perf ui/hist: Consolidate hpp helpers) cset introduced a cast of percent_color_snprintf to a function pointer type with varargs. Change percent_color_snprintf to be variadic and remove the cast. The symptom of this was all percentages being reported as 0.00% in perf report --stdio output on the armhf arch. Signed-off-by: Michael Hudson-Doyle <michael.hudson@linaro.org> Acked-by: Namhyung Kim <namhyung@kernel.org> Acked-by: Will Deacon <will.deacon@arm.com> Cc: Jean Pihet <jean.pihet@linaro.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Will Deacon <will.deacon@arm.com> Link: http://lkml.kernel.org/r/87zjppvw7y.fsf@canonical.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/perf/ui')
-rw-r--r--tools/perf/ui/hist.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/ui/hist.c b/tools/perf/ui/hist.c
index 4bf91b09d62d..794bb1a120be 100644
--- a/tools/perf/ui/hist.c
+++ b/tools/perf/ui/hist.c
@@ -113,7 +113,7 @@ static u64 he_get_##_field(struct hist_entry *he) \
113static int hpp__color_##_type(struct perf_hpp *hpp, struct hist_entry *he) \ 113static int hpp__color_##_type(struct perf_hpp *hpp, struct hist_entry *he) \
114{ \ 114{ \
115 return __hpp__fmt(hpp, he, he_get_##_field, " %6.2f%%", \ 115 return __hpp__fmt(hpp, he, he_get_##_field, " %6.2f%%", \
116 (hpp_snprint_fn)percent_color_snprintf, true); \ 116 percent_color_snprintf, true); \
117} 117}
118 118
119#define __HPP_ENTRY_PERCENT_FN(_type, _field) \ 119#define __HPP_ENTRY_PERCENT_FN(_type, _field) \