Merge branch 'fix/misc' into topic/misc

5 files changed, 83 insertions, 49 deletions

diff --git a/sound/pci/hda/hda_codec.c b/sound/pci/hda/hda_codec.c
index 3e7850c238c3..f3aefef37216 100644
--- a/sound/pci/hda/hda_codec.c
+++ b/sound/pci/hda/hda_codec.c
@@ -579,9 +579,13 @@ int snd_hda_get_conn_index(struct hda_codec *codec, hda_nid_t mux,
                 return -1;
         }
         recursive++;
-        for (i = 0; i < nums; i++)
+        for (i = 0; i < nums; i++) {
+                unsigned int type = get_wcaps_type(get_wcaps(codec, conn[i]));
+                if (type == AC_WID_PIN || type == AC_WID_AUD_OUT)
+                        continue;
                 if (snd_hda_get_conn_index(codec, conn[i], nid, recursive) >= 0)
                         return i;
+        }
         return -1;
 }
 EXPORT_SYMBOL_HDA(snd_hda_get_conn_index);
diff --git a/sound/pci/hda/hda_eld.c b/sound/pci/hda/hda_eld.c
index 28ce17d09c33..c34f730f4815 100644
--- a/sound/pci/hda/hda_eld.c
+++ b/sound/pci/hda/hda_eld.c
@@ -144,25 +144,17 @@ static int cea_sampling_frequencies[8] = {
         SNDRV_PCM_RATE_192000,  /* 7: 192000Hz */
 };
 
-static unsigned char hdmi_get_eld_byte(struct hda_codec *codec, hda_nid_t nid,
+static unsigned int hdmi_get_eld_data(struct hda_codec *codec, hda_nid_t nid,
                                         int byte_index)
 {
         unsigned int val;
 
         val = snd_hda_codec_read(codec, nid, 0,
                                         AC_VERB_GET_HDMI_ELDD, byte_index);
-
 #ifdef BE_PARANOID
         printk(KERN_INFO "HDMI: ELD data byte %d: 0x%x\n", byte_index, val);
 #endif
-
-        if ((val & AC_ELDD_ELD_VALID) == 0) {
-                snd_printd(KERN_INFO "HDMI: invalid ELD data byte %d\n",
-                                                                byte_index);
-                val = 0;
-        }
-
-        return val & AC_ELDD_ELD_DATA;
+        return val;
 }
 
 #define GRAB_BITS(buf, byte, lowbit, bits)              \
@@ -344,11 +336,26 @@ int snd_hdmi_get_eld(struct hdmi_eld *eld,
         if (!buf)
                 return -ENOMEM;
 
-        for (i = 0; i < size; i++)
-                buf[i] = hdmi_get_eld_byte(codec, nid, i);
+        for (i = 0; i < size; i++) {
+                unsigned int val = hdmi_get_eld_data(codec, nid, i);
+                if (!(val & AC_ELDD_ELD_VALID)) {
+                        if (!i) {
+                                snd_printd(KERN_INFO
+                                           "HDMI: invalid ELD data\n");
+                                ret = -EINVAL;
+                                goto error;
+                        }
+                        snd_printd(KERN_INFO
+                                  "HDMI: invalid ELD data byte %d\n", i);
+                        val = 0;
+                } else
+                        val &= AC_ELDD_ELD_DATA;
+                buf[i] = val;
+        }
 
         ret = hdmi_update_eld(eld, buf, size);
 
+error:
         kfree(buf);
         return ret;
 }
diff --git a/sound/pci/hda/patch_cirrus.c b/sound/pci/hda/patch_cirrus.c
index 47d6ffc9b5b5..c45f3e69bcf0 100644
--- a/sound/pci/hda/patch_cirrus.c
+++ b/sound/pci/hda/patch_cirrus.c
@@ -375,7 +375,7 @@ static int is_ext_mic(struct hda_codec *codec, unsigned int idx)
 static hda_nid_t get_adc(struct hda_codec *codec, hda_nid_t pin,
                          unsigned int *idxp)
 {
-        int i;
+        int i, idx;
         hda_nid_t nid;
 
         nid = codec->start_nid;
@@ -384,9 +384,11 @@ static hda_nid_t get_adc(struct hda_codec *codec, hda_nid_t pin,
                 type = get_wcaps_type(get_wcaps(codec, nid));
                 if (type != AC_WID_AUD_IN)
                         continue;
-                *idxp = snd_hda_get_conn_index(codec, nid, pin, false);
-                if (*idxp >= 0)
+                idx = snd_hda_get_conn_index(codec, nid, pin, false);
+                if (idx >= 0) {
+                        *idxp = idx;
                         return nid;
+                }
         }
         return 0;
 }
@@ -533,7 +535,7 @@ static int add_volume(struct hda_codec *codec, const char *name,
                       int index, unsigned int pval, int dir,
                       struct snd_kcontrol **kctlp)
 {
-        char tmp[32];
+        char tmp[44];
         struct snd_kcontrol_new knew =
                 HDA_CODEC_VOLUME_IDX(tmp, index, 0, 0, HDA_OUTPUT);
         knew.private_value = pval;
diff --git a/sound/pci/hda/patch_conexant.c b/sound/pci/hda/patch_conexant.c
index 502fc9499453..7696d05b9356 100644
--- a/sound/pci/hda/patch_conexant.c
+++ b/sound/pci/hda/patch_conexant.c
@@ -3348,6 +3348,8 @@ static hda_nid_t get_unassigned_dac(struct hda_codec *codec, hda_nid_t pin,
 
 #define MAX_AUTO_DACS   5
 
+#define DAC_SLAVE_FLAG  0x8000  /* filled dac is a slave */
+
 /* fill analog DAC list from the widget tree */
 static int fill_cx_auto_dacs(struct hda_codec *codec, hda_nid_t *dacs)
 {
@@ -3370,16 +3372,26 @@ static int fill_cx_auto_dacs(struct hda_codec *codec, hda_nid_t *dacs)
 /* fill pin_dac_pair list from the pin and dac list */
 static int fill_dacs_for_pins(struct hda_codec *codec, hda_nid_t *pins,
                               int num_pins, hda_nid_t *dacs, int *rest,
-                              struct pin_dac_pair *filled, int type)
+                              struct pin_dac_pair *filled, int nums, 
+                              int type)
 {
-        int i, nums;
+        int i, start = nums;
 
-        nums = 0;
-        for (i = 0; i < num_pins; i++) {
+        for (i = 0; i < num_pins; i++, nums++) {
                 filled[nums].pin = pins[i];
                 filled[nums].type = type;
                 filled[nums].dac = get_unassigned_dac(codec, pins[i], dacs, rest);
-                nums++;
+                if (filled[nums].dac) 
+                        continue;
+                if (filled[start].dac && get_connection_index(codec, pins[i], filled[start].dac) >= 0) {
+                        filled[nums].dac = filled[start].dac | DAC_SLAVE_FLAG;
+                        continue;
+                }
+                if (filled[0].dac && get_connection_index(codec, pins[i], filled[0].dac) >= 0) {
+                        filled[nums].dac = filled[0].dac | DAC_SLAVE_FLAG;
+                        continue;
+                }
+                snd_printdd("Failed to find a DAC for pin 0x%x", pins[i]);
         }
         return nums;
 }
@@ -3395,19 +3407,19 @@ static void cx_auto_parse_output(struct hda_codec *codec)
         rest = fill_cx_auto_dacs(codec, dacs);
         /* parse all analog output pins */
         nums = fill_dacs_for_pins(codec, cfg->line_out_pins, cfg->line_outs,
-                                  dacs, &rest, spec->dac_info,
-                                  AUTO_PIN_LINE_OUT);
-        nums += fill_dacs_for_pins(codec, cfg->hp_pins, cfg->hp_outs,
-                                  dacs, &rest, spec->dac_info + nums,
-                                  AUTO_PIN_HP_OUT);
-        nums += fill_dacs_for_pins(codec, cfg->speaker_pins, cfg->speaker_outs,
-                                  dacs, &rest, spec->dac_info + nums,
-                                  AUTO_PIN_SPEAKER_OUT);
+                          dacs, &rest, spec->dac_info, 0,
+                          AUTO_PIN_LINE_OUT);
+        nums = fill_dacs_for_pins(codec, cfg->hp_pins, cfg->hp_outs,
+                          dacs, &rest, spec->dac_info, nums,
+                          AUTO_PIN_HP_OUT);
+        nums = fill_dacs_for_pins(codec, cfg->speaker_pins, cfg->speaker_outs,
+                          dacs, &rest, spec->dac_info, nums,
+                          AUTO_PIN_SPEAKER_OUT);
         spec->dac_info_filled = nums;
         /* fill multiout struct */
         for (i = 0; i < nums; i++) {
                 hda_nid_t dac = spec->dac_info[i].dac;
-                if (!dac)
+                if (!dac || (dac & DAC_SLAVE_FLAG))
                         continue;
                 switch (spec->dac_info[i].type) {
                 case AUTO_PIN_LINE_OUT:
@@ -3862,7 +3874,7 @@ static void cx_auto_parse_input(struct hda_codec *codec)
         }
         if (imux->num_items >= 2 && cfg->num_inputs == imux->num_items)
                 cx_auto_check_auto_mic(codec);
-        if (imux->num_items > 1 && !spec->auto_mic) {
+        if (imux->num_items > 1) {
                 for (i = 1; i < imux->num_items; i++) {
                         if (spec->imux_info[i].adc != spec->imux_info[0].adc) {
                                 spec->adc_switching = 1;
@@ -4035,6 +4047,8 @@ static void cx_auto_init_output(struct hda_codec *codec)
                 nid = spec->dac_info[i].dac;
                 if (!nid)
                         nid = spec->multiout.dac_nids[0];
+                else if (nid & DAC_SLAVE_FLAG)
+                        nid &= ~DAC_SLAVE_FLAG;
                 select_connection(codec, spec->dac_info[i].pin, nid);
         }
         if (spec->auto_mute) {
@@ -4167,9 +4181,11 @@ static int try_add_pb_volume(struct hda_codec *codec, hda_nid_t dac,
                              hda_nid_t pin, const char *name, int idx)
 {
         unsigned int caps;
-        caps = query_amp_caps(codec, dac, HDA_OUTPUT);
-        if (caps & AC_AMPCAP_NUM_STEPS)
-                return cx_auto_add_pb_volume(codec, dac, name, idx);
+        if (dac && !(dac & DAC_SLAVE_FLAG)) {
+                caps = query_amp_caps(codec, dac, HDA_OUTPUT);
+                if (caps & AC_AMPCAP_NUM_STEPS)
+                        return cx_auto_add_pb_volume(codec, dac, name, idx);
+        }
         caps = query_amp_caps(codec, pin, HDA_OUTPUT);
         if (caps & AC_AMPCAP_NUM_STEPS)
                 return cx_auto_add_pb_volume(codec, pin, name, idx);
@@ -4191,8 +4207,7 @@ static int cx_auto_build_output_controls(struct hda_codec *codec)
         for (i = 0; i < spec->dac_info_filled; i++) {
                 const char *label;
                 int idx, type;
-                if (!spec->dac_info[i].dac)
-                        continue;
+                hda_nid_t dac = spec->dac_info[i].dac;
                 type = spec->dac_info[i].type;
                 if (type == AUTO_PIN_LINE_OUT)
                         type = spec->autocfg.line_out_type;
@@ -4211,7 +4226,7 @@ static int cx_auto_build_output_controls(struct hda_codec *codec)
                         idx = num_spk++;
                         break;
                 }
-                err = try_add_pb_volume(codec, spec->dac_info[i].dac,
+                err = try_add_pb_volume(codec, dac,
                                         spec->dac_info[i].pin,
                                         label, idx);
                 if (err < 0)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fcb11af9ad24..7cabd7317163 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -565,11 +565,11 @@ static void alc_hp_automute(struct hda_codec *codec)
 {
         struct alc_spec *spec = codec->spec;
 
-        if (!spec->automute)
-                return;
         spec->jack_present =
                 detect_jacks(codec, ARRAY_SIZE(spec->autocfg.hp_pins),
                              spec->autocfg.hp_pins);
+        if (!spec->automute)
+                return;
         update_speakers(codec);
 }
 
@@ -578,11 +578,11 @@ static void alc_line_automute(struct hda_codec *codec)
 {
         struct alc_spec *spec = codec->spec;
 
-        if (!spec->automute || !spec->detect_line)
-                return;
         spec->line_jack_present =
                 detect_jacks(codec, ARRAY_SIZE(spec->autocfg.line_out_pins),
                              spec->autocfg.line_out_pins);
+        if (!spec->automute || !spec->detect_line)
+                return;
         update_speakers(codec);
 }
 
@@ -3083,16 +3083,22 @@ static void alc_auto_init_multi_out(struct hda_codec *codec)
 static void alc_auto_init_extra_out(struct hda_codec *codec)
 {
         struct alc_spec *spec = codec->spec;
-        hda_nid_t pin;
+        hda_nid_t pin, dac;
 
         pin = spec->autocfg.hp_pins[0];
-        if (pin)
-                alc_auto_set_output_and_unmute(codec, pin, PIN_HP,
-                                                  spec->multiout.hp_nid);
+        if (pin) {
+                dac = spec->multiout.hp_nid;
+                if (!dac)
+                        dac = spec->multiout.dac_nids[0];
+                alc_auto_set_output_and_unmute(codec, pin, PIN_HP, dac);
+        }
         pin = spec->autocfg.speaker_pins[0];
-        if (pin)
-                alc_auto_set_output_and_unmute(codec, pin, PIN_OUT,
-                                        spec->multiout.extra_out_nid[0]);
+        if (pin) {
+                dac = spec->multiout.extra_out_nid[0];
+                if (!dac)
+                        dac = spec->multiout.dac_nids[0];
+                alc_auto_set_output_and_unmute(codec, pin, PIN_OUT, dac);
+        }
 }
 
 /*