aboutsummaryrefslogtreecommitdiffstats
path: root/security
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2012-10-01 13:25:54 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2012-10-01 13:25:54 -0400
commit94095a1fff89dffe9451839deae4c6a40cf3ec21 (patch)
treec1beac5dc336d836c269253db3b00a302777598f /security
parent620e77533f29796df7aff861e79bd72e08554ebb (diff)
parentf784e8a7989c0da3062d04bfea3db90f41e8f738 (diff)
Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
Pull core kernel fixes from Ingo Molnar: "This is a complex task_work series from Oleg that fixes the bug that this VFS commit tried to fix: d35abdb28824 hold task_lock around checks in keyctl but solves the problem without the lockup regression that d35abdb28824 introduced in v3.6. This series came late in v3.6 and I did not feel confident about it so late in the cycle. Might be worth backporting to -stable if it proves itself upstream." * 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip: task_work: Simplify the usage in ptrace_notify() and get_signal_to_deliver() task_work: Revert "hold task_lock around checks in keyctl" task_work: task_work_add() should not succeed after exit_task_work() task_work: Make task_work_add() lockless
Diffstat (limited to 'security')
-rw-r--r--security/keys/keyctl.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c
index 3364fbf46807..6cfc6478863e 100644
--- a/security/keys/keyctl.c
+++ b/security/keys/keyctl.c
@@ -1486,7 +1486,6 @@ long keyctl_session_to_parent(void)
1486 oldwork = NULL; 1486 oldwork = NULL;
1487 parent = me->real_parent; 1487 parent = me->real_parent;
1488 1488
1489 task_lock(parent);
1490 /* the parent mustn't be init and mustn't be a kernel thread */ 1489 /* the parent mustn't be init and mustn't be a kernel thread */
1491 if (parent->pid <= 1 || !parent->mm) 1490 if (parent->pid <= 1 || !parent->mm)
1492 goto unlock; 1491 goto unlock;
@@ -1530,7 +1529,6 @@ long keyctl_session_to_parent(void)
1530 if (!ret) 1529 if (!ret)
1531 newwork = NULL; 1530 newwork = NULL;
1532unlock: 1531unlock:
1533 task_unlock(parent);
1534 write_unlock_irq(&tasklist_lock); 1532 write_unlock_irq(&tasklist_lock);
1535 rcu_read_unlock(); 1533 rcu_read_unlock();
1536 if (oldwork) 1534 if (oldwork)