aboutsummaryrefslogtreecommitdiffstats
path: root/net
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2013-03-25 16:19:59 -0400
committerDavid S. Miller <davem@davemloft.net>2013-03-26 12:44:44 -0400
commit15e5a030716468dce4032fa0f398d840fa2756f6 (patch)
tree59a450599ed491e4bd117ea56a60f5ab79821586 /net
parentf9ca8f74399f9195fd8e01f67a8424a8d33efa55 (diff)
net_sched: better precise estimation on packet length for untrusted packets
gso_segs were reset to zero when kernel receive packets from untrusted source. But we use this zero value to estimate precise packet len which is wrong. So this patch tries to estimate the correct gso_segs value before using it in qdisc_pkt_len_init(). Cc: Eric Dumazet <edumazet@google.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r--net/core/dev.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c
index de930b751712..f5ad23bb24fc 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2588,6 +2588,7 @@ static void qdisc_pkt_len_init(struct sk_buff *skb)
2588 */ 2588 */
2589 if (shinfo->gso_size) { 2589 if (shinfo->gso_size) {
2590 unsigned int hdr_len; 2590 unsigned int hdr_len;
2591 u16 gso_segs = shinfo->gso_segs;
2591 2592
2592 /* mac layer + network layer */ 2593 /* mac layer + network layer */
2593 hdr_len = skb_transport_header(skb) - skb_mac_header(skb); 2594 hdr_len = skb_transport_header(skb) - skb_mac_header(skb);
@@ -2597,7 +2598,12 @@ static void qdisc_pkt_len_init(struct sk_buff *skb)
2597 hdr_len += tcp_hdrlen(skb); 2598 hdr_len += tcp_hdrlen(skb);
2598 else 2599 else
2599 hdr_len += sizeof(struct udphdr); 2600 hdr_len += sizeof(struct udphdr);
2600 qdisc_skb_cb(skb)->pkt_len += (shinfo->gso_segs - 1) * hdr_len; 2601
2602 if (shinfo->gso_type & SKB_GSO_DODGY)
2603 gso_segs = DIV_ROUND_UP(skb->len - hdr_len,
2604 shinfo->gso_size);
2605
2606 qdisc_skb_cb(skb)->pkt_len += (gso_segs - 1) * hdr_len;
2601 } 2607 }
2602} 2608}
2603 2609