diff options
| author | Jouni Malinen <jouni@qca.qualcomm.com> | 2011-08-11 04:46:22 -0400 |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2011-08-11 14:23:06 -0400 |
| commit | f612cedfe152b536197c0120f2e7779bc90219d0 (patch) | |
| tree | c1ad3b3a00a26eff4b78d81331c168faf901a4ba /net/wireless | |
| parent | 040bdf713d2bec8235f1af705e2d13da5d9baec8 (diff) | |
nl80211/cfg80211: Make addition of new sinfo fields safer
Add a comment pointing out the use of enum station_info_flags for
all new struct station_info fields. In addition, memset the sinfo
buffer to zero before use on all paths in the current tree to avoid
leaving uninitialized pointers in the data.
Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'net/wireless')
| -rw-r--r-- | net/wireless/nl80211.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 253e56319d7e..080fd470fdec 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c | |||
| @@ -2267,6 +2267,7 @@ static int nl80211_dump_station(struct sk_buff *skb, | |||
| 2267 | } | 2267 | } |
| 2268 | 2268 | ||
| 2269 | while (1) { | 2269 | while (1) { |
| 2270 | memset(&sinfo, 0, sizeof(sinfo)); | ||
| 2270 | err = dev->ops->dump_station(&dev->wiphy, netdev, sta_idx, | 2271 | err = dev->ops->dump_station(&dev->wiphy, netdev, sta_idx, |
| 2271 | mac_addr, &sinfo); | 2272 | mac_addr, &sinfo); |
| 2272 | if (err == -ENOENT) | 2273 | if (err == -ENOENT) |