diff options
author | Eric Lapuyade <eric.lapuyade@intel.com> | 2012-05-03 08:53:20 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2012-07-09 16:42:05 -0400 |
commit | d3b404453192aa195ccfb2f0d946f880b16f8b1f (patch) | |
tree | ac14a4d471b8593fe500c9785c370e67b3bfef29 /net/nfc | |
parent | a9a741a7e2e6337ae5c030e78827c233c08902a7 (diff) |
NFC: Removed addressed shdlc TODOs
The questions asked in the comments have been answered and addressed.
Signed-off-by: Eric Lapuyade <eric.lapuyade@intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Diffstat (limited to 'net/nfc')
-rw-r--r-- | net/nfc/hci/shdlc.c | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/net/nfc/hci/shdlc.c b/net/nfc/hci/shdlc.c index d7c74d152a72..18d1536df5f6 100644 --- a/net/nfc/hci/shdlc.c +++ b/net/nfc/hci/shdlc.c | |||
@@ -340,15 +340,6 @@ static void nfc_shdlc_connect_complete(struct nfc_shdlc *shdlc, int r) | |||
340 | shdlc->state = SHDLC_CONNECTED; | 340 | shdlc->state = SHDLC_CONNECTED; |
341 | } else { | 341 | } else { |
342 | shdlc->state = SHDLC_DISCONNECTED; | 342 | shdlc->state = SHDLC_DISCONNECTED; |
343 | |||
344 | /* | ||
345 | * TODO: Could it be possible that there are pending | ||
346 | * executing commands that are waiting for connect to complete | ||
347 | * before they can be carried? As connect is a blocking | ||
348 | * operation, it would require that the userspace process can | ||
349 | * send commands on the same device from a second thread before | ||
350 | * the device is up. I don't think that is possible, is it? | ||
351 | */ | ||
352 | } | 343 | } |
353 | 344 | ||
354 | shdlc->connect_result = r; | 345 | shdlc->connect_result = r; |
@@ -926,8 +917,6 @@ void nfc_shdlc_free(struct nfc_shdlc *shdlc) | |||
926 | { | 917 | { |
927 | pr_debug("\n"); | 918 | pr_debug("\n"); |
928 | 919 | ||
929 | /* TODO: Check that this cannot be called while still in use */ | ||
930 | |||
931 | nfc_hci_unregister_device(shdlc->hdev); | 920 | nfc_hci_unregister_device(shdlc->hdev); |
932 | nfc_hci_free_device(shdlc->hdev); | 921 | nfc_hci_free_device(shdlc->hdev); |
933 | 922 | ||