diff options
author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2013-04-08 22:07:19 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2013-04-08 22:49:23 -0400 |
commit | c802d759623acbd6e1ee9fbdabae89159a513913 (patch) | |
tree | 627b07cea49875faf40e508ce4392242a26d74a5 /net/netrom | |
parent | 65d8013cbdc661f9cb7645148de1facfe3d0c88a (diff) |
netrom: fix invalid use of sizeof in nr_recvmsg()
sizeof() when applied to a pointer typed expression gives the size of the
pointer, not that of the pointed data.
Introduced by commit 3ce5ef(netrom: fix info leak via msg_name in nr_recvmsg)
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom')
-rw-r--r-- | net/netrom/af_netrom.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 7fcb307dea47..103bd704b5fc 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c | |||
@@ -1173,7 +1173,7 @@ static int nr_recvmsg(struct kiocb *iocb, struct socket *sock, | |||
1173 | } | 1173 | } |
1174 | 1174 | ||
1175 | if (sax != NULL) { | 1175 | if (sax != NULL) { |
1176 | memset(sax, 0, sizeof(sax)); | 1176 | memset(sax, 0, sizeof(*sax)); |
1177 | sax->sax25_family = AF_NETROM; | 1177 | sax->sax25_family = AF_NETROM; |
1178 | skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call, | 1178 | skb_copy_from_linear_data_offset(skb, 7, sax->sax25_call.ax25_call, |
1179 | AX25_ADDR_LEN); | 1179 | AX25_ADDR_LEN); |