diff options
author | Bob Copeland <me@bobcopeland.com> | 2013-04-18 18:26:49 -0400 |
---|---|---|
committer | Johannes Berg <johannes.berg@intel.com> | 2013-04-22 09:40:39 -0400 |
commit | 8ceb59557bdc373e532b87d4142ce27e04218f0e (patch) | |
tree | 95fab44394b51719702afc7bbe22789043be5f65 /net/mac80211/iface.c | |
parent | 908f8d07e9774c2476e0683f6a0ce50562a2da45 (diff) |
mac80211: use synchronize_rcu() with rcu_barrier()
The RCU docs used to state that rcu_barrier() included a wait
for an RCU grace period; however the comments for rcu_barrier()
as of commit f0a0e6f... "rcu: Clarify memory-ordering properties
of grace-period primitives" contradict this.
So add back synchronize_{rcu,net}() to where they once were,
but keep the rcu_barrier()s for the call_rcu() callbacks.
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Bob Copeland <bob@cozybit.com>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/iface.c')
-rw-r--r-- | net/mac80211/iface.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 146b1320af4e..9daa64ee337e 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c | |||
@@ -839,11 +839,12 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata, | |||
839 | * | 839 | * |
840 | * sta_info_flush_cleanup() requires rcu_barrier() | 840 | * sta_info_flush_cleanup() requires rcu_barrier() |
841 | * first to wait for the station call_rcu() calls | 841 | * first to wait for the station call_rcu() calls |
842 | * to complete, here we need at least sychronize_rcu() | 842 | * to complete, and we also need synchronize_rcu() |
843 | * it to wait for the RX path in case it is using the | 843 | * to wait for the RX path in case it is using the |
844 | * interface and enqueuing frames at this very time on | 844 | * interface and enqueuing frames at this very time on |
845 | * another CPU. | 845 | * another CPU. |
846 | */ | 846 | */ |
847 | synchronize_rcu(); | ||
847 | rcu_barrier(); | 848 | rcu_barrier(); |
848 | sta_info_flush_cleanup(sdata); | 849 | sta_info_flush_cleanup(sdata); |
849 | 850 | ||