diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-12-06 20:10:46 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-12-10 13:31:30 -0500 |
commit | 2062cc20d0a8e370163efccbee555347e17100c0 (patch) | |
tree | d0b6cf63250dbf2edd6c7e18bac1fec9972e1e17 /net/bridge | |
parent | 65d2897c0f1b240420d657f41e561239fa10ba94 (diff) |
bridge: make buffer larger in br_setlink()
We pass IFLA_BRPORT_MAX to nla_parse_nested() so we need
IFLA_BRPORT_MAX + 1 elements. Also Smatch complains that we read past
the end of the array when in br_set_port_flag() when it's called with
IFLA_BRPORT_FAST_LEAVE.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
-rw-r--r-- | net/bridge/br_netlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 850b7d1f3a41..dead9dfe865b 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c | |||
@@ -239,7 +239,7 @@ int br_setlink(struct net_device *dev, struct nlmsghdr *nlh) | |||
239 | struct ifinfomsg *ifm; | 239 | struct ifinfomsg *ifm; |
240 | struct nlattr *protinfo; | 240 | struct nlattr *protinfo; |
241 | struct net_bridge_port *p; | 241 | struct net_bridge_port *p; |
242 | struct nlattr *tb[IFLA_BRPORT_MAX]; | 242 | struct nlattr *tb[IFLA_BRPORT_MAX + 1]; |
243 | int err; | 243 | int err; |
244 | 244 | ||
245 | ifm = nlmsg_data(nlh); | 245 | ifm = nlmsg_data(nlh); |