diff options
| author | Michel Lespinasse <walken@google.com> | 2013-05-07 09:45:56 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-05-07 10:20:16 -0400 |
| commit | a7d2c573ae7fad1b2c877d1a1342fa5bb0d6478c (patch) | |
| tree | 1494f94f71a299d32a3584565a538e5ffdef1163 /lib | |
| parent | 5ede972df1cd9294c82e9515949fd2103be81d7b (diff) | |
rwsem: avoid taking wait_lock in rwsem_down_write_failed
In rwsem_down_write_failed(), if there are active locks after we wake up
(i.e. the lock got stolen from us), skip taking the wait_lock and go
back to sleep immediately.
Signed-off-by: Michel Lespinasse <walken@google.com>
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
Acked-by: Davidlohr Bueso <davidlohr.bueso@hp.com>
Acked-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/rwsem.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/lib/rwsem.c b/lib/rwsem.c index 64c2dc007be2..edf3d9ca670e 100644 --- a/lib/rwsem.c +++ b/lib/rwsem.c | |||
| @@ -214,8 +214,8 @@ struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem) | |||
| 214 | sem = __rwsem_do_wake(sem, RWSEM_WAKE_READ_OWNED); | 214 | sem = __rwsem_do_wake(sem, RWSEM_WAKE_READ_OWNED); |
| 215 | 215 | ||
| 216 | /* wait until we successfully acquire the lock */ | 216 | /* wait until we successfully acquire the lock */ |
| 217 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); | ||
| 217 | while (true) { | 218 | while (true) { |
| 218 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); | ||
| 219 | 219 | ||
| 220 | /* Try acquiring the write lock. */ | 220 | /* Try acquiring the write lock. */ |
| 221 | count = RWSEM_ACTIVE_WRITE_BIAS; | 221 | count = RWSEM_ACTIVE_WRITE_BIAS; |
| @@ -226,7 +226,13 @@ struct rw_semaphore __sched *rwsem_down_write_failed(struct rw_semaphore *sem) | |||
| 226 | break; | 226 | break; |
| 227 | 227 | ||
| 228 | raw_spin_unlock_irq(&sem->wait_lock); | 228 | raw_spin_unlock_irq(&sem->wait_lock); |
| 229 | schedule(); | 229 | |
| 230 | /* Block until there are no active lockers. */ | ||
| 231 | do { | ||
| 232 | schedule(); | ||
| 233 | set_task_state(tsk, TASK_UNINTERRUPTIBLE); | ||
| 234 | } while (sem->count & RWSEM_ACTIVE_MASK); | ||
| 235 | |||
| 230 | raw_spin_lock_irq(&sem->wait_lock); | 236 | raw_spin_lock_irq(&sem->wait_lock); |
| 231 | } | 237 | } |
| 232 | 238 | ||
