diff options
author | Kees Cook <keescook@chromium.org> | 2012-10-19 21:45:53 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-10-19 21:51:17 -0400 |
commit | 31fd84b95eb211d5db460a1dda85e004800a7b52 (patch) | |
tree | ff1a3c181f16696c4b2d1059bd9f70b6d5cbda13 /kernel | |
parent | 8c1bee685e6e9e18ed28cba32f0cec0d2e4effee (diff) |
use clamp_t in UNAME26 fix
The min/max call needed to have explicit types on some architectures
(e.g. mn10300). Use clamp_t instead to avoid the warning:
kernel/sys.c: In function 'override_release':
kernel/sys.c:1287:10: warning: comparison of distinct pointer types lacks a cast [enabled by default]
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sys.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sys.c b/kernel/sys.c index 01865c6fb6a0..e6e0ece5f6a0 100644 --- a/kernel/sys.c +++ b/kernel/sys.c | |||
@@ -1284,7 +1284,7 @@ static int override_release(char __user *release, size_t len) | |||
1284 | rest++; | 1284 | rest++; |
1285 | } | 1285 | } |
1286 | v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 40; | 1286 | v = ((LINUX_VERSION_CODE >> 8) & 0xff) + 40; |
1287 | copy = min(sizeof(buf), max_t(size_t, 1, len)); | 1287 | copy = clamp_t(size_t, len, 1, sizeof(buf)); |
1288 | copy = scnprintf(buf, copy, "2.6.%u%s", v, rest); | 1288 | copy = scnprintf(buf, copy, "2.6.%u%s", v, rest); |
1289 | ret = copy_to_user(release, buf, copy + 1); | 1289 | ret = copy_to_user(release, buf, copy + 1); |
1290 | } | 1290 | } |