diff options
| author | Miao Xie <miaox@cn.fujitsu.com> | 2013-12-16 02:20:01 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-01-09 15:24:20 -0500 |
| commit | 885154cee87db097b01ae35d9ae9ee5feabeb9d7 (patch) | |
| tree | f134c73cdf203a4d62f7c0a42d714b53b94c2f02 /kernel/trace | |
| parent | 480da400c39d5c4398765623c7bb007a359a059f (diff) | |
ftrace: Initialize the ftrace profiler for each possible cpu
commit c4602c1c818bd6626178d6d3fcc152d9f2f48ac0 upstream.
Ftrace currently initializes only the online CPUs. This implementation has
two problems:
- If we online a CPU after we enable the function profile, and then run the
test, we will lose the trace information on that CPU.
Steps to reproduce:
# echo 0 > /sys/devices/system/cpu/cpu1/online
# cd <debugfs>/tracing/
# echo <some function name> >> set_ftrace_filter
# echo 1 > function_profile_enabled
# echo 1 > /sys/devices/system/cpu/cpu1/online
# run test
- If we offline a CPU before we enable the function profile, we will not clear
the trace information when we enable the function profile. It will trouble
the users.
Steps to reproduce:
# cd <debugfs>/tracing/
# echo <some function name> >> set_ftrace_filter
# echo 1 > function_profile_enabled
# run test
# cat trace_stat/function*
# echo 0 > /sys/devices/system/cpu/cpu1/online
# echo 0 > function_profile_enabled
# echo 1 > function_profile_enabled
# cat trace_stat/function*
# run test
# cat trace_stat/function*
So it is better that we initialize the ftrace profiler for each possible cpu
every time we enable the function profile instead of just the online ones.
Link: http://lkml.kernel.org/r/1387178401-10619-1-git-send-email-miaox@cn.fujitsu.com
Signed-off-by: Miao Xie <miaox@cn.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'kernel/trace')
| -rw-r--r-- | kernel/trace/ftrace.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 331c102177a6..d0c5c3f0d939 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -750,7 +750,7 @@ static int ftrace_profile_init(void) | |||
| 750 | int cpu; | 750 | int cpu; |
| 751 | int ret = 0; | 751 | int ret = 0; |
| 752 | 752 | ||
| 753 | for_each_online_cpu(cpu) { | 753 | for_each_possible_cpu(cpu) { |
| 754 | ret = ftrace_profile_init_cpu(cpu); | 754 | ret = ftrace_profile_init_cpu(cpu); |
| 755 | if (ret) | 755 | if (ret) |
| 756 | break; | 756 | break; |
