libfcoe, fcoe, bnx2fc: Add new fcoe control interface

This patch does a few things.

1) Makes /sys/bus/fcoe/ctlr_{create,destroy} interfaces.
   These interfaces take an <ifname> and will either
   create an FCoE Controller or destroy an FCoE
   Controller depending on which file is written to.

   The new FCoE Controller will start in a DISABLED
   state and will not do discovery or login until it
   is ENABLED. This pause will allow us to configure
   the FCoE Controller before enabling it.

2) Makes the 'mode' attribute of a fcoe_ctlr_device
   writale. This allows the user to configure the mode
   in which the FCoE Controller will start in when it
   is ENABLED.

   Possible modes are 'Fabric', or 'VN2VN'.

   The default mode for a fcoe_ctlr{,_device} is 'Fabric'.
   Drivers must implement the set_fcoe_ctlr_mode routine
   to support this feature.

   libfcoe offers an exported routine to set a FCoE
   Controller's mode. The mode can only be changed
   when the FCoE Controller is DISABLED.

   This patch also removes the get_fcoe_ctlr_mode pointer
   in the fcoe_sysfs function template, the code in
   fcoe_ctlr.c to get the mode and the assignment of
   the fcoe_sysfs function pointer to the fcoe_ctlr.c
   implementation (in fcoe and bnx2fc). fcoe_sysfs can
   return that value for the mode without consulting the
   LLD.

3) Make a 'enabled' attribute of a fcoe_ctlr_device. On a
   read, fcoe_sysfs will return the attribute's value. On
   a write, fcoe_sysfs will call the LLD (if there is a
   callback) to notifiy that the enalbed state has changed.

This patch maintains the old FCoE control interfaces as
module parameters, but it adds comments pointing out that
the old interfaces are deprecated.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>

2 files changed, 24 insertions, 3 deletions

diff --git a/include/scsi/fcoe_sysfs.h b/include/scsi/fcoe_sysfs.h
index 604cb9bb3e76..7e2314870341 100644
--- a/include/scsi/fcoe_sysfs.h
+++ b/include/scsi/fcoe_sysfs.h
@@ -34,7 +34,8 @@ struct fcoe_sysfs_function_template {
         void (*get_fcoe_ctlr_symb_err)(struct fcoe_ctlr_device *);
         void (*get_fcoe_ctlr_err_block)(struct fcoe_ctlr_device *);
         void (*get_fcoe_ctlr_fcs_error)(struct fcoe_ctlr_device *);
-        void (*get_fcoe_ctlr_mode)(struct fcoe_ctlr_device *);
+        void (*set_fcoe_ctlr_mode)(struct fcoe_ctlr_device *);
+        int  (*set_fcoe_ctlr_enabled)(struct fcoe_ctlr_device *);
         void (*get_fcoe_fcf_selected)(struct fcoe_fcf_device *);
         void (*get_fcoe_fcf_vlan_id)(struct fcoe_fcf_device *);
 };
@@ -48,6 +49,12 @@ enum fip_conn_type {
         FIP_CONN_TYPE_VN2VN,
 };
 
+enum ctlr_enabled_state {
+        FCOE_CTLR_ENABLED,
+        FCOE_CTLR_DISABLED,
+        FCOE_CTLR_UNUSED,
+};
+
 struct fcoe_ctlr_device {
         u32                             id;
 
@@ -64,6 +71,8 @@ struct fcoe_ctlr_device {
         int                             fcf_dev_loss_tmo;
         enum fip_conn_type              mode;
 
+        enum ctlr_enabled_state         enabled;
+
         /* expected in host order for displaying */
         struct fcoe_fc_els_lesb         lesb;
 };
diff --git a/include/scsi/libfcoe.h b/include/scsi/libfcoe.h
index 8742d853a3b8..6add37ac8609 100644
--- a/include/scsi/libfcoe.h
+++ b/include/scsi/libfcoe.h
@@ -289,8 +289,11 @@ static inline bool is_fip_mode(struct fcoe_ctlr *fip)
  * @attached:   whether this transport is already attached
  * @list:       list linkage to all attached transports
  * @match:      handler to allow the transport driver to match up a given netdev
+ * @alloc:      handler to allocate per-instance FCoE structures
+ *              (no discovery or login)
  * @create:     handler to sysfs entry of create for FCoE instances
- * @destroy:    handler to sysfs entry of destroy for FCoE instances
+ * @destroy:    handler to delete per-instance FCoE structures
+ *              (frees all memory)
  * @enable:     handler to sysfs entry of enable for FCoE instances
  * @disable:    handler to sysfs entry of disable for FCoE instances
  */
@@ -299,6 +302,7 @@ struct fcoe_transport {
         bool attached;
         struct list_head list;
         bool (*match) (struct net_device *device);
+        int (*alloc) (struct net_device *device);
         int (*create) (struct net_device *device, enum fip_state fip_mode);
         int (*destroy) (struct net_device *device);
         int (*enable) (struct net_device *device);
@@ -356,7 +360,7 @@ int fcoe_get_paged_crc_eof(struct sk_buff *skb, int tlen,
 
 /* FCoE Sysfs helpers */
 void fcoe_fcf_get_selected(struct fcoe_fcf_device *);
-void fcoe_ctlr_get_fip_mode(struct fcoe_ctlr_device *);
+void fcoe_ctlr_set_fip_mode(struct fcoe_ctlr_device *);
 
 /**
  * struct netdev_list
@@ -372,4 +376,12 @@ struct fcoe_netdev_mapping {
 int fcoe_transport_attach(struct fcoe_transport *ft);
 int fcoe_transport_detach(struct fcoe_transport *ft);
 
+/* sysfs store handler for ctrl_control interface */
+ssize_t fcoe_ctlr_create_store(struct bus_type *bus,
+                               const char *buf, size_t count);
+ssize_t fcoe_ctlr_destroy_store(struct bus_type *bus,
+                                const char *buf, size_t count);
+
 #endif /* _LIBFCOE_H */
+
+