diff options
author | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-05 22:11:03 -0400 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2013-05-07 02:16:31 -0400 |
commit | 4385bab128911df14ab25f0b5ae1a48d7b53dd94 (patch) | |
tree | d8c6f5557f09ebdf294eaba7eba01a140f8da78a /fs/nfs | |
parent | db2a144bedd58b3dcf19950c2f476c58c9f39d18 (diff) |
make blkdev_put() return void
same story as with the previous patches - note that return
value of blkdev_close() is lost, since there's nowhere the
caller (__fput()) could return it to.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'fs/nfs')
-rw-r--r-- | fs/nfs/blocklayout/blocklayout.h | 2 | ||||
-rw-r--r-- | fs/nfs/blocklayout/blocklayoutdev.c | 4 | ||||
-rw-r--r-- | fs/nfs/blocklayout/blocklayoutdm.c | 8 |
3 files changed, 4 insertions, 10 deletions
diff --git a/fs/nfs/blocklayout/blocklayout.h b/fs/nfs/blocklayout/blocklayout.h index f4891bde8851..8485978993e8 100644 --- a/fs/nfs/blocklayout/blocklayout.h +++ b/fs/nfs/blocklayout/blocklayout.h | |||
@@ -173,7 +173,7 @@ struct bl_msg_hdr { | |||
173 | /* blocklayoutdev.c */ | 173 | /* blocklayoutdev.c */ |
174 | ssize_t bl_pipe_downcall(struct file *, const char __user *, size_t); | 174 | ssize_t bl_pipe_downcall(struct file *, const char __user *, size_t); |
175 | void bl_pipe_destroy_msg(struct rpc_pipe_msg *); | 175 | void bl_pipe_destroy_msg(struct rpc_pipe_msg *); |
176 | int nfs4_blkdev_put(struct block_device *bdev); | 176 | void nfs4_blkdev_put(struct block_device *bdev); |
177 | struct pnfs_block_dev *nfs4_blk_decode_device(struct nfs_server *server, | 177 | struct pnfs_block_dev *nfs4_blk_decode_device(struct nfs_server *server, |
178 | struct pnfs_device *dev); | 178 | struct pnfs_device *dev); |
179 | int nfs4_blk_process_layoutget(struct pnfs_layout_hdr *lo, | 179 | int nfs4_blk_process_layoutget(struct pnfs_layout_hdr *lo, |
diff --git a/fs/nfs/blocklayout/blocklayoutdev.c b/fs/nfs/blocklayout/blocklayoutdev.c index a86c5bdad9e3..04303b5c9361 100644 --- a/fs/nfs/blocklayout/blocklayoutdev.c +++ b/fs/nfs/blocklayout/blocklayoutdev.c | |||
@@ -56,11 +56,11 @@ static int decode_sector_number(__be32 **rp, sector_t *sp) | |||
56 | /* | 56 | /* |
57 | * Release the block device | 57 | * Release the block device |
58 | */ | 58 | */ |
59 | int nfs4_blkdev_put(struct block_device *bdev) | 59 | void nfs4_blkdev_put(struct block_device *bdev) |
60 | { | 60 | { |
61 | dprintk("%s for device %d:%d\n", __func__, MAJOR(bdev->bd_dev), | 61 | dprintk("%s for device %d:%d\n", __func__, MAJOR(bdev->bd_dev), |
62 | MINOR(bdev->bd_dev)); | 62 | MINOR(bdev->bd_dev)); |
63 | return blkdev_put(bdev, FMODE_READ); | 63 | blkdev_put(bdev, FMODE_READ); |
64 | } | 64 | } |
65 | 65 | ||
66 | ssize_t bl_pipe_downcall(struct file *filp, const char __user *src, | 66 | ssize_t bl_pipe_downcall(struct file *filp, const char __user *src, |
diff --git a/fs/nfs/blocklayout/blocklayoutdm.c b/fs/nfs/blocklayout/blocklayoutdm.c index 6fc7b5cae92b..8999cfddd866 100644 --- a/fs/nfs/blocklayout/blocklayoutdm.c +++ b/fs/nfs/blocklayout/blocklayoutdm.c | |||
@@ -88,14 +88,8 @@ out: | |||
88 | */ | 88 | */ |
89 | static void nfs4_blk_metadev_release(struct pnfs_block_dev *bdev) | 89 | static void nfs4_blk_metadev_release(struct pnfs_block_dev *bdev) |
90 | { | 90 | { |
91 | int rv; | ||
92 | |||
93 | dprintk("%s Releasing\n", __func__); | 91 | dprintk("%s Releasing\n", __func__); |
94 | rv = nfs4_blkdev_put(bdev->bm_mdev); | 92 | nfs4_blkdev_put(bdev->bm_mdev); |
95 | if (rv) | ||
96 | printk(KERN_ERR "NFS: %s nfs4_blkdev_put returns %d\n", | ||
97 | __func__, rv); | ||
98 | |||
99 | dev_remove(bdev->net, bdev->bm_mdev->bd_dev); | 93 | dev_remove(bdev->net, bdev->bm_mdev->bd_dev); |
100 | } | 94 | } |
101 | 95 | ||