Merge tag 'nfs-for-3.9-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs

Pull NFS client bugfixes from Trond Myklebust:
 "We've just concluded another Connectathon interoperability testing
  week, and so here are the fixes for the bugs that were discovered:

   - Don't allow NFS silly-renamed files to be deleted
   - Don't start the retransmission timer when out of socket space
   - Fix a couple of pnfs-related Oopses.
   - Fix one more NFSv4 state recovery deadlock
   - Don't loop forever when LAYOUTGET returns NFS4ERR_LAYOUTTRYLATER"

* tag 'nfs-for-3.9-2' of git://git.linux-nfs.org/projects/trondmy/linux-nfs:
  SUNRPC: One line comment fix
  NFSv4.1: LAYOUTGET EDELAY loops timeout to the MDS
  SUNRPC: add call to get configured timeout
  PNFS: set the default DS timeout to 60 seconds
  NFSv4: Fix another open/open_recovery deadlock
  nfs: don't allow nfs_find_actor to match inodes of the wrong type
  NFSv4.1: Hold reference to layout hdr in layoutget
  pnfs: fix resend_to_mds for directio
  SUNRPC: Don't start the retransmission timer when out of socket space
  NFS: Don't allow NFS silly-renamed files to be deleted, no signal

1 files changed, 13 insertions, 8 deletions

diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
index 6be70f622b62..48ac5aad6258 100644
--- a/fs/nfs/pnfs.c
+++ b/fs/nfs/pnfs.c
@@ -1181,7 +1181,7 @@ pnfs_update_layout(struct inode *ino,
         struct nfs_client *clp = server->nfs_client;
         struct pnfs_layout_hdr *lo;
         struct pnfs_layout_segment *lseg = NULL;
-        bool first = false;
+        bool first;
 
         if (!pnfs_enabled_sb(NFS_SERVER(ino)))
                 goto out;
@@ -1215,10 +1215,9 @@ pnfs_update_layout(struct inode *ino,
                 goto out_unlock;
         atomic_inc(&lo->plh_outstanding);
 
-        if (list_empty(&lo->plh_segs))
-                first = true;
-
+        first = list_empty(&lo->plh_layouts) ? true : false;
         spin_unlock(&ino->i_lock);
+
         if (first) {
                 /* The lo must be on the clp list if there is any
                  * chance of a CB_LAYOUTRECALL(FILE) coming in.
@@ -1422,13 +1421,15 @@ EXPORT_SYMBOL_GPL(pnfs_generic_pg_test);
 
 int pnfs_write_done_resend_to_mds(struct inode *inode,
                                 struct list_head *head,
-                                const struct nfs_pgio_completion_ops *compl_ops)
+                                const struct nfs_pgio_completion_ops *compl_ops,
+                                struct nfs_direct_req *dreq)
 {
         struct nfs_pageio_descriptor pgio;
         LIST_HEAD(failed);
 
         /* Resend all requests through the MDS */
         nfs_pageio_init_write(&pgio, inode, FLUSH_STABLE, compl_ops);
+        pgio.pg_dreq = dreq;
         while (!list_empty(head)) {
                 struct nfs_page *req = nfs_list_entry(head->next);
 
@@ -1463,7 +1464,8 @@ static void pnfs_ld_handle_write_error(struct nfs_write_data *data)
         if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags))
                 data->task.tk_status = pnfs_write_done_resend_to_mds(hdr->inode,
                                                         &hdr->pages,
-                                                        hdr->completion_ops);
+                                                        hdr->completion_ops,
+                                                        hdr->dreq);
 }
 
 /*
@@ -1578,13 +1580,15 @@ EXPORT_SYMBOL_GPL(pnfs_generic_pg_writepages);
 
 int pnfs_read_done_resend_to_mds(struct inode *inode,
                                 struct list_head *head,
-                                const struct nfs_pgio_completion_ops *compl_ops)
+                                const struct nfs_pgio_completion_ops *compl_ops,
+                                struct nfs_direct_req *dreq)
 {
         struct nfs_pageio_descriptor pgio;
         LIST_HEAD(failed);
 
         /* Resend all requests through the MDS */
         nfs_pageio_init_read(&pgio, inode, compl_ops);
+        pgio.pg_dreq = dreq;
         while (!list_empty(head)) {
                 struct nfs_page *req = nfs_list_entry(head->next);
 
@@ -1615,7 +1619,8 @@ static void pnfs_ld_handle_read_error(struct nfs_read_data *data)
         if (!test_and_set_bit(NFS_IOHDR_REDO, &hdr->flags))
                 data->task.tk_status = pnfs_read_done_resend_to_mds(hdr->inode,
                                                         &hdr->pages,
-                                                        hdr->completion_ops);
+                                                        hdr->completion_ops,
+                                                        hdr->dreq);
 }
 
 /*