Btrfs: try to only do one btrfs_search_slot in do_setxattr

I've been watching how many btrfs_search_slot()'s we do and I noticed that when
we create a file with selinux enabled we were doing 2 each time we initialize
the security context.  That's because we lookup the xattr first so we can delete
it if we're setting a new value to an existing xattr.  But in the create case we
don't have any xattrs, so it is completely useless to have the extra lookup.  So
re-arrange things so that we only lookup first if we specifically have
XATTR_REPLACE.  That way in the basic case we only do 1 search, and in the more
complicated case we do the normal 2 lookups.  Thanks,

Signed-off-by: Josef Bacik <josef@redhat.com>

1 files changed, 2 insertions, 7 deletions

diff --git a/fs/btrfs/dir-item.c b/fs/btrfs/dir-item.c
index 685f2593c4f0..c360a848d97f 100644
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir-item.c
@@ -89,13 +89,8 @@ int btrfs_insert_xattr_item(struct btrfs_trans_handle *trans,
         data_size = sizeof(*dir_item) + name_len + data_len;
         dir_item = insert_with_overflow(trans, root, path, &key, data_size,
                                         name, name_len);
-        /*
-         * FIXME: at some point we should handle xattr's that are larger than
-         * what we can fit in our leaf.  We set location to NULL b/c we arent
-         * pointing at anything else, that will change if we store the xattr
-         * data in a separate inode.
-         */
-        BUG_ON(IS_ERR(dir_item));
+        if (IS_ERR(dir_item))
+                return PTR_ERR(dir_item);
         memset(&location, 0, sizeof(location));
 
         leaf = path->nodes[0];