diff options
author | Jitendra Kalsaria <jitendra.kalsaria@qlogic.com> | 2012-07-10 10:57:35 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-07-11 02:28:33 -0400 |
commit | a7db9ad1d48b502613f96054f21b107a8403237a (patch) | |
tree | d0322cb39927aa0349e167a7cb96111de47a7270 /drivers | |
parent | 849bcaff80d81d4c4c21935ce989008001447a05 (diff) |
qlge: Added missing case statement to ethtool get_strings.
Missing case was causing ethtool self test to print garbage
value in extra info section.
Signed-off-by: Jitendra Kalsaria <jitendra.kalsaria@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c index 3b0912fb53ab..4c141da51a82 100644 --- a/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c +++ b/drivers/net/ethernet/qlogic/qlge/qlge_ethtool.c | |||
@@ -248,6 +248,9 @@ static char ql_stats_str_arr[][ETH_GSTRING_LEN] = { | |||
248 | static void ql_get_strings(struct net_device *dev, u32 stringset, u8 *buf) | 248 | static void ql_get_strings(struct net_device *dev, u32 stringset, u8 *buf) |
249 | { | 249 | { |
250 | switch (stringset) { | 250 | switch (stringset) { |
251 | case ETH_SS_TEST: | ||
252 | memcpy(buf, *ql_gstrings_test, QLGE_TEST_LEN * ETH_GSTRING_LEN); | ||
253 | break; | ||
251 | case ETH_SS_STATS: | 254 | case ETH_SS_STATS: |
252 | memcpy(buf, ql_stats_str_arr, sizeof(ql_stats_str_arr)); | 255 | memcpy(buf, ql_stats_str_arr, sizeof(ql_stats_str_arr)); |
253 | break; | 256 | break; |
@@ -531,6 +534,8 @@ static void ql_self_test(struct net_device *ndev, | |||
531 | { | 534 | { |
532 | struct ql_adapter *qdev = netdev_priv(ndev); | 535 | struct ql_adapter *qdev = netdev_priv(ndev); |
533 | 536 | ||
537 | memset(data, 0, sizeof(u64) * QLGE_TEST_LEN); | ||
538 | |||
534 | if (netif_running(ndev)) { | 539 | if (netif_running(ndev)) { |
535 | set_bit(QL_SELFTEST, &qdev->flags); | 540 | set_bit(QL_SELFTEST, &qdev->flags); |
536 | if (eth_test->flags == ETH_TEST_FL_OFFLINE) { | 541 | if (eth_test->flags == ETH_TEST_FL_OFFLINE) { |