aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/video/omap2
diff options
context:
space:
mode:
authorJani Nikula <ext-jani.1.nikula@nokia.com>2010-04-09 06:52:33 -0400
committerTomi Valkeinen <tomi.valkeinen@nokia.com>2010-08-03 08:18:47 -0400
commit2f1e5f606a1330fa9d1d89e88670c3dec7fbe36f (patch)
tree2231dc81153195f33e1d056d3196fdb158e6fe17 /drivers/video/omap2
parent75392bfe3ecc8dc89acf2165a34f8aa039346fb4 (diff)
OMAP: DSS2: Taal: Fix request_irq() error handling
Separate gpio_request() and request_irq() error handling. Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Diffstat (limited to 'drivers/video/omap2')
-rw-r--r--drivers/video/omap2/displays/panel-taal.c14
1 files changed, 7 insertions, 7 deletions
diff --git a/drivers/video/omap2/displays/panel-taal.c b/drivers/video/omap2/displays/panel-taal.c
index 3421be3d85da..af0750e91a5d 100644
--- a/drivers/video/omap2/displays/panel-taal.c
+++ b/drivers/video/omap2/displays/panel-taal.c
@@ -603,7 +603,7 @@ static int taal_probe(struct omap_dss_device *dssdev)
603 if (r) { 603 if (r) {
604 dev_err(&dssdev->dev, "IRQ request failed\n"); 604 dev_err(&dssdev->dev, "IRQ request failed\n");
605 gpio_free(gpio); 605 gpio_free(gpio);
606 goto err3; 606 goto err4;
607 } 607 }
608 608
609 init_completion(&td->te_completion); 609 init_completion(&td->te_completion);
@@ -614,16 +614,16 @@ static int taal_probe(struct omap_dss_device *dssdev)
614 r = sysfs_create_group(&dssdev->dev.kobj, &taal_attr_group); 614 r = sysfs_create_group(&dssdev->dev.kobj, &taal_attr_group);
615 if (r) { 615 if (r) {
616 dev_err(&dssdev->dev, "failed to create sysfs files\n"); 616 dev_err(&dssdev->dev, "failed to create sysfs files\n");
617 goto err4; 617 goto err5;
618 } 618 }
619 619
620 return 0; 620 return 0;
621err5:
622 if (td->use_ext_te)
623 free_irq(gpio_to_irq(dssdev->phy.dsi.ext_te_gpio), dssdev);
621err4: 624err4:
622 if (td->use_ext_te) { 625 if (td->use_ext_te)
623 int gpio = dssdev->phy.dsi.ext_te_gpio; 626 gpio_free(dssdev->phy.dsi.ext_te_gpio);
624 free_irq(gpio_to_irq(gpio), dssdev);
625 gpio_free(gpio);
626 }
627err3: 627err3:
628 backlight_device_unregister(bldev); 628 backlight_device_unregister(bldev);
629err2: 629err2: