diff options
author | Jani Nikula <ext-jani.1.nikula@nokia.com> | 2010-03-18 05:32:05 -0400 |
---|---|---|
committer | Tomi Valkeinen <tomi.valkeinen@nokia.com> | 2010-05-18 07:14:29 -0400 |
commit | 238a41329ca208d1170962260babb428b6e222c2 (patch) | |
tree | c437064cad869fd67fe44c7965893494a6daf407 /drivers/video/omap2/omapfb/omapfb-ioctl.c | |
parent | 508886cf98c81cee73cd75943b3d0039801327ab (diff) |
OMAP: DSS2: fix lock_fb_info() and omapfb_lock() locking order
Framebuffer ioctl processing forces lock_fb_info() -> omapfb_lock()
locking order. Follow that order to avoid possible circular locking
dependency, detected by lockdep.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@nokia.com>
Diffstat (limited to 'drivers/video/omap2/omapfb/omapfb-ioctl.c')
-rw-r--r-- | drivers/video/omap2/omapfb/omapfb-ioctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/video/omap2/omapfb/omapfb-ioctl.c b/drivers/video/omap2/omapfb/omapfb-ioctl.c index 1ffa760b8545..2c0f01c44aab 100644 --- a/drivers/video/omap2/omapfb/omapfb-ioctl.c +++ b/drivers/video/omap2/omapfb/omapfb-ioctl.c | |||
@@ -183,13 +183,13 @@ int omapfb_update_window(struct fb_info *fbi, | |||
183 | struct omapfb2_device *fbdev = ofbi->fbdev; | 183 | struct omapfb2_device *fbdev = ofbi->fbdev; |
184 | int r; | 184 | int r; |
185 | 185 | ||
186 | omapfb_lock(fbdev); | ||
187 | lock_fb_info(fbi); | 186 | lock_fb_info(fbi); |
187 | omapfb_lock(fbdev); | ||
188 | 188 | ||
189 | r = omapfb_update_window_nolock(fbi, x, y, w, h); | 189 | r = omapfb_update_window_nolock(fbi, x, y, w, h); |
190 | 190 | ||
191 | unlock_fb_info(fbi); | ||
192 | omapfb_unlock(fbdev); | 191 | omapfb_unlock(fbdev); |
192 | unlock_fb_info(fbi); | ||
193 | 193 | ||
194 | return r; | 194 | return r; |
195 | } | 195 | } |