diff options
author | Michael Grzeschik <m.grzeschik@pengutronix.de> | 2012-05-11 10:25:50 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-11 19:54:11 -0400 |
commit | b9322252727bc3af6e64b8d75058403edeaddea5 (patch) | |
tree | 0459830fdcb9a86d071fb914348e91b211759ce6 /drivers/usb | |
parent | 551a8ac64e4ea9e9e2b8656ee3bf94c8d0821d41 (diff) |
usb: chipidea: isr_reset_handler fix missing locking
Move spin_lock under the done label, so the
lock will also be pulled in the error paths.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
[rebased on top of the patchset]
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb')
-rw-r--r-- | drivers/usb/chipidea/udc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c index 9133a59450f4..ddd27d3443f8 100644 --- a/drivers/usb/chipidea/udc.c +++ b/drivers/usb/chipidea/udc.c | |||
@@ -645,9 +645,9 @@ __acquires(udc->lock) | |||
645 | if (udc->status == NULL) | 645 | if (udc->status == NULL) |
646 | retval = -ENOMEM; | 646 | retval = -ENOMEM; |
647 | 647 | ||
648 | done: | ||
648 | spin_lock(&udc->lock); | 649 | spin_lock(&udc->lock); |
649 | 650 | ||
650 | done: | ||
651 | if (retval) | 651 | if (retval) |
652 | dev_err(udc->dev, "error: %i\n", retval); | 652 | dev_err(udc->dev, "error: %i\n", retval); |
653 | } | 653 | } |