diff options
author | Johan Hovold <jhovold@gmail.com> | 2011-11-06 13:06:28 -0500 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-11-15 13:33:16 -0500 |
commit | 5833041f1b130e5823a99d03b14538282e5ad345 (patch) | |
tree | 394caf266125dd725d47470a11cb5840040130ec /drivers/usb/serial/mos7840.c | |
parent | 016af7ec49836342c3b35166792c8d73a360571c (diff) |
USB: serial: remove unnecessary reinitialisations of urb->dev
Remove unnecessary reinitialisations of urb->dev before each submission,
which were based on the (no longer valid) assumption that serial->dev
will be set to NULL on close.
Compile-only tested.
Cc: Matthias Bruestle and Harald Welte <support@reiner-sct.com>
Cc: Lonnie Mendez <dignome@gmail.com>
Cc: Peter Berger <pberger@brimson.com>
Cc: Al Borchers <alborchers@steinerpoint.com>
Cc: Support Department <support@connecttech.com>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/serial/mos7840.c')
-rw-r--r-- | drivers/usb/serial/mos7840.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index c72abd524983..55cfd6265b98 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c | |||
@@ -792,8 +792,6 @@ static void mos7840_bulk_in_callback(struct urb *urb) | |||
792 | } | 792 | } |
793 | 793 | ||
794 | 794 | ||
795 | mos7840_port->read_urb->dev = serial->dev; | ||
796 | |||
797 | mos7840_port->read_urb_busy = true; | 795 | mos7840_port->read_urb_busy = true; |
798 | retval = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); | 796 | retval = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); |
799 | 797 | ||
@@ -2058,7 +2056,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty, | |||
2058 | mos7840_set_uart_reg(port, INTERRUPT_ENABLE_REGISTER, Data); | 2056 | mos7840_set_uart_reg(port, INTERRUPT_ENABLE_REGISTER, Data); |
2059 | 2057 | ||
2060 | if (mos7840_port->read_urb_busy == false) { | 2058 | if (mos7840_port->read_urb_busy == false) { |
2061 | mos7840_port->read_urb->dev = serial->dev; | ||
2062 | mos7840_port->read_urb_busy = true; | 2059 | mos7840_port->read_urb_busy = true; |
2063 | status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); | 2060 | status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); |
2064 | if (status) { | 2061 | if (status) { |
@@ -2130,7 +2127,6 @@ static void mos7840_set_termios(struct tty_struct *tty, | |||
2130 | } | 2127 | } |
2131 | 2128 | ||
2132 | if (mos7840_port->read_urb_busy == false) { | 2129 | if (mos7840_port->read_urb_busy == false) { |
2133 | mos7840_port->read_urb->dev = serial->dev; | ||
2134 | mos7840_port->read_urb_busy = true; | 2130 | mos7840_port->read_urb_busy = true; |
2135 | status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); | 2131 | status = usb_submit_urb(mos7840_port->read_urb, GFP_ATOMIC); |
2136 | if (status) { | 2132 | if (status) { |