diff options
author | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-03 19:43:55 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-05-03 19:43:55 -0400 |
commit | 2ec7d459c0b557d7f09d57261052601710479054 (patch) | |
tree | 452abbdea4ca00691ded71034d56eac12320e8f2 /drivers/usb/serial/ch341.c | |
parent | d17a44db94c792ce3e349838286c3e3c0bfbf52f (diff) |
USB: ch341.c: remove dbg() tracing calls
dbg() was used a lot a long time ago to trace code flow. Now that we have
ftrace, this isn't needed at all, so remove these calls.
CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/serial/ch341.c')
-rw-r--r-- | drivers/usb/serial/ch341.c | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/drivers/usb/serial/ch341.c b/drivers/usb/serial/ch341.c index aaab32db31d0..70c46b0426ff 100644 --- a/drivers/usb/serial/ch341.c +++ b/drivers/usb/serial/ch341.c | |||
@@ -125,8 +125,6 @@ static int ch341_set_baudrate(struct usb_device *dev, | |||
125 | unsigned long factor; | 125 | unsigned long factor; |
126 | short divisor; | 126 | short divisor; |
127 | 127 | ||
128 | dbg("ch341_set_baudrate(%d)", priv->baud_rate); | ||
129 | |||
130 | if (!priv->baud_rate) | 128 | if (!priv->baud_rate) |
131 | return -EINVAL; | 129 | return -EINVAL; |
132 | factor = (CH341_BAUDBASE_FACTOR / priv->baud_rate); | 130 | factor = (CH341_BAUDBASE_FACTOR / priv->baud_rate); |
@@ -153,7 +151,6 @@ static int ch341_set_baudrate(struct usb_device *dev, | |||
153 | 151 | ||
154 | static int ch341_set_handshake(struct usb_device *dev, u8 control) | 152 | static int ch341_set_handshake(struct usb_device *dev, u8 control) |
155 | { | 153 | { |
156 | dbg("ch341_set_handshake(0x%02x)", control); | ||
157 | return ch341_control_out(dev, 0xa4, ~control, 0); | 154 | return ch341_control_out(dev, 0xa4, ~control, 0); |
158 | } | 155 | } |
159 | 156 | ||
@@ -164,8 +161,6 @@ static int ch341_get_status(struct usb_device *dev, struct ch341_private *priv) | |||
164 | const unsigned size = 8; | 161 | const unsigned size = 8; |
165 | unsigned long flags; | 162 | unsigned long flags; |
166 | 163 | ||
167 | dbg("ch341_get_status()"); | ||
168 | |||
169 | buffer = kmalloc(size, GFP_KERNEL); | 164 | buffer = kmalloc(size, GFP_KERNEL); |
170 | if (!buffer) | 165 | if (!buffer) |
171 | return -ENOMEM; | 166 | return -ENOMEM; |
@@ -196,8 +191,6 @@ static int ch341_configure(struct usb_device *dev, struct ch341_private *priv) | |||
196 | int r; | 191 | int r; |
197 | const unsigned size = 8; | 192 | const unsigned size = 8; |
198 | 193 | ||
199 | dbg("ch341_configure()"); | ||
200 | |||
201 | buffer = kmalloc(size, GFP_KERNEL); | 194 | buffer = kmalloc(size, GFP_KERNEL); |
202 | if (!buffer) | 195 | if (!buffer) |
203 | return -ENOMEM; | 196 | return -ENOMEM; |
@@ -254,8 +247,6 @@ static int ch341_attach(struct usb_serial *serial) | |||
254 | struct ch341_private *priv; | 247 | struct ch341_private *priv; |
255 | int r; | 248 | int r; |
256 | 249 | ||
257 | dbg("ch341_attach()"); | ||
258 | |||
259 | /* private data */ | 250 | /* private data */ |
260 | priv = kzalloc(sizeof(struct ch341_private), GFP_KERNEL); | 251 | priv = kzalloc(sizeof(struct ch341_private), GFP_KERNEL); |
261 | if (!priv) | 252 | if (!priv) |
@@ -290,7 +281,6 @@ static void ch341_dtr_rts(struct usb_serial_port *port, int on) | |||
290 | struct ch341_private *priv = usb_get_serial_port_data(port); | 281 | struct ch341_private *priv = usb_get_serial_port_data(port); |
291 | unsigned long flags; | 282 | unsigned long flags; |
292 | 283 | ||
293 | dbg("%s - port %d", __func__, port->number); | ||
294 | /* drop DTR and RTS */ | 284 | /* drop DTR and RTS */ |
295 | spin_lock_irqsave(&priv->lock, flags); | 285 | spin_lock_irqsave(&priv->lock, flags); |
296 | if (on) | 286 | if (on) |
@@ -304,8 +294,6 @@ static void ch341_dtr_rts(struct usb_serial_port *port, int on) | |||
304 | 294 | ||
305 | static void ch341_close(struct usb_serial_port *port) | 295 | static void ch341_close(struct usb_serial_port *port) |
306 | { | 296 | { |
307 | dbg("%s - port %d", __func__, port->number); | ||
308 | |||
309 | usb_serial_generic_close(port); | 297 | usb_serial_generic_close(port); |
310 | usb_kill_urb(port->interrupt_in_urb); | 298 | usb_kill_urb(port->interrupt_in_urb); |
311 | } | 299 | } |
@@ -318,8 +306,6 @@ static int ch341_open(struct tty_struct *tty, struct usb_serial_port *port) | |||
318 | struct ch341_private *priv = usb_get_serial_port_data(serial->port[0]); | 306 | struct ch341_private *priv = usb_get_serial_port_data(serial->port[0]); |
319 | int r; | 307 | int r; |
320 | 308 | ||
321 | dbg("ch341_open()"); | ||
322 | |||
323 | priv->baud_rate = DEFAULT_BAUD_RATE; | 309 | priv->baud_rate = DEFAULT_BAUD_RATE; |
324 | 310 | ||
325 | r = ch341_configure(serial->dev, priv); | 311 | r = ch341_configure(serial->dev, priv); |
@@ -358,8 +344,6 @@ static void ch341_set_termios(struct tty_struct *tty, | |||
358 | unsigned baud_rate; | 344 | unsigned baud_rate; |
359 | unsigned long flags; | 345 | unsigned long flags; |
360 | 346 | ||
361 | dbg("ch341_set_termios()"); | ||
362 | |||
363 | baud_rate = tty_get_baud_rate(tty); | 347 | baud_rate = tty_get_baud_rate(tty); |
364 | 348 | ||
365 | priv->baud_rate = baud_rate; | 349 | priv->baud_rate = baud_rate; |
@@ -393,8 +377,6 @@ static void ch341_break_ctl(struct tty_struct *tty, int break_state) | |||
393 | uint16_t reg_contents; | 377 | uint16_t reg_contents; |
394 | uint8_t *break_reg; | 378 | uint8_t *break_reg; |
395 | 379 | ||
396 | dbg("%s()", __func__); | ||
397 | |||
398 | break_reg = kmalloc(2, GFP_KERNEL); | 380 | break_reg = kmalloc(2, GFP_KERNEL); |
399 | if (!break_reg) { | 381 | if (!break_reg) { |
400 | dev_err(&port->dev, "%s - kmalloc failed\n", __func__); | 382 | dev_err(&port->dev, "%s - kmalloc failed\n", __func__); |
@@ -461,8 +443,6 @@ static void ch341_read_int_callback(struct urb *urb) | |||
461 | unsigned int actual_length = urb->actual_length; | 443 | unsigned int actual_length = urb->actual_length; |
462 | int status; | 444 | int status; |
463 | 445 | ||
464 | dbg("%s (%d)", __func__, port->number); | ||
465 | |||
466 | switch (urb->status) { | 446 | switch (urb->status) { |
467 | case 0: | 447 | case 0: |
468 | /* success */ | 448 | /* success */ |
@@ -580,8 +560,6 @@ static int ch341_tiocmget(struct tty_struct *tty) | |||
580 | u8 status; | 560 | u8 status; |
581 | unsigned int result; | 561 | unsigned int result; |
582 | 562 | ||
583 | dbg("%s (%d)", __func__, port->number); | ||
584 | |||
585 | spin_lock_irqsave(&priv->lock, flags); | 563 | spin_lock_irqsave(&priv->lock, flags); |
586 | mcr = priv->line_control; | 564 | mcr = priv->line_control; |
587 | status = priv->line_status; | 565 | status = priv->line_status; |