diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-23 12:25:16 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2009-09-23 12:25:16 -0400 |
| commit | be90a49ca22a95f184d9f32d35b5247b44032849 (patch) | |
| tree | d3c2edc18c003c384366f57901616ac29c80bc27 /drivers/usb/mon | |
| parent | 1f0918d03ff4b5c94540c71ce889672abdbc2f4a (diff) | |
| parent | a87371b477774b290c27bc5cb7f4ccc5379574a9 (diff) | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6
* git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb-2.6: (142 commits)
USB: Fix sysfs paths in documentation
USB: skeleton: fix coding style issues.
USB: O_NONBLOCK in read path of skeleton
USB: make usb-skeleton honor O_NONBLOCK in write path
USB: skel_read really sucks royally
USB: Add hub descriptor update hook for xHCI
USB: xhci: Support USB hubs.
USB: xhci: Set multi-TT field for LS/FS devices under hubs.
USB: xhci: Set route string for all devices.
USB: xhci: Fix command wait list handling.
USB: xhci: Change how xHCI commands are handled.
USB: xhci: Refactor input device context setup.
USB: xhci: Endpoint representation refactoring.
USB: gadget: ether needs to select CRC32
USB: fix USBTMC get_capabilities success handling
USB: fix missing error check in probing
USB: usbfs: add USBDEVFS_URB_BULK_CONTINUATION flag
USB: support for autosuspend in sierra while online
USB: ehci-dbgp,ehci: Allow dbpg to work with suspend/resume
USB: ehci-dbgp,documentation: Documentation updates for ehci-dbgp
...
Diffstat (limited to 'drivers/usb/mon')
| -rw-r--r-- | drivers/usb/mon/Kconfig | 4 | ||||
| -rw-r--r-- | drivers/usb/mon/Makefile | 2 | ||||
| -rw-r--r-- | drivers/usb/mon/mon_bin.c | 12 | ||||
| -rw-r--r-- | drivers/usb/mon/mon_dma.c | 95 | ||||
| -rw-r--r-- | drivers/usb/mon/mon_main.c | 1 | ||||
| -rw-r--r-- | drivers/usb/mon/mon_text.c | 14 | ||||
| -rw-r--r-- | drivers/usb/mon/usb_mon.h | 14 |
7 files changed, 3 insertions, 139 deletions
diff --git a/drivers/usb/mon/Kconfig b/drivers/usb/mon/Kconfig index f28f350cd96a..635745f57fbd 100644 --- a/drivers/usb/mon/Kconfig +++ b/drivers/usb/mon/Kconfig | |||
| @@ -5,11 +5,9 @@ | |||
| 5 | config USB_MON | 5 | config USB_MON |
| 6 | tristate "USB Monitor" | 6 | tristate "USB Monitor" |
| 7 | depends on USB | 7 | depends on USB |
| 8 | default y if USB=y | ||
| 9 | default m if USB=m | ||
| 10 | help | 8 | help |
| 11 | If you select this option, a component which captures the USB traffic | 9 | If you select this option, a component which captures the USB traffic |
| 12 | between peripheral-specific drivers and HC drivers will be built. | 10 | between peripheral-specific drivers and HC drivers will be built. |
| 13 | For more information, see <file:Documentation/usb/usbmon.txt>. | 11 | For more information, see <file:Documentation/usb/usbmon.txt>. |
| 14 | 12 | ||
| 15 | If unsure, say Y (if allowed), otherwise M. | 13 | If unsure, say Y, if allowed, otherwise M. |
diff --git a/drivers/usb/mon/Makefile b/drivers/usb/mon/Makefile index c6516b566731..384b198faa7c 100644 --- a/drivers/usb/mon/Makefile +++ b/drivers/usb/mon/Makefile | |||
| @@ -2,6 +2,6 @@ | |||
| 2 | # Makefile for USB monitor | 2 | # Makefile for USB monitor |
| 3 | # | 3 | # |
| 4 | 4 | ||
| 5 | usbmon-objs := mon_main.o mon_stat.o mon_text.o mon_bin.o mon_dma.o | 5 | usbmon-objs := mon_main.o mon_stat.o mon_text.o mon_bin.o |
| 6 | 6 | ||
| 7 | obj-$(CONFIG_USB_MON) += usbmon.o | 7 | obj-$(CONFIG_USB_MON) += usbmon.o |
diff --git a/drivers/usb/mon/mon_bin.c b/drivers/usb/mon/mon_bin.c index 0f7a30b7d2d1..dfdc43e2e00d 100644 --- a/drivers/usb/mon/mon_bin.c +++ b/drivers/usb/mon/mon_bin.c | |||
| @@ -220,9 +220,8 @@ static void mon_free_buff(struct mon_pgmap *map, int npages); | |||
| 220 | 220 | ||
| 221 | /* | 221 | /* |
| 222 | * This is a "chunked memcpy". It does not manipulate any counters. | 222 | * This is a "chunked memcpy". It does not manipulate any counters. |
| 223 | * But it returns the new offset for repeated application. | ||
| 224 | */ | 223 | */ |
| 225 | unsigned int mon_copy_to_buff(const struct mon_reader_bin *this, | 224 | static void mon_copy_to_buff(const struct mon_reader_bin *this, |
| 226 | unsigned int off, const unsigned char *from, unsigned int length) | 225 | unsigned int off, const unsigned char *from, unsigned int length) |
| 227 | { | 226 | { |
| 228 | unsigned int step_len; | 227 | unsigned int step_len; |
| @@ -247,7 +246,6 @@ unsigned int mon_copy_to_buff(const struct mon_reader_bin *this, | |||
| 247 | from += step_len; | 246 | from += step_len; |
| 248 | length -= step_len; | 247 | length -= step_len; |
| 249 | } | 248 | } |
| 250 | return off; | ||
| 251 | } | 249 | } |
| 252 | 250 | ||
| 253 | /* | 251 | /* |
| @@ -400,15 +398,8 @@ static char mon_bin_get_data(const struct mon_reader_bin *rp, | |||
| 400 | unsigned int offset, struct urb *urb, unsigned int length) | 398 | unsigned int offset, struct urb *urb, unsigned int length) |
| 401 | { | 399 | { |
| 402 | 400 | ||
| 403 | if (urb->dev->bus->uses_dma && | ||
| 404 | (urb->transfer_flags & URB_NO_TRANSFER_DMA_MAP)) { | ||
| 405 | mon_dmapeek_vec(rp, offset, urb->transfer_dma, length); | ||
| 406 | return 0; | ||
| 407 | } | ||
| 408 | |||
| 409 | if (urb->transfer_buffer == NULL) | 401 | if (urb->transfer_buffer == NULL) |
| 410 | return 'Z'; | 402 | return 'Z'; |
| 411 | |||
| 412 | mon_copy_to_buff(rp, offset, urb->transfer_buffer, length); | 403 | mon_copy_to_buff(rp, offset, urb->transfer_buffer, length); |
| 413 | return 0; | 404 | return 0; |
| 414 | } | 405 | } |
| @@ -635,7 +626,6 @@ static int mon_bin_open(struct inode *inode, struct file *file) | |||
| 635 | spin_lock_init(&rp->b_lock); | 626 | spin_lock_init(&rp->b_lock); |
| 636 | init_waitqueue_head(&rp->b_wait); | 627 | init_waitqueue_head(&rp->b_wait); |
| 637 | mutex_init(&rp->fetch_lock); | 628 | mutex_init(&rp->fetch_lock); |
| 638 | |||
| 639 | rp->b_size = BUFF_DFL; | 629 | rp->b_size = BUFF_DFL; |
| 640 | 630 | ||
| 641 | size = sizeof(struct mon_pgmap) * (rp->b_size/CHUNK_SIZE); | 631 | size = sizeof(struct mon_pgmap) * (rp->b_size/CHUNK_SIZE); |
diff --git a/drivers/usb/mon/mon_dma.c b/drivers/usb/mon/mon_dma.c deleted file mode 100644 index 140cc80bd2b1..000000000000 --- a/drivers/usb/mon/mon_dma.c +++ /dev/null | |||
| @@ -1,95 +0,0 @@ | |||
| 1 | /* | ||
| 2 | * The USB Monitor, inspired by Dave Harding's USBMon. | ||
| 3 | * | ||
| 4 | * mon_dma.c: Library which snoops on DMA areas. | ||
| 5 | * | ||
| 6 | * Copyright (C) 2005 Pete Zaitcev (zaitcev@redhat.com) | ||
| 7 | */ | ||
| 8 | #include <linux/kernel.h> | ||
| 9 | #include <linux/list.h> | ||
| 10 | #include <linux/highmem.h> | ||
| 11 | #include <asm/page.h> | ||
| 12 | |||
| 13 | #include <linux/usb.h> /* Only needed for declarations in usb_mon.h */ | ||
| 14 | #include "usb_mon.h" | ||
| 15 | |||
| 16 | /* | ||
| 17 | * PC-compatibles, are, fortunately, sufficiently cache-coherent for this. | ||
| 18 | */ | ||
| 19 | #if defined(__i386__) || defined(__x86_64__) /* CONFIG_ARCH_I386 doesn't exit */ | ||
| 20 | #define MON_HAS_UNMAP 1 | ||
| 21 | |||
| 22 | #define phys_to_page(phys) pfn_to_page((phys) >> PAGE_SHIFT) | ||
| 23 | |||
| 24 | char mon_dmapeek(unsigned char *dst, dma_addr_t dma_addr, int len) | ||
| 25 | { | ||
| 26 | struct page *pg; | ||
| 27 | unsigned long flags; | ||
| 28 | unsigned char *map; | ||
| 29 | unsigned char *ptr; | ||
| 30 | |||
| 31 | /* | ||
| 32 | * On i386, a DMA handle is the "physical" address of a page. | ||
| 33 | * In other words, the bus address is equal to physical address. | ||
| 34 | * There is no IOMMU. | ||
| 35 | */ | ||
| 36 | pg = phys_to_page(dma_addr); | ||
| 37 | |||
| 38 | /* | ||
| 39 | * We are called from hardware IRQs in case of callbacks. | ||
| 40 | * But we can be called from softirq or process context in case | ||
| 41 | * of submissions. In such case, we need to protect KM_IRQ0. | ||
| 42 | */ | ||
| 43 | local_irq_save(flags); | ||
| 44 | map = kmap_atomic(pg, KM_IRQ0); | ||
| 45 | ptr = map + (dma_addr & (PAGE_SIZE-1)); | ||
| 46 | memcpy(dst, ptr, len); | ||
| 47 | kunmap_atomic(map, KM_IRQ0); | ||
| 48 | local_irq_restore(flags); | ||
| 49 | return 0; | ||
| 50 | } | ||
| 51 | |||
| 52 | void mon_dmapeek_vec(const struct mon_reader_bin *rp, | ||
| 53 | unsigned int offset, dma_addr_t dma_addr, unsigned int length) | ||
| 54 | { | ||
| 55 | unsigned long flags; | ||
| 56 | unsigned int step_len; | ||
| 57 | struct page *pg; | ||
| 58 | unsigned char *map; | ||
| 59 | unsigned long page_off, page_len; | ||
| 60 | |||
| 61 | local_irq_save(flags); | ||
| 62 | while (length) { | ||
| 63 | /* compute number of bytes we are going to copy in this page */ | ||
| 64 | step_len = length; | ||
| 65 | page_off = dma_addr & (PAGE_SIZE-1); | ||
| 66 | page_len = PAGE_SIZE - page_off; | ||
| 67 | if (page_len < step_len) | ||
| 68 | step_len = page_len; | ||
| 69 | |||
| 70 | /* copy data and advance pointers */ | ||
| 71 | pg = phys_to_page(dma_addr); | ||
| 72 | map = kmap_atomic(pg, KM_IRQ0); | ||
| 73 | offset = mon_copy_to_buff(rp, offset, map + page_off, step_len); | ||
| 74 | kunmap_atomic(map, KM_IRQ0); | ||
| 75 | dma_addr += step_len; | ||
| 76 | length -= step_len; | ||
| 77 | } | ||
| 78 | local_irq_restore(flags); | ||
| 79 | } | ||
| 80 | |||
| 81 | #endif /* __i386__ */ | ||
| 82 | |||
| 83 | #ifndef MON_HAS_UNMAP | ||
| 84 | char mon_dmapeek(unsigned char *dst, dma_addr_t dma_addr, int len) | ||
| 85 | { | ||
| 86 | return 'D'; | ||
| 87 | } | ||
| 88 | |||
| 89 | void mon_dmapeek_vec(const struct mon_reader_bin *rp, | ||
| 90 | unsigned int offset, dma_addr_t dma_addr, unsigned int length) | ||
| 91 | { | ||
| 92 | ; | ||
| 93 | } | ||
| 94 | |||
| 95 | #endif /* MON_HAS_UNMAP */ | ||
diff --git a/drivers/usb/mon/mon_main.c b/drivers/usb/mon/mon_main.c index 5e0ab4201c00..e0c2db3b767b 100644 --- a/drivers/usb/mon/mon_main.c +++ b/drivers/usb/mon/mon_main.c | |||
| @@ -361,7 +361,6 @@ static int __init mon_init(void) | |||
| 361 | } | 361 | } |
| 362 | // MOD_INC_USE_COUNT(which_module?); | 362 | // MOD_INC_USE_COUNT(which_module?); |
| 363 | 363 | ||
| 364 | |||
| 365 | mutex_lock(&usb_bus_list_lock); | 364 | mutex_lock(&usb_bus_list_lock); |
| 366 | list_for_each_entry (ubus, &usb_bus_list, bus_list) { | 365 | list_for_each_entry (ubus, &usb_bus_list, bus_list) { |
| 367 | mon_bus_init(ubus); | 366 | mon_bus_init(ubus); |
diff --git a/drivers/usb/mon/mon_text.c b/drivers/usb/mon/mon_text.c index a7eb4c99342c..9f1a9227ebe6 100644 --- a/drivers/usb/mon/mon_text.c +++ b/drivers/usb/mon/mon_text.c | |||
| @@ -150,20 +150,6 @@ static inline char mon_text_get_data(struct mon_event_text *ep, struct urb *urb, | |||
| 150 | return '>'; | 150 | return '>'; |
| 151 | } | 151 | } |
| 152 | 152 | ||
| 153 | /* | ||
| 154 | * The check to see if it's safe to poke at data has an enormous | ||
| 155 | * number of corner cases, but it seems that the following is | ||
| 156 | * more or less safe. | ||
| 157 | * | ||
| 158 | * We do not even try to look at transfer_buffer, because it can | ||
| 159 | * contain non-NULL garbage in case the upper level promised to | ||
| 160 | * set DMA for the HCD. | ||
| 161 | */ | ||
| 162 | if (urb->dev->bus->uses_dma && | ||
| 163 | (urb->transfer_flags & URB_NO_TRANSFER_DMA_MAP)) { | ||
| 164 | return mon_dmapeek(ep->data, urb->transfer_dma, len); | ||
| 165 | } | ||
| 166 | |||
| 167 | if (urb->transfer_buffer == NULL) | 153 | if (urb->transfer_buffer == NULL) |
| 168 | return 'Z'; /* '0' would be not as pretty. */ | 154 | return 'Z'; /* '0' would be not as pretty. */ |
| 169 | 155 | ||
diff --git a/drivers/usb/mon/usb_mon.h b/drivers/usb/mon/usb_mon.h index f5d84ff8c101..df9a4df342c7 100644 --- a/drivers/usb/mon/usb_mon.h +++ b/drivers/usb/mon/usb_mon.h | |||
| @@ -65,20 +65,6 @@ int __init mon_bin_init(void); | |||
| 65 | void mon_bin_exit(void); | 65 | void mon_bin_exit(void); |
| 66 | 66 | ||
| 67 | /* | 67 | /* |
| 68 | * DMA interface. | ||
| 69 | * | ||
| 70 | * XXX The vectored side needs a serious re-thinking. Abstracting vectors, | ||
| 71 | * like in Paolo's original patch, produces a double pkmap. We need an idea. | ||
| 72 | */ | ||
| 73 | extern char mon_dmapeek(unsigned char *dst, dma_addr_t dma_addr, int len); | ||
| 74 | |||
| 75 | struct mon_reader_bin; | ||
| 76 | extern void mon_dmapeek_vec(const struct mon_reader_bin *rp, | ||
| 77 | unsigned int offset, dma_addr_t dma_addr, unsigned int len); | ||
| 78 | extern unsigned int mon_copy_to_buff(const struct mon_reader_bin *rp, | ||
| 79 | unsigned int offset, const unsigned char *from, unsigned int len); | ||
| 80 | |||
| 81 | /* | ||
| 82 | */ | 68 | */ |
| 83 | extern struct mutex mon_lock; | 69 | extern struct mutex mon_lock; |
| 84 | 70 | ||
