diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2011-10-18 02:24:36 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-18 16:51:35 -0400 |
commit | 0889551267e7b6b4d27dc9f726f3d0cb0d976105 (patch) | |
tree | 8362482d71e09574db4de0a140984400465659e7 /drivers/usb/gadget/f_midi.c | |
parent | 273d23574f9dacd9c63c80e7d63639a669aad441 (diff) |
USB: gadget: midi: fix range check in f_midi_out_open()
! has higher precedence than >= and since neither 0 nor 1 are greater
than 8 the condition is always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/gadget/f_midi.c')
-rw-r--r-- | drivers/usb/gadget/f_midi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c index 44858dc074d3..ef1bc7a174ef 100644 --- a/drivers/usb/gadget/f_midi.c +++ b/drivers/usb/gadget/f_midi.c | |||
@@ -644,7 +644,7 @@ static int f_midi_out_open(struct snd_rawmidi_substream *substream) | |||
644 | { | 644 | { |
645 | struct f_midi *midi = substream->rmidi->private_data; | 645 | struct f_midi *midi = substream->rmidi->private_data; |
646 | 646 | ||
647 | if (!substream->number >= MAX_PORTS) | 647 | if (substream->number >= MAX_PORTS) |
648 | return -EINVAL; | 648 | return -EINVAL; |
649 | 649 | ||
650 | VDBG(midi, "%s()\n", __func__); | 650 | VDBG(midi, "%s()\n", __func__); |