diff options
author | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-06-03 23:59:19 -0400 |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2011-07-22 05:37:44 -0400 |
commit | 695434e1cbd57f404110bf4ab187a5127ffd79bb (patch) | |
tree | 7d014011669e28498cf3fd210427373992031735 /drivers/target | |
parent | 35462975b2b197b990fedbb74b81f9bea9d344cb (diff) |
target: Add transport_handle_cdb_direct optimization
This patch adds a transport_handle_cdb_direct() optimization for mapping
and queueing tasks directly from within fabric processing context by calling
the newly exported transport_generic_new_cmd(). This currently expects to
be called from process context only, and will fail if called within interrupt
context.
This patch also leaves transport_generic_handle_cdb() unmodified for the
moment to function as expected with existing tcm_fc and ib_srpt fabrics,
and will be removed once these have been converted and tested with v4.1
code using transport_handle_cdb_direct().
Based on Andy's original patch here:
[PATCH 39/42] target: Call transport_new_cmd instead of adding to cmd queue
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target')
-rw-r--r-- | drivers/target/target_core_transport.c | 24 |
1 files changed, 24 insertions, 0 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index d42a98e4725b..1ae6eb7a621b 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c | |||
@@ -1842,12 +1842,36 @@ int transport_generic_handle_cdb( | |||
1842 | printk(KERN_ERR "cmd->se_lun is NULL\n"); | 1842 | printk(KERN_ERR "cmd->se_lun is NULL\n"); |
1843 | return -EINVAL; | 1843 | return -EINVAL; |
1844 | } | 1844 | } |
1845 | |||
1845 | transport_add_cmd_to_queue(cmd, TRANSPORT_NEW_CMD); | 1846 | transport_add_cmd_to_queue(cmd, TRANSPORT_NEW_CMD); |
1846 | return 0; | 1847 | return 0; |
1847 | } | 1848 | } |
1848 | EXPORT_SYMBOL(transport_generic_handle_cdb); | 1849 | EXPORT_SYMBOL(transport_generic_handle_cdb); |
1849 | 1850 | ||
1850 | /* | 1851 | /* |
1852 | * Used by fabric module frontends to queue tasks directly. | ||
1853 | * Many only be used from process context only | ||
1854 | */ | ||
1855 | int transport_handle_cdb_direct( | ||
1856 | struct se_cmd *cmd) | ||
1857 | { | ||
1858 | if (!cmd->se_lun) { | ||
1859 | dump_stack(); | ||
1860 | printk(KERN_ERR "cmd->se_lun is NULL\n"); | ||
1861 | return -EINVAL; | ||
1862 | } | ||
1863 | if (in_interrupt()) { | ||
1864 | dump_stack(); | ||
1865 | printk(KERN_ERR "transport_generic_handle_cdb cannot be called" | ||
1866 | " from interrupt context\n"); | ||
1867 | return -EINVAL; | ||
1868 | } | ||
1869 | |||
1870 | return transport_generic_new_cmd(cmd); | ||
1871 | } | ||
1872 | EXPORT_SYMBOL(transport_handle_cdb_direct); | ||
1873 | |||
1874 | /* | ||
1851 | * Used by fabric module frontends defining a TFO->new_cmd_map() caller | 1875 | * Used by fabric module frontends defining a TFO->new_cmd_map() caller |
1852 | * to queue up a newly setup se_cmd w/ TRANSPORT_NEW_CMD_MAP in order to | 1876 | * to queue up a newly setup se_cmd w/ TRANSPORT_NEW_CMD_MAP in order to |
1853 | * complete setup in TCM process context w/ TFO->new_cmd_map(). | 1877 | * complete setup in TCM process context w/ TFO->new_cmd_map(). |