diff options
author | Daniel Lichtenberger <daniel.lichtenberger@gmail.com> | 2010-10-28 17:20:12 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-11-09 17:05:23 -0500 |
commit | 43f88d530ec656d9b556fb0d127b30757b1c3d35 (patch) | |
tree | ba8eb4e133fff45d25299f345223570409f2b6d4 /drivers/staging | |
parent | eacd121c3d0b74220aa6a91223e0adf7d5ec2497 (diff) |
Staging: rtl8192e: fix IOMMU memory leak
Unmap the rx buffer before mapping the new one in rtl8192_rx.
Failing to do so quickly exhausts the IOMMU memory during downloads:
[...] DMA: Out of SW-IOMMU space for 9100 bytes at device ...
Using "iommu=off mem=4g" also fixes the problem because
then pci_map_single does not allocate memory.
Tested on my personal laptop with a RTL8192E device. Without this
patch the kernel quickly runs out of IOMMU memory (downloading 5 MB
of data is sufficient to trigger it), with this patch applied
I haven't experienced any issues so far.
Signed-off-by: Daniel Lichtenberger <daniel.lichtenberger@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging')
-rw-r--r-- | drivers/staging/rtl8192e/r8192E_core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/staging/rtl8192e/r8192E_core.c b/drivers/staging/rtl8192e/r8192E_core.c index a202194b5cbb..b1786dcac245 100644 --- a/drivers/staging/rtl8192e/r8192E_core.c +++ b/drivers/staging/rtl8192e/r8192E_core.c | |||
@@ -5829,6 +5829,9 @@ static void rtl8192_rx(struct net_device *dev) | |||
5829 | } | 5829 | } |
5830 | } | 5830 | } |
5831 | 5831 | ||
5832 | pci_unmap_single(priv->pdev, *((dma_addr_t *) skb->cb), | ||
5833 | priv->rxbuffersize, PCI_DMA_FROMDEVICE); | ||
5834 | |||
5832 | skb = new_skb; | 5835 | skb = new_skb; |
5833 | priv->rx_buf[priv->rx_idx] = skb; | 5836 | priv->rx_buf[priv->rx_idx] = skb; |
5834 | *((dma_addr_t *) skb->cb) = pci_map_single(priv->pdev, skb_tail_pointer(skb), priv->rxbuffersize, PCI_DMA_FROMDEVICE); | 5837 | *((dma_addr_t *) skb->cb) = pci_map_single(priv->pdev, skb_tail_pointer(skb), priv->rxbuffersize, PCI_DMA_FROMDEVICE); |