aboutsummaryrefslogtreecommitdiffstats
path: root/drivers/sh/pfc/core.c
diff options
context:
space:
mode:
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>2012-12-15 17:50:45 -0500
committerSimon Horman <horms+renesas@verge.net.au>2013-01-24 19:24:21 -0500
commitf9492fda70c87b410e61675095212dc806bdf615 (patch)
treec93658fb54a61a70e0f612345abe59cbb72c7de9 /drivers/sh/pfc/core.c
parentf9165132c5ee681235068857e4f86c7ecc5a4617 (diff)
sh-pfc: Merge PFC core and pinctrl
The PFC core is only used by the pinctrl and gpio modules. As the gpio module depends on the pinctrl module, the pinctrl module will always be present if the core gets used. There is thus no point in keeping core and pinctrl in two seperate modules. Merge them. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Acked-by: Paul Mundt <lethal@linux-sh.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Diffstat (limited to 'drivers/sh/pfc/core.c')
-rw-r--r--drivers/sh/pfc/core.c15
1 files changed, 3 insertions, 12 deletions
diff --git a/drivers/sh/pfc/core.c b/drivers/sh/pfc/core.c
index 72421a4a883d..30e33db7a2dc 100644
--- a/drivers/sh/pfc/core.c
+++ b/drivers/sh/pfc/core.c
@@ -8,7 +8,7 @@
8 * License. See the file "COPYING" in the main directory of this archive 8 * License. See the file "COPYING" in the main directory of this archive
9 * for more details. 9 * for more details.
10 */ 10 */
11#define pr_fmt(fmt) "sh_pfc " KBUILD_MODNAME ": " fmt 11#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
12 12
13#include <linux/errno.h> 13#include <linux/errno.h>
14#include <linux/kernel.h> 14#include <linux/kernel.h>
@@ -497,7 +497,6 @@ int sh_pfc_config_gpio(struct sh_pfc *pfc, unsigned gpio, int pinmux_type,
497 out_err: 497 out_err:
498 return -1; 498 return -1;
499} 499}
500EXPORT_SYMBOL_GPL(sh_pfc_config_gpio);
501 500
502int register_sh_pfc(struct sh_pfc_platform_data *pdata) 501int register_sh_pfc(struct sh_pfc_platform_data *pdata)
503{ 502{
@@ -528,17 +527,9 @@ int register_sh_pfc(struct sh_pfc_platform_data *pdata)
528 /* 527 /*
529 * Initialize pinctrl bindings first 528 * Initialize pinctrl bindings first
530 */ 529 */
531 initroutine = symbol_request(sh_pfc_register_pinctrl); 530 ret = sh_pfc_register_pinctrl(&sh_pfc);
532 if (initroutine) { 531 if (unlikely(ret != 0))
533 ret = (*initroutine)(&sh_pfc);
534 symbol_put_addr(initroutine);
535
536 if (unlikely(ret != 0))
537 goto err;
538 } else {
539 pr_err("failed to initialize pinctrl bindings\n");
540 goto err; 532 goto err;
541 }
542 533
543 /* 534 /*
544 * Then the GPIO chip 535 * Then the GPIO chip