diff options
author | Randy Dunlap <randy.dunlap@oracle.com> | 2011-01-28 19:03:57 -0500 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2011-02-12 12:00:08 -0500 |
commit | 55204909bb687c997d5601e9f24a25cf9e915d78 (patch) | |
tree | de207b0f51dc40de1e08cdac22a019abc9b8b0e9 /drivers/scsi/libfc | |
parent | 52ee832195b0ae33f12e334e61cf43d1087f24d6 (diff) |
[SCSI] libfc: fix sparse static and non-ANSI warnings
Fix sparse warning for non-ANSI function declaration.
Declare workqueue structs as static.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Robert Love <robert.w.love@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc')
-rw-r--r-- | drivers/scsi/libfc/fc_exch.c | 6 | ||||
-rw-r--r-- | drivers/scsi/libfc/fc_fcp.c | 6 | ||||
-rw-r--r-- | drivers/scsi/libfc/fc_rport.c | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index d21367d3305f..e0b5b15c355b 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c | |||
@@ -38,7 +38,7 @@ u16 fc_cpu_mask; /* cpu mask for possible cpus */ | |||
38 | EXPORT_SYMBOL(fc_cpu_mask); | 38 | EXPORT_SYMBOL(fc_cpu_mask); |
39 | static u16 fc_cpu_order; /* 2's power to represent total possible cpus */ | 39 | static u16 fc_cpu_order; /* 2's power to represent total possible cpus */ |
40 | static struct kmem_cache *fc_em_cachep; /* cache for exchanges */ | 40 | static struct kmem_cache *fc_em_cachep; /* cache for exchanges */ |
41 | struct workqueue_struct *fc_exch_workqueue; | 41 | static struct workqueue_struct *fc_exch_workqueue; |
42 | 42 | ||
43 | /* | 43 | /* |
44 | * Structure and function definitions for managing Fibre Channel Exchanges | 44 | * Structure and function definitions for managing Fibre Channel Exchanges |
@@ -2357,7 +2357,7 @@ EXPORT_SYMBOL(fc_exch_init); | |||
2357 | /** | 2357 | /** |
2358 | * fc_setup_exch_mgr() - Setup an exchange manager | 2358 | * fc_setup_exch_mgr() - Setup an exchange manager |
2359 | */ | 2359 | */ |
2360 | int fc_setup_exch_mgr() | 2360 | int fc_setup_exch_mgr(void) |
2361 | { | 2361 | { |
2362 | fc_em_cachep = kmem_cache_create("libfc_em", sizeof(struct fc_exch), | 2362 | fc_em_cachep = kmem_cache_create("libfc_em", sizeof(struct fc_exch), |
2363 | 0, SLAB_HWCACHE_ALIGN, NULL); | 2363 | 0, SLAB_HWCACHE_ALIGN, NULL); |
@@ -2395,7 +2395,7 @@ int fc_setup_exch_mgr() | |||
2395 | /** | 2395 | /** |
2396 | * fc_destroy_exch_mgr() - Destroy an exchange manager | 2396 | * fc_destroy_exch_mgr() - Destroy an exchange manager |
2397 | */ | 2397 | */ |
2398 | void fc_destroy_exch_mgr() | 2398 | void fc_destroy_exch_mgr(void) |
2399 | { | 2399 | { |
2400 | destroy_workqueue(fc_exch_workqueue); | 2400 | destroy_workqueue(fc_exch_workqueue); |
2401 | kmem_cache_destroy(fc_em_cachep); | 2401 | kmem_cache_destroy(fc_em_cachep); |
diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index f4eb1ab7b288..383a98288d2e 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi/libfc/fc_fcp.c | |||
@@ -42,7 +42,7 @@ | |||
42 | 42 | ||
43 | #include "fc_libfc.h" | 43 | #include "fc_libfc.h" |
44 | 44 | ||
45 | struct kmem_cache *scsi_pkt_cachep; | 45 | static struct kmem_cache *scsi_pkt_cachep; |
46 | 46 | ||
47 | /* SRB state definitions */ | 47 | /* SRB state definitions */ |
48 | #define FC_SRB_FREE 0 /* cmd is free */ | 48 | #define FC_SRB_FREE 0 /* cmd is free */ |
@@ -2244,7 +2244,7 @@ void fc_fcp_destroy(struct fc_lport *lport) | |||
2244 | } | 2244 | } |
2245 | EXPORT_SYMBOL(fc_fcp_destroy); | 2245 | EXPORT_SYMBOL(fc_fcp_destroy); |
2246 | 2246 | ||
2247 | int fc_setup_fcp() | 2247 | int fc_setup_fcp(void) |
2248 | { | 2248 | { |
2249 | int rc = 0; | 2249 | int rc = 0; |
2250 | 2250 | ||
@@ -2260,7 +2260,7 @@ int fc_setup_fcp() | |||
2260 | return rc; | 2260 | return rc; |
2261 | } | 2261 | } |
2262 | 2262 | ||
2263 | void fc_destroy_fcp() | 2263 | void fc_destroy_fcp(void) |
2264 | { | 2264 | { |
2265 | if (scsi_pkt_cachep) | 2265 | if (scsi_pkt_cachep) |
2266 | kmem_cache_destroy(scsi_pkt_cachep); | 2266 | kmem_cache_destroy(scsi_pkt_cachep); |
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 325bc429dda4..309e3e713ea1 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi/libfc/fc_rport.c | |||
@@ -58,7 +58,7 @@ | |||
58 | 58 | ||
59 | #include "fc_libfc.h" | 59 | #include "fc_libfc.h" |
60 | 60 | ||
61 | struct workqueue_struct *rport_event_queue; | 61 | static struct workqueue_struct *rport_event_queue; |
62 | 62 | ||
63 | static void fc_rport_enter_flogi(struct fc_rport_priv *); | 63 | static void fc_rport_enter_flogi(struct fc_rport_priv *); |
64 | static void fc_rport_enter_plogi(struct fc_rport_priv *); | 64 | static void fc_rport_enter_plogi(struct fc_rport_priv *); |
@@ -1890,7 +1890,7 @@ EXPORT_SYMBOL(fc_rport_init); | |||
1890 | /** | 1890 | /** |
1891 | * fc_setup_rport() - Initialize the rport_event_queue | 1891 | * fc_setup_rport() - Initialize the rport_event_queue |
1892 | */ | 1892 | */ |
1893 | int fc_setup_rport() | 1893 | int fc_setup_rport(void) |
1894 | { | 1894 | { |
1895 | rport_event_queue = create_singlethread_workqueue("fc_rport_eq"); | 1895 | rport_event_queue = create_singlethread_workqueue("fc_rport_eq"); |
1896 | if (!rport_event_queue) | 1896 | if (!rport_event_queue) |
@@ -1901,7 +1901,7 @@ int fc_setup_rport() | |||
1901 | /** | 1901 | /** |
1902 | * fc_destroy_rport() - Destroy the rport_event_queue | 1902 | * fc_destroy_rport() - Destroy the rport_event_queue |
1903 | */ | 1903 | */ |
1904 | void fc_destroy_rport() | 1904 | void fc_destroy_rport(void) |
1905 | { | 1905 | { |
1906 | destroy_workqueue(rport_event_queue); | 1906 | destroy_workqueue(rport_event_queue); |
1907 | } | 1907 | } |