diff options
author | Robert Love <robert.w.love@intel.com> | 2009-07-29 20:05:05 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2009-08-22 18:52:08 -0400 |
commit | d459b7ea1b4c7aa3dacfeee174d02b2f7a95850d (patch) | |
tree | 65fafcc2af6d44713fd5e7f113fa7f180d4f4675 /drivers/scsi/libfc/fc_exch.c | |
parent | 96316099ac3cb259eac2d6891f3c75b38b29d26e (diff) |
[SCSI] libfc: Remove the FC_EM_DBG macro
Currently there is a 1:1 relationship between the lport
and exchange manager. This macro takes an EM as an argument
and determines the lport from it. However, later patches
will use an EM list per lport, so we will no longer have
this 1:1 relationship- this macro must change.
The FC_EM_DBG macro is rarely used. There are four callers,
two can use FC_LPORT_DBG instead and two can be removed
since they're not necessary. This patch makes those changes
and removes the macro.
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/scsi/libfc/fc_exch.c')
-rw-r--r-- | drivers/scsi/libfc/fc_exch.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index f1fa2b196e98..3ad7f88e7ae3 100644 --- a/drivers/scsi/libfc/fc_exch.c +++ b/drivers/scsi/libfc/fc_exch.c | |||
@@ -1129,7 +1129,7 @@ static void fc_exch_recv_req(struct fc_lport *lp, struct fc_exch_mgr *mp, | |||
1129 | lp->tt.lport_recv(lp, sp, fp); | 1129 | lp->tt.lport_recv(lp, sp, fp); |
1130 | fc_exch_release(ep); /* release from lookup */ | 1130 | fc_exch_release(ep); /* release from lookup */ |
1131 | } else { | 1131 | } else { |
1132 | FC_EM_DBG(mp, "exch/seq lookup failed: reject %x\n", reject); | 1132 | FC_LPORT_DBG(lp, "exch/seq lookup failed: reject %x\n", reject); |
1133 | fc_frame_free(fp); | 1133 | fc_frame_free(fp); |
1134 | } | 1134 | } |
1135 | } | 1135 | } |
@@ -1235,13 +1235,12 @@ static void fc_exch_recv_resp(struct fc_exch_mgr *mp, struct fc_frame *fp) | |||
1235 | struct fc_seq *sp; | 1235 | struct fc_seq *sp; |
1236 | 1236 | ||
1237 | sp = fc_seq_lookup_orig(mp, fp); /* doesn't hold sequence */ | 1237 | sp = fc_seq_lookup_orig(mp, fp); /* doesn't hold sequence */ |
1238 | if (!sp) { | 1238 | |
1239 | if (!sp) | ||
1239 | atomic_inc(&mp->stats.xid_not_found); | 1240 | atomic_inc(&mp->stats.xid_not_found); |
1240 | FC_EM_DBG(mp, "seq lookup failed\n"); | 1241 | else |
1241 | } else { | ||
1242 | atomic_inc(&mp->stats.non_bls_resp); | 1242 | atomic_inc(&mp->stats.non_bls_resp); |
1243 | FC_EM_DBG(mp, "non-BLS response to sequence"); | 1243 | |
1244 | } | ||
1245 | fc_frame_free(fp); | 1244 | fc_frame_free(fp); |
1246 | } | 1245 | } |
1247 | 1246 | ||
@@ -1950,7 +1949,7 @@ void fc_exch_recv(struct fc_lport *lp, struct fc_exch_mgr *mp, | |||
1950 | fc_exch_recv_req(lp, mp, fp); | 1949 | fc_exch_recv_req(lp, mp, fp); |
1951 | break; | 1950 | break; |
1952 | default: | 1951 | default: |
1953 | FC_EM_DBG(mp, "dropping invalid frame (eof %x)", fr_eof(fp)); | 1952 | FC_LPORT_DBG(lp, "dropping invalid frame (eof %x)", fr_eof(fp)); |
1954 | fc_frame_free(fp); | 1953 | fc_frame_free(fp); |
1955 | break; | 1954 | break; |
1956 | } | 1955 | } |