diff options
author | Swen Schillig <swen@vnet.ibm.com> | 2010-09-08 08:40:01 -0400 |
---|---|---|
committer | James Bottomley <James.Bottomley@suse.de> | 2010-09-16 22:54:23 -0400 |
commit | edaed859e63aac174fcc3fed81886b91bb124661 (patch) | |
tree | b79ef611b8cf2bfe9e819ae130eff326ee553234 /drivers/s390/scsi/zfcp_cfdc.c | |
parent | c9ff5d0315231b133a43e5af842bc01fb474f0d7 (diff) |
[SCSI] zfcp: Replace status modifier functions.
Replace the zfcp_modify_<xxx>_status functions and its accompanying wrappers
with dedicated status modifier functions. This eases code readability and
maintenance.
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Diffstat (limited to 'drivers/s390/scsi/zfcp_cfdc.c')
-rw-r--r-- | drivers/s390/scsi/zfcp_cfdc.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/drivers/s390/scsi/zfcp_cfdc.c b/drivers/s390/scsi/zfcp_cfdc.c index f952b89b108a..a56d14166c99 100644 --- a/drivers/s390/scsi/zfcp_cfdc.c +++ b/drivers/s390/scsi/zfcp_cfdc.c | |||
@@ -328,9 +328,9 @@ void zfcp_cfdc_port_denied(struct zfcp_port *port, | |||
328 | 328 | ||
329 | zfcp_act_eval_err(port->adapter, qual->halfword[0]); | 329 | zfcp_act_eval_err(port->adapter, qual->halfword[0]); |
330 | zfcp_act_eval_err(port->adapter, qual->halfword[1]); | 330 | zfcp_act_eval_err(port->adapter, qual->halfword[1]); |
331 | zfcp_erp_modify_port_status(port, "cfadp_1", NULL, | 331 | zfcp_erp_set_port_status(port, |
332 | ZFCP_STATUS_COMMON_ERP_FAILED | | 332 | ZFCP_STATUS_COMMON_ERP_FAILED | |
333 | ZFCP_STATUS_COMMON_ACCESS_DENIED, ZFCP_SET); | 333 | ZFCP_STATUS_COMMON_ACCESS_DENIED); |
334 | } | 334 | } |
335 | 335 | ||
336 | /** | 336 | /** |
@@ -349,9 +349,9 @@ void zfcp_cfdc_lun_denied(struct scsi_device *sdev, | |||
349 | (unsigned long long)zfcp_sdev->port->wwpn); | 349 | (unsigned long long)zfcp_sdev->port->wwpn); |
350 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->halfword[0]); | 350 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->halfword[0]); |
351 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->halfword[1]); | 351 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->halfword[1]); |
352 | zfcp_erp_modify_lun_status(sdev, "cfadl_1", NULL, | 352 | zfcp_erp_set_lun_status(sdev, |
353 | ZFCP_STATUS_COMMON_ERP_FAILED | | 353 | ZFCP_STATUS_COMMON_ERP_FAILED | |
354 | ZFCP_STATUS_COMMON_ACCESS_DENIED, ZFCP_SET); | 354 | ZFCP_STATUS_COMMON_ACCESS_DENIED); |
355 | 355 | ||
356 | atomic_clear_mask(ZFCP_STATUS_LUN_SHARED, &zfcp_sdev->status); | 356 | atomic_clear_mask(ZFCP_STATUS_LUN_SHARED, &zfcp_sdev->status); |
357 | atomic_clear_mask(ZFCP_STATUS_LUN_READONLY, &zfcp_sdev->status); | 357 | atomic_clear_mask(ZFCP_STATUS_LUN_READONLY, &zfcp_sdev->status); |
@@ -378,9 +378,9 @@ void zfcp_cfdc_lun_shrng_vltn(struct scsi_device *sdev, | |||
378 | else | 378 | else |
379 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->word[2]); | 379 | zfcp_act_eval_err(zfcp_sdev->port->adapter, qual->word[2]); |
380 | 380 | ||
381 | zfcp_erp_modify_lun_status(sdev, "fsosh_3", NULL, | 381 | zfcp_erp_set_lun_status(sdev, |
382 | ZFCP_STATUS_COMMON_ERP_FAILED | | 382 | ZFCP_STATUS_COMMON_ERP_FAILED | |
383 | ZFCP_STATUS_COMMON_ACCESS_DENIED, ZFCP_SET); | 383 | ZFCP_STATUS_COMMON_ACCESS_DENIED); |
384 | atomic_clear_mask(ZFCP_STATUS_LUN_SHARED, &zfcp_sdev->status); | 384 | atomic_clear_mask(ZFCP_STATUS_LUN_SHARED, &zfcp_sdev->status); |
385 | atomic_clear_mask(ZFCP_STATUS_LUN_READONLY, &zfcp_sdev->status); | 385 | atomic_clear_mask(ZFCP_STATUS_LUN_READONLY, &zfcp_sdev->status); |
386 | } | 386 | } |
@@ -424,7 +424,7 @@ int zfcp_cfdc_open_lun_eval(struct scsi_device *sdev, | |||
424 | "not supported (LUN 0x%016Lx, port 0x%016Lx)\n", | 424 | "not supported (LUN 0x%016Lx, port 0x%016Lx)\n", |
425 | zfcp_scsi_dev_lun(sdev), | 425 | zfcp_scsi_dev_lun(sdev), |
426 | (unsigned long long)zfcp_sdev->port->wwpn); | 426 | (unsigned long long)zfcp_sdev->port->wwpn); |
427 | zfcp_erp_lun_failed(sdev, "fsosh_5", NULL); | 427 | zfcp_erp_set_lun_status(sdev, ZFCP_STATUS_COMMON_ERP_FAILED); |
428 | zfcp_erp_lun_shutdown(sdev, 0, "fsouh_6", NULL); | 428 | zfcp_erp_lun_shutdown(sdev, 0, "fsouh_6", NULL); |
429 | return -EACCES; | 429 | return -EACCES; |
430 | } | 430 | } |
@@ -435,7 +435,7 @@ int zfcp_cfdc_open_lun_eval(struct scsi_device *sdev, | |||
435 | "(LUN 0x%016Lx, port 0x%016Lx)\n", | 435 | "(LUN 0x%016Lx, port 0x%016Lx)\n", |
436 | zfcp_scsi_dev_lun(sdev), | 436 | zfcp_scsi_dev_lun(sdev), |
437 | (unsigned long long)zfcp_sdev->port->wwpn); | 437 | (unsigned long long)zfcp_sdev->port->wwpn); |
438 | zfcp_erp_lun_failed(sdev, "fsosh_7", NULL); | 438 | zfcp_erp_set_lun_status(sdev, ZFCP_STATUS_COMMON_ERP_FAILED); |
439 | zfcp_erp_lun_shutdown(sdev, 0, "fsosh_8", NULL); | 439 | zfcp_erp_lun_shutdown(sdev, 0, "fsosh_8", NULL); |
440 | return -EACCES; | 440 | return -EACCES; |
441 | } | 441 | } |