diff options
| author | Jingoo Han <jg1.han@samsung.com> | 2013-03-11 02:34:55 -0400 |
|---|---|---|
| committer | Anton Vorontsov <anton@enomsg.org> | 2013-04-01 02:25:36 -0400 |
| commit | d4a20f57d3407de31eb692ee57aaad81f15d4652 (patch) | |
| tree | 2c5576c154edef371ccd02bb5db2d89cb3e307cf /drivers/power | |
| parent | acfbf47a903a22d4679137ad04d00194baec6a0c (diff) | |
max8997_charger: Use devm_kzalloc()
Use devm_kzalloc() to make cleanup paths more simple.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/max8997_charger.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/drivers/power/max8997_charger.c b/drivers/power/max8997_charger.c index e757885b620c..4bdedfed936d 100644 --- a/drivers/power/max8997_charger.c +++ b/drivers/power/max8997_charger.c | |||
| @@ -138,7 +138,8 @@ static int max8997_battery_probe(struct platform_device *pdev) | |||
| 138 | return ret; | 138 | return ret; |
| 139 | } | 139 | } |
| 140 | 140 | ||
| 141 | charger = kzalloc(sizeof(struct charger_data), GFP_KERNEL); | 141 | charger = devm_kzalloc(&pdev->dev, sizeof(struct charger_data), |
| 142 | GFP_KERNEL); | ||
| 142 | if (charger == NULL) { | 143 | if (charger == NULL) { |
| 143 | dev_err(&pdev->dev, "Cannot allocate memory.\n"); | 144 | dev_err(&pdev->dev, "Cannot allocate memory.\n"); |
| 144 | return -ENOMEM; | 145 | return -ENOMEM; |
| @@ -158,13 +159,10 @@ static int max8997_battery_probe(struct platform_device *pdev) | |||
| 158 | ret = power_supply_register(&pdev->dev, &charger->battery); | 159 | ret = power_supply_register(&pdev->dev, &charger->battery); |
| 159 | if (ret) { | 160 | if (ret) { |
| 160 | dev_err(&pdev->dev, "failed: power supply register\n"); | 161 | dev_err(&pdev->dev, "failed: power supply register\n"); |
| 161 | goto err; | 162 | return ret; |
| 162 | } | 163 | } |
| 163 | 164 | ||
| 164 | return 0; | 165 | return 0; |
| 165 | err: | ||
| 166 | kfree(charger); | ||
| 167 | return ret; | ||
| 168 | } | 166 | } |
| 169 | 167 | ||
| 170 | static int max8997_battery_remove(struct platform_device *pdev) | 168 | static int max8997_battery_remove(struct platform_device *pdev) |
| @@ -172,7 +170,6 @@ static int max8997_battery_remove(struct platform_device *pdev) | |||
| 172 | struct charger_data *charger = platform_get_drvdata(pdev); | 170 | struct charger_data *charger = platform_get_drvdata(pdev); |
| 173 | 171 | ||
| 174 | power_supply_unregister(&charger->battery); | 172 | power_supply_unregister(&charger->battery); |
| 175 | kfree(charger); | ||
| 176 | return 0; | 173 | return 0; |
| 177 | } | 174 | } |
| 178 | 175 | ||
