diff options
author | Joe Perches <joe@perches.com> | 2011-11-29 14:04:05 -0500 |
---|---|---|
committer | Matthew Garrett <mjg@redhat.com> | 2012-03-20 12:02:13 -0400 |
commit | 6e71f38bdac9e7e3d598fdfe31020cdaa18b20d5 (patch) | |
tree | cd12f1e5bc70cee234280d11fa5f2499a725cabc /drivers/platform | |
parent | 92304a4084911cf1eef1cd624f6bf6f207498847 (diff) |
acer-wmi: Message logging neatening
Use pr_warn not pr_warning.
Coalesce formats.
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Diffstat (limited to 'drivers/platform')
-rw-r--r-- | drivers/platform/x86/acer-wmi.c | 29 |
1 files changed, 14 insertions, 15 deletions
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c index 1e5290b5396d..6cd2289dd5d3 100644 --- a/drivers/platform/x86/acer-wmi.c +++ b/drivers/platform/x86/acer-wmi.c | |||
@@ -1006,7 +1006,7 @@ static acpi_status wmid3_set_device_status(u32 value, u16 device) | |||
1006 | return AE_ERROR; | 1006 | return AE_ERROR; |
1007 | } | 1007 | } |
1008 | if (obj->buffer.length != 8) { | 1008 | if (obj->buffer.length != 8) { |
1009 | pr_warning("Unknown buffer length %d\n", obj->buffer.length); | 1009 | pr_warn("Unknown buffer length %d\n", obj->buffer.length); |
1010 | kfree(obj); | 1010 | kfree(obj); |
1011 | return AE_ERROR; | 1011 | return AE_ERROR; |
1012 | } | 1012 | } |
@@ -1015,8 +1015,8 @@ static acpi_status wmid3_set_device_status(u32 value, u16 device) | |||
1015 | kfree(obj); | 1015 | kfree(obj); |
1016 | 1016 | ||
1017 | if (return_value.error_code || return_value.ec_return_value) { | 1017 | if (return_value.error_code || return_value.ec_return_value) { |
1018 | pr_warning("Get Current Device Status failed: " | 1018 | pr_warn("Get Current Device Status failed: 0x%x - 0x%x\n", |
1019 | "0x%x - 0x%x\n", return_value.error_code, | 1019 | return_value.error_code, |
1020 | return_value.ec_return_value); | 1020 | return_value.ec_return_value); |
1021 | return status; | 1021 | return status; |
1022 | } | 1022 | } |
@@ -1039,7 +1039,7 @@ static acpi_status wmid3_set_device_status(u32 value, u16 device) | |||
1039 | return AE_ERROR; | 1039 | return AE_ERROR; |
1040 | } | 1040 | } |
1041 | if (obj->buffer.length != 4) { | 1041 | if (obj->buffer.length != 4) { |
1042 | pr_warning("Unknown buffer length %d\n", obj->buffer.length); | 1042 | pr_warn("Unknown buffer length %d\n", obj->buffer.length); |
1043 | kfree(obj); | 1043 | kfree(obj); |
1044 | return AE_ERROR; | 1044 | return AE_ERROR; |
1045 | } | 1045 | } |
@@ -1048,8 +1048,8 @@ static acpi_status wmid3_set_device_status(u32 value, u16 device) | |||
1048 | kfree(obj); | 1048 | kfree(obj); |
1049 | 1049 | ||
1050 | if (return_value.error_code || return_value.ec_return_value) | 1050 | if (return_value.error_code || return_value.ec_return_value) |
1051 | pr_warning("Set Device Status failed: " | 1051 | pr_warn("Set Device Status failed: 0x%x - 0x%x\n", |
1052 | "0x%x - 0x%x\n", return_value.error_code, | 1052 | return_value.error_code, |
1053 | return_value.ec_return_value); | 1053 | return_value.ec_return_value); |
1054 | 1054 | ||
1055 | return status; | 1055 | return status; |
@@ -1488,8 +1488,8 @@ static ssize_t show_bool_threeg(struct device *dev, | |||
1488 | u32 result; \ | 1488 | u32 result; \ |
1489 | acpi_status status; | 1489 | acpi_status status; |
1490 | 1490 | ||
1491 | pr_info("This threeg sysfs will be removed in 2012" | 1491 | pr_info("This threeg sysfs will be removed in 2012 - used by: %s\n", |
1492 | " - used by: %s\n", current->comm); | 1492 | current->comm); |
1493 | status = get_u32(&result, ACER_CAP_THREEG); | 1493 | status = get_u32(&result, ACER_CAP_THREEG); |
1494 | if (ACPI_SUCCESS(status)) | 1494 | if (ACPI_SUCCESS(status)) |
1495 | return sprintf(buf, "%u\n", result); | 1495 | return sprintf(buf, "%u\n", result); |
@@ -1501,8 +1501,8 @@ static ssize_t set_bool_threeg(struct device *dev, | |||
1501 | { | 1501 | { |
1502 | u32 tmp = simple_strtoul(buf, NULL, 10); | 1502 | u32 tmp = simple_strtoul(buf, NULL, 10); |
1503 | acpi_status status = set_u32(tmp, ACER_CAP_THREEG); | 1503 | acpi_status status = set_u32(tmp, ACER_CAP_THREEG); |
1504 | pr_info("This threeg sysfs will be removed in 2012" | 1504 | pr_info("This threeg sysfs will be removed in 2012 - used by: %s\n", |
1505 | " - used by: %s\n", current->comm); | 1505 | current->comm); |
1506 | if (ACPI_FAILURE(status)) | 1506 | if (ACPI_FAILURE(status)) |
1507 | return -EINVAL; | 1507 | return -EINVAL; |
1508 | return count; | 1508 | return count; |
@@ -1513,8 +1513,8 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg, | |||
1513 | static ssize_t show_interface(struct device *dev, struct device_attribute *attr, | 1513 | static ssize_t show_interface(struct device *dev, struct device_attribute *attr, |
1514 | char *buf) | 1514 | char *buf) |
1515 | { | 1515 | { |
1516 | pr_info("This interface sysfs will be removed in 2012" | 1516 | pr_info("This interface sysfs will be removed in 2012 - used by: %s\n", |
1517 | " - used by: %s\n", current->comm); | 1517 | current->comm); |
1518 | switch (interface->type) { | 1518 | switch (interface->type) { |
1519 | case ACER_AMW0: | 1519 | case ACER_AMW0: |
1520 | return sprintf(buf, "AMW0\n"); | 1520 | return sprintf(buf, "AMW0\n"); |
@@ -1982,8 +1982,7 @@ static int __init acer_wmi_init(void) | |||
1982 | 1982 | ||
1983 | if (acpi_video_backlight_support()) { | 1983 | if (acpi_video_backlight_support()) { |
1984 | interface->capability &= ~ACER_CAP_BRIGHTNESS; | 1984 | interface->capability &= ~ACER_CAP_BRIGHTNESS; |
1985 | pr_info("Brightness must be controlled by " | 1985 | pr_info("Brightness must be controlled by generic video driver\n"); |
1986 | "generic video driver\n"); | ||
1987 | } | 1986 | } |
1988 | 1987 | ||
1989 | if (wmi_has_guid(WMID_GUID3)) { | 1988 | if (wmi_has_guid(WMID_GUID3)) { |
@@ -2008,7 +2007,7 @@ static int __init acer_wmi_init(void) | |||
2008 | 2007 | ||
2009 | err = platform_driver_register(&acer_platform_driver); | 2008 | err = platform_driver_register(&acer_platform_driver); |
2010 | if (err) { | 2009 | if (err) { |
2011 | pr_err("Unable to register platform driver.\n"); | 2010 | pr_err("Unable to register platform driver\n"); |
2012 | goto error_platform_register; | 2011 | goto error_platform_register; |
2013 | } | 2012 | } |
2014 | 2013 | ||