diff options
author | Bjorn Helgaas <bhelgaas@google.com> | 2013-04-17 19:42:30 -0400 |
---|---|---|
committer | Bjorn Helgaas <bhelgaas@google.com> | 2013-04-23 11:50:30 -0400 |
commit | 4987ce82056327a43cd58c32adf8a3f255e7d862 (patch) | |
tree | 828aa7b5396facb5e5708321a3ab650359d3fb1a /drivers/pci | |
parent | 2f221349366daf074bad07cc670e483cc52ab203 (diff) |
PCI: Drop is_64bit_address() and is_mask_bit_support() macros
is_64bit_address() and is_mask_bit_support() don't provide any useful
abstraction, so drop them.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Diffstat (limited to 'drivers/pci')
-rw-r--r-- | drivers/pci/msi.c | 4 | ||||
-rw-r--r-- | drivers/pci/msi.h | 2 |
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 1688c26db962..aaaf954ad3a4 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c | |||
@@ -555,9 +555,9 @@ static int msi_capability_init(struct pci_dev *dev, int nvec) | |||
555 | return -ENOMEM; | 555 | return -ENOMEM; |
556 | 556 | ||
557 | entry->msi_attrib.is_msix = 0; | 557 | entry->msi_attrib.is_msix = 0; |
558 | entry->msi_attrib.is_64 = is_64bit_address(control); | 558 | entry->msi_attrib.is_64 = !!(control & PCI_MSI_FLAGS_64BIT); |
559 | entry->msi_attrib.entry_nr = 0; | 559 | entry->msi_attrib.entry_nr = 0; |
560 | entry->msi_attrib.maskbit = is_mask_bit_support(control); | 560 | entry->msi_attrib.maskbit = !!(control & PCI_MSI_FLAGS_MASKBIT); |
561 | entry->msi_attrib.default_irq = dev->irq; /* Save IOAPIC IRQ */ | 561 | entry->msi_attrib.default_irq = dev->irq; /* Save IOAPIC IRQ */ |
562 | entry->msi_attrib.pos = dev->msi_cap; | 562 | entry->msi_attrib.pos = dev->msi_cap; |
563 | 563 | ||
diff --git a/drivers/pci/msi.h b/drivers/pci/msi.h index d2c6cd982a21..bc5cd9969062 100644 --- a/drivers/pci/msi.h +++ b/drivers/pci/msi.h | |||
@@ -8,8 +8,6 @@ | |||
8 | 8 | ||
9 | #define msi_mask_reg(base, is64bit) \ | 9 | #define msi_mask_reg(base, is64bit) \ |
10 | (base + ((is64bit == 1) ? PCI_MSI_MASK_64 : PCI_MSI_MASK_32)) | 10 | (base + ((is64bit == 1) ? PCI_MSI_MASK_64 : PCI_MSI_MASK_32)) |
11 | #define is_64bit_address(control) (!!(control & PCI_MSI_FLAGS_64BIT)) | ||
12 | #define is_mask_bit_support(control) (!!(control & PCI_MSI_FLAGS_MASKBIT)) | ||
13 | 11 | ||
14 | #define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE) | 12 | #define msix_table_offset_reg(base) (base + PCI_MSIX_TABLE) |
15 | #define msix_pba_offset_reg(base) (base + PCI_MSIX_PBA) | 13 | #define msix_pba_offset_reg(base) (base + PCI_MSIX_PBA) |