diff options
author | Johannes Stezenbach <js@sig21.net> | 2011-04-18 09:29:12 -0400 |
---|---|---|
committer | John W. Linville <linville@tuxdriver.com> | 2011-04-19 15:39:27 -0400 |
commit | 0e0d39e5f3a3e59c8513b59d4feeeadcb93b707d (patch) | |
tree | 72b63cb8c5a994cc7e6253b241aeddd131d618f0 /drivers/net/wireless/rt2x00/rt2x00usb.c | |
parent | 8da3efbb4a18be30ed03dd05af18d0b026b15173 (diff) |
rt2800usb: read TX_STA_FIFO asynchronously
Trying to fix the "TX status report missed" warnings
by reading the TX_STA_FIFO entries as quickly as possible.
The TX_STA_FIFO is too small in hardware, thus reading
it only from the workqueue is too slow and entries get lost.
Start an asynchronous read of the TX_STA_FIFO directly from
the TX URB completion callback (atomic context, thus it cannot
use the blocking rt2800_register_read()). If the async
read returns a valid FIFO entry, it is pushed into a larger
FIFO inside struct rt2x00_dev, until rt2800_txdone() picks
it up.
A .tx_dma_done callback is added to struct rt2x00lib_ops
to trigger the async read from the URB completion callback.
Signed-off-by: Johannes Stezenbach <js@sig21.net>
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net/wireless/rt2x00/rt2x00usb.c')
-rw-r--r-- | drivers/net/wireless/rt2x00/rt2x00usb.c | 53 |
1 files changed, 53 insertions, 0 deletions
diff --git a/drivers/net/wireless/rt2x00/rt2x00usb.c b/drivers/net/wireless/rt2x00/rt2x00usb.c index 0bc8dccd0f0a..5fbab6f19706 100644 --- a/drivers/net/wireless/rt2x00/rt2x00usb.c +++ b/drivers/net/wireless/rt2x00/rt2x00usb.c | |||
@@ -165,6 +165,56 @@ int rt2x00usb_regbusy_read(struct rt2x00_dev *rt2x00dev, | |||
165 | } | 165 | } |
166 | EXPORT_SYMBOL_GPL(rt2x00usb_regbusy_read); | 166 | EXPORT_SYMBOL_GPL(rt2x00usb_regbusy_read); |
167 | 167 | ||
168 | |||
169 | struct rt2x00_async_read_data { | ||
170 | __le32 reg; | ||
171 | struct usb_ctrlrequest cr; | ||
172 | struct rt2x00_dev *rt2x00dev; | ||
173 | void (*callback)(struct rt2x00_dev *,int,u32); | ||
174 | }; | ||
175 | |||
176 | static void rt2x00usb_register_read_async_cb(struct urb *urb) | ||
177 | { | ||
178 | struct rt2x00_async_read_data *rd = urb->context; | ||
179 | rd->callback(rd->rt2x00dev, urb->status, le32_to_cpu(rd->reg)); | ||
180 | kfree(urb->context); | ||
181 | } | ||
182 | |||
183 | void rt2x00usb_register_read_async(struct rt2x00_dev *rt2x00dev, | ||
184 | const unsigned int offset, | ||
185 | void (*callback)(struct rt2x00_dev*,int,u32)) | ||
186 | { | ||
187 | struct usb_device *usb_dev = to_usb_device_intf(rt2x00dev->dev); | ||
188 | struct urb *urb; | ||
189 | struct rt2x00_async_read_data *rd; | ||
190 | |||
191 | rd = kmalloc(sizeof(*rd), GFP_ATOMIC); | ||
192 | if (!rd) | ||
193 | return; | ||
194 | |||
195 | urb = usb_alloc_urb(0, GFP_ATOMIC); | ||
196 | if (!urb) { | ||
197 | kfree(rd); | ||
198 | return; | ||
199 | } | ||
200 | |||
201 | rd->rt2x00dev = rt2x00dev; | ||
202 | rd->callback = callback; | ||
203 | rd->cr.bRequestType = USB_VENDOR_REQUEST_IN; | ||
204 | rd->cr.bRequest = USB_MULTI_READ; | ||
205 | rd->cr.wValue = 0; | ||
206 | rd->cr.wIndex = cpu_to_le16(offset); | ||
207 | rd->cr.wLength = cpu_to_le16(sizeof(u32)); | ||
208 | |||
209 | usb_fill_control_urb(urb, usb_dev, usb_rcvctrlpipe(usb_dev, 0), | ||
210 | (unsigned char *)(&rd->cr), &rd->reg, sizeof(rd->reg), | ||
211 | rt2x00usb_register_read_async_cb, rd); | ||
212 | if (usb_submit_urb(urb, GFP_ATOMIC) < 0) | ||
213 | kfree(rd); | ||
214 | usb_free_urb(urb); | ||
215 | } | ||
216 | EXPORT_SYMBOL_GPL(rt2x00usb_register_read_async); | ||
217 | |||
168 | /* | 218 | /* |
169 | * TX data handlers. | 219 | * TX data handlers. |
170 | */ | 220 | */ |
@@ -212,6 +262,9 @@ static void rt2x00usb_interrupt_txdone(struct urb *urb) | |||
212 | if (!test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags)) | 262 | if (!test_and_clear_bit(ENTRY_OWNER_DEVICE_DATA, &entry->flags)) |
213 | return; | 263 | return; |
214 | 264 | ||
265 | if (rt2x00dev->ops->lib->tx_dma_done) | ||
266 | rt2x00dev->ops->lib->tx_dma_done(entry); | ||
267 | |||
215 | /* | 268 | /* |
216 | * Report the frame as DMA done | 269 | * Report the frame as DMA done |
217 | */ | 270 | */ |