smsc95xx: signedness bug in get_regs()

"retval" has to be a signed integer for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

1 files changed, 2 insertions, 1 deletions

diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 05ecf14d6597..bd7cbaa688e4 100644
--- a/drivers/net/usb/smsc95xx.c
+++ b/drivers/net/usb/smsc95xx.c
@@ -589,7 +589,8 @@ smsc95xx_ethtool_getregs(struct net_device *netdev, struct ethtool_regs *regs,
                          void *buf)
 {
         struct usbnet *dev = netdev_priv(netdev);
-        unsigned int i, j, retval;
+        unsigned int i, j;
+        int retval;
         u32 *data = buf;
 
         retval = smsc95xx_read_reg(dev, ID_REV, &regs->version);