diff options
author | David Decotigny <decot@google.com> | 2011-04-27 14:32:40 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-04-29 17:03:01 -0400 |
commit | 707394972093e2056e1e8cc39be19cf9bcb3e7b3 (patch) | |
tree | f6dc95219bca6895adf304b79241e9d60561f8f5 /drivers/net/ps3_gelic_net.c | |
parent | 25db0338813a8915457636b1f6abe6a28fa73f8d (diff) |
ethtool: cosmetic: Use ethtool ethtool_cmd_speed API
This updates the network drivers so that they don't access the
ethtool_cmd::speed field directly, but use ethtool_cmd_speed()
instead.
For most of the drivers, these changes are purely cosmetic and don't
fix any problem, such as for those 1GbE/10GbE drivers that indirectly
call their own ethtool get_settings()/mii_ethtool_gset(). The changes
are meant to enforce code consistency and provide robustness with
future larger throughputs, at the expense of a few CPU cycles for each
ethtool operation.
All drivers compiled with make allyesconfig ion x86_64 have been
updated.
Tested: make allyesconfig on x86_64 + e1000e/bnx2x work
Signed-off-by: David Decotigny <decot@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ps3_gelic_net.c')
-rw-r--r-- | drivers/net/ps3_gelic_net.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/net/ps3_gelic_net.c b/drivers/net/ps3_gelic_net.c index 4383ed21813e..b1f251da1535 100644 --- a/drivers/net/ps3_gelic_net.c +++ b/drivers/net/ps3_gelic_net.c | |||
@@ -1243,17 +1243,17 @@ static int gelic_ether_get_settings(struct net_device *netdev, | |||
1243 | 1243 | ||
1244 | switch (card->ether_port_status & GELIC_LV1_ETHER_SPEED_MASK) { | 1244 | switch (card->ether_port_status & GELIC_LV1_ETHER_SPEED_MASK) { |
1245 | case GELIC_LV1_ETHER_SPEED_10: | 1245 | case GELIC_LV1_ETHER_SPEED_10: |
1246 | cmd->speed = SPEED_10; | 1246 | ethtool_cmd_speed_set(cmd, SPEED_10); |
1247 | break; | 1247 | break; |
1248 | case GELIC_LV1_ETHER_SPEED_100: | 1248 | case GELIC_LV1_ETHER_SPEED_100: |
1249 | cmd->speed = SPEED_100; | 1249 | ethtool_cmd_speed_set(cmd, SPEED_100); |
1250 | break; | 1250 | break; |
1251 | case GELIC_LV1_ETHER_SPEED_1000: | 1251 | case GELIC_LV1_ETHER_SPEED_1000: |
1252 | cmd->speed = SPEED_1000; | 1252 | ethtool_cmd_speed_set(cmd, SPEED_1000); |
1253 | break; | 1253 | break; |
1254 | default: | 1254 | default: |
1255 | pr_info("%s: speed unknown\n", __func__); | 1255 | pr_info("%s: speed unknown\n", __func__); |
1256 | cmd->speed = SPEED_10; | 1256 | ethtool_cmd_speed_set(cmd, SPEED_10); |
1257 | break; | 1257 | break; |
1258 | } | 1258 | } |
1259 | 1259 | ||